Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 Aug 2022 14:06:46 +0100
From:   Mark Brown <broonie@kernel.org>
To:     patrice.chotard@foss.st.com
Cc:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        linux-spi@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        christophe.kerello@foss.st.com
Subject: Re: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi
 callback
Message-ID: <YvOtZtrRHd4AT+j+@sirena.org.uk>
References: <20220810093215.794977-1-patrice.chotard@foss.st.com>
 <20220810093215.794977-2-patrice.chotard@foss.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qIGcIJcaVg00Gpny"
Content-Disposition: inline
In-Reply-To: <20220810093215.794977-2-patrice.chotard@foss.st.com>
Precedence: bulk


--qIGcIJcaVg00Gpny
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 10, 2022 at 11:32:14AM +0200, patrice.chotard@foss.st.com wrote:

> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>=20
> v2: _ use parallel-memories property
>     _ set auto_runtime_pm to true
>     _ remove pm_runtime_*() usage in transfer_one_message() callback
> ---

The changelog should come after the --- so that it gets automatically
stripped out by tooling.  No need to resend just for this.

> +	/*
> +	 * Dual flash mode is only enable in case "parallel-memories" and
> +	 * "cs-gpios" properties are found in DT
> +	 */
> +	if (of_property_read_bool(dev->of_node, "parallel-memories") &&
> +	    of_gpio_named_count(dev->of_node, "cs-gpios")) {
> +		qspi->cr_reg =3D CR_DFM;
> +		dev_dbg(dev, "Dual flash mode enable");
> +	}

Do we need to add something to the DT bindings to indicate that
parallel-memories is valid?

--qIGcIJcaVg00Gpny
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLzrWUACgkQJNaLcl1U
h9AkJQf/Y+IYz/LCzWBub55CWbzvK9ruoENfm9CuX6uNA/3NAwmONWNa9ggB08wO
4TujrybikyjoRk1vZ7QNKx49cA/4npKx0vDeAplPuSSKKJYQJjIfcOBfYpVkurqX
w9mj2AptUhV9ZCc5wcasgXSz6uIvyl/RtyKjCc7o49laJq/pyEEgPPpH/hKaO+jH
lZM8oIHqlZcWxdhL5p0XDFPpZd2sbiFeY714yWVh2kX/bSx8DFNU8Y+NJ43gkgEH
5duFoaAQp9i2IfaoBT75NZgKUhiR+mmF+ujsc+7GMXbqp1ekFX3V6ynW7BavXs+X
Nh/xQwsJT6MvqILv4XCxHvVbWs48BA==
=p2wA
-----END PGP SIGNATURE-----

--qIGcIJcaVg00Gpny--