Received: by 2002:a05:6359:322:b0:b3:69d0:12d8 with SMTP id ef34csp224774rwb;
        Wed, 10 Aug 2022 07:21:57 -0700 (PDT)
X-Google-Smtp-Source: AA6agR5heFtB3CUwlgg9aI/+tqSHlnxLCdbneFCjfE4fsSCnuFXI36nCUowQD/X+C52Xg1wSt6dt
X-Received: by 2002:a05:6a00:804:b0:52f:43f9:b634 with SMTP id m4-20020a056a00080400b0052f43f9b634mr14388287pfk.62.1660141317668;
        Wed, 10 Aug 2022 07:21:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1660141317; cv=none;
        d=google.com; s=arc-20160816;
        b=V8O1nIFWrdCyuD88Y9SWwDf4vUoRwePORBzh2w+3LG0NcE1+QjAPVmik9aEdrs6dEo
         0eL64lweURkKfrJuHKS7ik2Aoy+J01nRgzoOIhd2nA/+xjJrBH1KUfZYluioU6GHOl2O
         +wTntdbU6pj6k/r8e9LgVLw0eV9l6xmnphyiKG4N7Y2o/NFzosNzdBHuEiSpGwfHNUBG
         CDksv6chXVBnuoI2joumvXzvcXjF0uT0jX0M43hctgd81f9VdiOIR6NBjQU9CVAaqw1Z
         LJqg9W03pwDm1e58Lv5hVbKjs1Ob4MvSF8n7fWBl9eNBEF8ZMYto0NLLwm0QcB+STTCQ
         Xt5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=8TlzB2Z5MzI6MeY+zEYUPzHFTRvWUXfvzTMiyxsoOl4=;
        b=ViPz/vOoh6Lirxm5uu/TMeK/SyhJPzzdDINchPHKeY/gxw0o8K3kW9wpMDZeRrw/Zp
         cWIln5G3OP82iLjeZ6enLjonwkL9QVlbeiFO9b/WaY70Q7QoP4R3tGWi8m2mOB5/O3sw
         jOCsMm1WIj8Wkgn8yxWkaycL4jbASFO1ffQEodM7A3WbphhhL8p7vc1Nhh2Fdii8On5b
         JCbBNhYZRGXR8m6YSJjHhprJKeEzCNq88gdAiQ07ysSI7i6IoEvTI7CSA7Oex+Dfzn2D
         j3VffdcLs0fWb7xf9++24mP3VAEJqVjryT12fxZzB82SKZ7ZUEk+MqE5K4eOvWXvKNoq
         69aA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id 3-20020a17090a000300b001f209736b9fsi1838302pja.174.2022.08.10.07.21.41;
        Wed, 10 Aug 2022 07:21:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232487AbiHJOJC (ORCPT <rfc822;andreas.noever@gmail.com>
        + 99 others); Wed, 10 Aug 2022 10:09:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46038 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233114AbiHJOIW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Aug 2022 10:08:22 -0400
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B18AD6EF27
        for <linux-kernel@vger.kernel.org>; Wed, 10 Aug 2022 07:08:15 -0700 (PDT)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 6176D68AA6; Wed, 10 Aug 2022 16:08:12 +0200 (CEST)
Date:   Wed, 10 Aug 2022 16:08:12 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Linjun Bao <meljbao@gmail.com>
Cc:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: align "fake" nqn with spec 1.3
Message-ID: <20220810140812.GA24773@lst.de>
References: <20220810133953.5411-1-meljbao@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220810133953.5411-1-meljbao@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 10, 2022 at 09:39:54PM +0800, Linjun Bao wrote:
> Replace '.' with '-' to align "fake" nqn format with nvme spec 1.3 or newer.

We can't just change the existing NQN construction if we don't want
to break userspace.  Maybe add a comment that it is different from
the canonical version for historic reasons instead.