Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 Aug 2022 15:49:09 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Da Xue <da@libre.computer>
Subject: Re: [PATCH] spi: meson-spicc: save pow2 datarate between messages
Message-ID: <YvPFZZ2HT2zK9XjQ@sirena.org.uk>
References: <20220809152019.461741-1-narmstrong@baylibre.com>
 <YvJ84qkuXdvVgXRm@sirena.org.uk>
 <39c2f53b-8f53-ceb1-ae0c-81e5e53d01aa@baylibre.com>
 <YvOmnDJA+ov49chC@sirena.org.uk>
 <518f22f4-1582-924c-9eaa-28ebbe53a632@baylibre.com>
 <YvPBX7zJ72RXnrpk@sirena.org.uk>
 <9dabe979-f6b5-329d-f017-a8f0c00adeca@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ueoh6h2+Qr1KrJd4"
Content-Disposition: inline
In-Reply-To: <9dabe979-f6b5-329d-f017-a8f0c00adeca@baylibre.com>
Precedence: bulk


--ueoh6h2+Qr1KrJd4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 10, 2022 at 04:40:04PM +0200, Neil Armstrong wrote:

> I don't think it's worth adding so much code for this since we already

I don't recall the code for clock providers being that hard?  They're
generally pretty small, some of the ASoC CODEC drivers did something
similar.

> had an open-coded function which perfectly worked before.

Except in the cases it didn't...

> I'm perfectly OK to remove the CCF driver for the legacy clock path
> and return back to the old open coded calculation since it perfectly
> worked and stop using the legacy clock path for new SoCs since it would
> never be selected anyway...

It does seem better to go the clock provider route TBH.

> ... but GX SoCs are broken so it would need an intermediate fix until
> I push the refactoring to cleanup all this.

I'm trying to figure out if this is actually fixing the problem or just
papering over one case where things happened to go badly.

--ueoh6h2+Qr1KrJd4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLzxWQACgkQJNaLcl1U
h9DYQQf/QZ4CbFLmTpm/v3VlaF0OZUMbkfJ+OzC3L2yQO8LFvsudGllwYcUAY0ks
Wgk3BuL7xPDkmstAgIoJulYomZKeUgP0vnpIfk6jlfzpdDQhfA/r2z/87nrQtjCw
9TrHXn5w9t6kDa5XIS0bE87+PHTqeuwmPcZJPNbU8faGXyJoegZPGBAb/HBpe4lz
m6fza4Zhx66dnbmQ3r9F5cW85yEeuD95BeW9FfN583uD87bzQAOaIqDJnvbMvDj4
gyu1xiiIw0QhxHLyNZZaMLMoaYWr4869eziFmcqNkwdejET11UqXwrnQusZzzUFs
JoOMpvNMSzkYCQo48Vy6CGJBsXtq8w==
=bPSm
-----END PGP SIGNATURE-----

--ueoh6h2+Qr1KrJd4--