Received: by 2002:a05:6359:322:b0:b3:69d0:12d8 with SMTP id ef34csp317670rwb; Wed, 10 Aug 2022 08:44:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR7AJt8cfjKYb09SjuXk5515c6Gk32mVKNn+ZnLxOyzCE9DUDiMMWJ3sZWVtyPWQcn149HMm X-Received: by 2002:a17:902:f652:b0:156:701b:9a2a with SMTP id m18-20020a170902f65200b00156701b9a2amr28105500plg.14.1660146277913; Wed, 10 Aug 2022 08:44:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660146277; cv=none; d=google.com; s=arc-20160816; b=nmNnn3uDXmpJgdqmd97yyVw4MIQ0LW8QSzcmgIRVCz/oSKzCuiA9fBy7s3XS2ECOQ3 t1kjX+1gZZRmVkNT0jMWSTmlZcozCYkJJdL2kzZxh/HTsuu3760faYLcA+cyUdaqwJZ9 bPeRaZSIDZUQLsPG8R+N2++URMcl06gp65qrUX0Wd94vSEz1UGWN/WVF35Ln9XiXp+MZ 2RZmpauVBPQnthqqnAouMNet51yQpMOz/hh/FH0YpzFNn0MRXEkkNSJS9Mn9HHN/XE0U JCj8w6g827uRsFoI52HQaqTx5X//f+ZeacRMgP1E/PciiTANu2ujqWOBsS2b1U4Vrg+2 Hg6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cG8xvQKiBdJX9SXoS6vRmGgtJj6VHwGg1+M+QpFiZX0=; b=NJvjFVI26CvI8v3KJoGEavZd+jmJK3EEuj7A3Wug5vuyEXp1t8hp/ck1aE5nKDhfDT FpJGEznYZd76FAHv8qVKKJY5N8mbcKMA24o1v5eTg9STR4fVZrGPMuuxOwePIj2rl+BQ BfaO3wDqidgNyInswHT93Mlfq6rkH//d8143QZWHZPSbp/A8KxHSc84nrhqxpLw/byp+ ixhxKXT/DLDd++1FXbGSb3nzD5FOdIb/tRq2FSYrygWRGsE5+Zf1W5p46OuuunABDjgD m3dpDVk5Oh9vMckXHdEkJmDhT/qSBczTKfbtfMDWJK+66ynQrbW44w6OlnlGbeo2CDaq xp9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=P8yh3XYP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a056a00150500b0052ae8f0c52fsi1702814pfu.152.2022.08.10.08.44.21; Wed, 10 Aug 2022 08:44:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=P8yh3XYP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233007AbiHJPN0 (ORCPT + 99 others); Wed, 10 Aug 2022 11:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233016AbiHJPNU (ORCPT ); Wed, 10 Aug 2022 11:13:20 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 463A5760F2 for ; Wed, 10 Aug 2022 08:13:19 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id c16so1913661qkk.10 for ; Wed, 10 Aug 2022 08:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=cG8xvQKiBdJX9SXoS6vRmGgtJj6VHwGg1+M+QpFiZX0=; b=P8yh3XYP1aTmKsbIM63fGeAMQUiciJA+lCZPsYCLMw5bhhOErtxWu7OSdtanxU2vGV irT56MEwr1wkp0dfHKUXMf0HmyKVRQWEX19IDltFSJ/ZI/210R/1G22JU81/JNd5gym1 rYJ+S8lSQPCBWsR7Rft//UpcpJXL+9eu1l6QT7cLkxHbeLuSMdYDYODtd+37cMukJd0x c30bIL+1+FLzUcDyVITJrSb9fjMSRXUnqCT8sVeNSEvZw1a41p1vnrUwRsv9P+aOHkuf GIv8W+GhtD99Hm0AKPt2E5KQhjmKXiRUFryebKgNI9Z4KmozZJwduXfWFN1GjwesAXbG mhUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=cG8xvQKiBdJX9SXoS6vRmGgtJj6VHwGg1+M+QpFiZX0=; b=OPqHRLAt4IWHGHoCaTIUB2rDNq69PJ9ZjVb+w5F086Y+XMCgZRStkYig57Btsg0F6N YzugRtPg9YDqOompg0MMEyUil5BV7DdTW9IlfoRsb3Hgd7eh+ej7D0QCuLoxtwNV/Fwd Von9bw8J7NzPNeOn+fX0nspOsvzBPdM6SPwMEqkCKDRmD37ZezgEBTiAtxx8NkJH9tJg DscsWFk3zlIhYkt9dnqHkxORrugG2azriqRvVzFXSLS7FsRKcyb1Jl46PAiSZYTbcpyw eJ1EhJrChX9C2KzaG5rWvybkysiJo7xI8hxBv3AUgV5jMXBt7GHqsBvhPKdKw4vfgxgT 9fAA== X-Gm-Message-State: ACgBeo2fEQdtpkbD0ncqXFAzFNYWVdTYEQiY7CQqXfXqmxUffeBOrZD/ QFkSQxphnMmYjyIHZ9geZBfk1w== X-Received: by 2002:a05:620a:471f:b0:6b6:1c52:9b7d with SMTP id bs31-20020a05620a471f00b006b61c529b7dmr21470582qkb.394.1660144398385; Wed, 10 Aug 2022 08:13:18 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-00ea-7f88-5fd9-01cd.res6.spectrum.com. [2603:7000:c01:2716:ea:7f88:5fd9:1cd]) by smtp.gmail.com with ESMTPSA id s11-20020a05622a1a8b00b0031d283f4c4dsm12904101qtc.60.2022.08.10.08.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 08:13:18 -0700 (PDT) Date: Wed, 10 Aug 2022 11:13:17 -0400 From: Johannes Weiner To: Hao Jia Cc: mingo@redhat.com, peterz@infradead.org, mingo@kernel.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS Message-ID: References: <20220806120510.96131-1-jiahao.os@bytedance.com> <20220806120510.96131-4-jiahao.os@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220806120510.96131-4-jiahao.os@bytedance.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 06, 2022 at 08:05:10PM +0800, Hao Jia wrote: > cgroup_psi() is only called under CONFIG_CGROUPS. > We don't need cgroup_psi() when !CONFIG_CGROUPS, > so we can remove it in this case. > > Signed-off-by: Hao Jia Acked-by: Johannes Weiner