Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 Aug 2022 16:16:23 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     matti.vaittinen@fi.rohmeurope.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/7] regulator: Add devm helpers for get and enable
Message-ID: <YvPLx5hizWMEBjVK@sirena.org.uk>
References: <cover.1660127865.git.mazziesaccount@gmail.com>
 <b6058e052b842a19c8bb639798d8692cd0e7589f.1660127865.git.mazziesaccount@gmail.com>
 <YvOdBv0edrE3wKsO@sirena.org.uk>
 <e8900490-1eec-83d8-b190-6d6983d81c4a@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+tMecClWfAgfuSlW"
Content-Disposition: inline
In-Reply-To: <e8900490-1eec-83d8-b190-6d6983d81c4a@gmail.com>
Precedence: bulk


--+tMecClWfAgfuSlW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 10, 2022 at 03:19:05PM +0300, Matti Vaittinen wrote:

> In order to tackle the issue the suggested API does not return handle to =
the
> regulators - it really just provides the "get'n enable, then forget"
> solution. The consumers who use the suggested API to "devm get'n enable"
> will have had time manually controlling the regulator afterwards as they
> will not get the handle. I would almost claim that the pattern we nowadays
> see (devm_get, enable, add_action_or_reset(disable())) is more error prone
> as users seem to in many case be storing the regulator handle w/o any
> comment about the automated disable at detach.

Hrm, right - that does help with that case.  However we do need a bulk=20
version since that's an obvious problem case.

--+tMecClWfAgfuSlW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLzy8YACgkQJNaLcl1U
h9DSPgf/aMwuVB03tEyJWgsMUoa/+AzXF+i+5ryTdmp8FB5hhK81JwSjAsSbtknL
eYh7L7XcgXOm3pwbnCLKC8nF7hJ+gqwfZHfnVnFF2EL+h8QZwBdXcAPN1HgCvJP+
J20/iIgxfKl+Qxb/Mk7jJBbv+u1hDzsEnCNHS8Xw5Y3hs/o+BuitSBASCnO+e4sm
HjmE8o5N/0HpSxLA9EGsX8w+iTwLNbyvjouAX/TqKPe3h5vYa9TOnS2s0z4tOleS
wuzwsEIEM/I1UjFtVDGNMit3yBBW1JOkJXo0E/ZrOR35/oNiS4YvCvDJ6BPQYisZ
UfeW5Y6Rzpib21/7etsbrxkD1pqGlg==
=aNEN
-----END PGP SIGNATURE-----

--+tMecClWfAgfuSlW--