Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a3b479b-dedc-2a73-32fa-5c0440048b7d@paragon-software.com>
Date:   Wed, 10 Aug 2022 19:17:11 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] fs/ntfs3: Remove unused function wnd_bits
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20220721031841.24571-1-jiapeng.chong@linux.alibaba.com>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <20220721031841.24571-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/21/22 06:18, Jiapeng Chong wrote:
> Since the function wnd_bits is defined but not called in any file, it is
> a useless function, and we delete it in view of the brevity of the code.
> 
> Remove some warnings found by running scripts/kernel-doc, which is
> caused by using 'make W=1'.
> 
> fs/ntfs3/bitmap.c:54:19: warning: unused function 'wnd_bits' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   fs/ntfs3/bitmap.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/fs/ntfs3/bitmap.c b/fs/ntfs3/bitmap.c
> index e3b5680fd516..177c5bc53373 100644
> --- a/fs/ntfs3/bitmap.c
> +++ b/fs/ntfs3/bitmap.c
> @@ -51,11 +51,6 @@ void ntfs3_exit_bitmap(void)
>   	kmem_cache_destroy(ntfs_enode_cachep);
>   }
>   
> -static inline u32 wnd_bits(const struct wnd_bitmap *wnd, size_t i)
> -{
> -	return i + 1 == wnd->nwnd ? wnd->bits_last : wnd->sb->s_blocksize * 8;
> -}
> -
>   /*
>    * wnd_scan
>    *

Applied, thanks!