Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <815b03aa-ab39-ec8b-294b-68dff36e2d54@kernel.org>
Date:   Wed, 10 Aug 2022 19:50:49 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v4 1/4] dt-bindings: mediatek: watchdog: Fix compatible
 fallbacks and example
Content-Language: en-US
To:     Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        angelogioacchino.delregno@collabora.com,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20220721014845.19044-1-allen-kh.cheng@mediatek.com>
 <20220721014845.19044-2-allen-kh.cheng@mediatek.com>
 <CAGXv+5HXwVpaJPV-4Z6qw14xZzEkx_E7dVks6-GBa7bQyN8hCg@mail.gmail.com>
 <5dac39d1-3b42-40e9-5693-0c127e8c689a@gmail.com>
 <0fadcd9f50d49ecbb329e76a9ceb6ee689648955.camel@mediatek.com>
 <20220808170355.c2ih3xwqxlddsal7@notapiano>
 <6271732eb27824c5b841760243738ceb062f4c4a.camel@mediatek.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <6271732eb27824c5b841760243738ceb062f4c4a.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/08/2022 15:58, Allen-KH Cheng wrote:
> I agree the advantage of patch is aesthetic. Since I also want to send
> another "watchdog: Convert binding to YAML" PATCH, it's better let all
> wdt compatibles in the binding match the contents of mtk_wdt_dt_ids in
> drivers/watchdog/mtk_wdt.c
> 
> static const struct of_device_id mtk_wdt_dt_ids[] = {
> 	{ .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
> 	{ .compatible = "mediatek,mt6589-wdt" },
> 	{ .compatible = "mediatek,mt7986-wdt", .data = &mt7986_data },
> 	{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
> 	{ .compatible = "mediatek,mt8186-wdt", .data = &mt8186_data },
> 	{ .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
> 	{ .compatible = "mediatek,mt8195-wdt", .data = &mt8195_data },
> 	{ /* sentinel */ }
> };
> 
> We have "mediatek,mt8186-wdt" "mediatek,mt8195-wdt" and
> "mediatek,mt7986-wdt" now and they have their DT data for the reset
> control.
> 
> It's weird and unuseful to add "mediatek,mt6589-wdt" as fallback. 
> 
> 
> Please kindly let me know if I missed anything

How the driver arranges it should not be a reason to use or not to use
specific fallback. Although Rob acked it, but I still think you did not
provide valid reason for the change.

Valid reason is usually the actual hardware (so they are actually not
compatible with mt6589), not exactly how once someone did it in the driver.

Best regards,
Krzysztof