Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da087ad9-981a-2a9f-a134-1f6cab7addc0@intel.com>
Date:   Wed, 10 Aug 2022 10:20:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] igc: Remove _I_PHY_ID check for i225 devices
Content-Language: en-US
To:     Linjun Bao <meljbao@gmail.com>
CC:     Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220809133502.37387-1-meljbao@gmail.com>
 <b39c9fa3-1b7c-c7b1-c3dd-bf5ceb035dc8@intel.com>
 <0b4ce201-be78-5a5d-0098-0cbe14ea43fd@gmail.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <0b4ce201-be78-5a5d-0098-0cbe14ea43fd@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alNsWDM2UGlEQmF3dTVkd3d2Qkc4NmZXUDRsc3hLZHRnUlU5d3A2SVJUNnQx?=
 =?utf-8?B?U01RYVhwcXVaNHdEem1EbTdrOXNhT295cFZZUUtaa2lZNFZ4WklteEw2d3M5?=
 =?utf-8?B?Q042U2tkKytWeXFqcHJYOEFTb3hiTnhFeU5weG5TQlI5Z0hGendpWm0rcmx0?=
 =?utf-8?B?dXJLQU45SGpBaXpGYmd2UzJzMkY5ZnI3K2FYczF2K3VzTFUyQXBEKzRmMUFR?=
 =?utf-8?B?N0F4NnRjTUQvR2dVNTYreWhHTnVlWmg4bG4yT0NVenlOWXRnK0pOSWc5NFQ0?=
 =?utf-8?B?ejhwbWt3M3RKWVlMcnRMbExSRGhqdEd3OEswWWExazFGODRhQlZqenRKc2xV?=
 =?utf-8?B?NE9yWHhxYnF3UkNudjZvK2h4ejh3RmN0VGVFTlljWVNobytEREFXTDJhNVRK?=
 =?utf-8?B?YmYrWTFYZ05CQmFlYnBEbDJVNTl5V0drTXhuTGdWOHBhZmNpTEtYaHJvb1FV?=
 =?utf-8?B?WHRxVTJ5ZDlSOUJCdTQwSXdGa21ubTZiTVBPQStoZW4vdHdDWmRnQkh0bmx5?=
 =?utf-8?B?VjM4TFJ2OTZyanNhSzkzZTdYMUhjZlF0aWZGYklqb0hXQmtQaldPZm1PMCtG?=
 =?utf-8?B?YjQwVGROVlBzaFZKQng3SEVGNzNXVVZIeWZhdWdPT1hoaXBNemhlSXNOdVZK?=
 =?utf-8?B?anNWMWhBZ2xMeStuZW5TdE1MVktka3BvUzhlemJTSDJiMEUwSzR3ZThEMkRM?=
 =?utf-8?B?T2dMU3krdFVXajl4aGg3WTNrcnlHN3VGekNyNjZlT2s2bWkyOTFvTjhJTDRW?=
 =?utf-8?B?M25wczBpYmpWQWtwSnB1NWVJUUEzRHk2dzExNkIvOGtyQXlXRG1kUlFzMzBX?=
 =?utf-8?B?cTFKVERLcFk5WXBzNEsyVDNnUHM4WWsrY0o5VmtLREdSY1R0OTlBUEVrbUVT?=
 =?utf-8?B?U0dKUUJ0U1UyamJIQ3l6b3prWXg2Vkl1STJINE9jSjdpUS9SRVRKMTV3VWw5?=
 =?utf-8?B?K1ZBNXcvRUQ0SjZNaWRXSTZoOUlZc2x1eTFqVjhWak9mOCtpOHIzSzltNis0?=
 =?utf-8?B?SS90QkdkbmNSUHhTOUhuTnhiUldLWUdmVE03L0ZKNHBBWjN6L1ZTQ0kxVll6?=
 =?utf-8?B?dU5EVUtiY2FreEc4SmJySG1IUnFtR2lOYUhHeTFaYkozcjlEaUlmSkFHZitW?=
 =?utf-8?B?ZDAya3ZxUFdIR3VrOGtleGErTUVEbVh4MHNhR3ZGT1hJN0w0OWgwUWk2Nmpz?=
 =?utf-8?B?aERWUmgwUkNXWnM4NllFY2x5S1ZGTEIxSUpCay9la3dLYmo1NzkvUjJ6SmJB?=
 =?utf-8?B?eU1BMHA1cENuakpJUjhBMWVrbE1XUlZZcm9kZmIvSDR1VnpDUS96Zks1Y09x?=
 =?utf-8?B?SHNlSFZiSlU4M1FVUjFzeG5IcGlNalJxYVlkMkZ5NkRycGhVNTI2VW5UQlJ3?=
 =?utf-8?B?dWxPYXRGemdoQ01rZnNiTVFjc1RHNjFHUldSdUp2NXlzQXJQUk5SazA3YzVV?=
 =?utf-8?B?enVyZXR2U09LOWI3NlJDbDZmcWFxQ1pKc0ZDekhFTzRNTmY2OXVISmYycVVL?=
 =?utf-8?B?Q0tFTTBPeDJmeEpxS1NIVEwxMWI3R090SE5obkQrSm9FbTd6MU9kQjNyVloy?=
 =?utf-8?B?MmhRSFJGTVNTblk1cTExbnpObWVpZlFGRDQzUHJBR01ocHpTUHltVmtxZlVQ?=
 =?utf-8?B?VDdQUmdRNzZ5WVZTQlhvczlxbTRhWmdWcGdnNE1tMUk2cThhL3hlUklnSm13?=
 =?utf-8?B?QmJRNHpUeVFDQnpGb0VPd3M2U0lqS2VsdkdpZWJxd0RtQ3BFb0RUR2YzbHE1?=
 =?utf-8?B?NHhpQTlZZkMzRlZ1SHdCVGZDOTBkNFM2UjlCRm9yVkhOTDlDcU9iKzJlRkFJ?=
 =?utf-8?B?VUorQmp1dWhVaXVNTDhISEFWaUxxU1FEbDB2WXNHZnZwMXhqc0dUNlFFVW9G?=
 =?utf-8?B?cU9ybi9TT2Zmb2x0cTRnT3pMNFBQc0dYbGxzU2RLQXVXT3h6aTcwSWtCSnow?=
 =?utf-8?B?MUdVL29RTks1UGR3eUFUUmpCTG5Kb2JsWHRWRTJybGVORGhCcG5oOHVhY0lv?=
 =?utf-8?B?VWFVbHFtZVl4ZjhNdFJGQW9tYVkvTEpaRG9RaFQ0Q2F2bXRkRWlMKzlnUFFI?=
 =?utf-8?B?WlpZWDRvbVpPN2c4V3VRWlRLcDBLVThtU1RnZTBRTTNmKzh3RklnbnhHSGhr?=
 =?utf-8?B?dE1nMVlTSTIrbmdrUzVzWUozNUlIdkN2Z2JCcnBNNjhZYnUrYXRVUXluanhZ?=
 =?utf-8?B?eEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbaf51ab-34b1-415f-960b-08da7af4ae78
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2022 17:20:54.5499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d4OKphV+kl5A9LYTdycBk3Hxj74aQVCejuKB7sH+LQ0mHMC5LZ/vFXftb7FGIqAooFnuOE/b+ItlK4m9n5SU5sS165i0s785RJdUVD+HOoY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3751
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/10/2022 1:22 AM, Linjun Bao wrote:
> Yes this commit was committed to mainline about one year ago. But this commit has not been included into kernel 5.4 yet, and I encountered the probe failure when using alderlake-s with Ethernet adapter i225-LM. Since I could not directly apply the patch 7c496de538ee to kernel 5.4, so I generated this patch for kernel 5.4 usage.
> 
> 
> Looks like sending a duplicated patch is not expected. Would you please advise what is the proper action when encountering such case? 

Sounds like you want this backported to stable. Documentation on how to 
do it is here [1]. Option 3 seems to be the correct choice.

Thanks,
Tony

[1] 
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#procedure-for-submitting-patches-to-the-stable-tree