Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: dsG90+R46ox6j0RyVHN3TtaVpWWkKeqzPzXxZNog60PrtWU6FUcDnlLuaBtbjPEKRTFcmRbts9
 f+QG0PxUsxzgafLiByfB7N1Mq6w/7pxYwlHck0nJcP0kurBnpvJWPKiejQvbXBa+qXZ6HLCOEs
 1JNI5sOyYh4pYhuidKpgy9Q5CxQVgJYfgygqY+zYwboYrtj8FdPx5/LSHNKtOpFoFBtplmRx3i
 8yRS0HQE5pjdIYXeqcSHP17xoGuC3SP5UJ0YWtqqRsZd/W7gBu7Mm5DC6nLhxxvhnnvQ5f0e/2
 MvYcvzYCpNzvbzWx/HIm732G
IronPort-SDR: 628qlwonISVRGl67cY8N6r6Y/OAkCPRRBNHCVgdCDec1jryuGZvazGXtQH5a8ZRl6TW3d5ZEab
 q0yM62ZH/7ltAHW/2pBwNiX0Co/6xDo0Rr22V33lUqk4DjTmVdwpUWVgA0S8P7KKNphC7Tcw4c
 HVsfr96v5Om5b601xqK8AOGgTUIiLXwVVbXXtsYQIYJ567HMZHYTrxBQz/otE6bjRdQGYMR4W9
 ZenMSjYjVHjodD8BPM6HEe8bYuKsadoM7dp0FTeRVacDAjXzwWwDGMM7JRce74oADpCfM7aabN
 SbA=
WDCIronportException: Internal
Message-ID: <4a045887-6d44-661d-24d2-4f0cf039a058@opensource.wdc.com>
Date:   Wed, 10 Aug 2022 10:10:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.12.0
Subject: Re: [PATCH v9 08/13] dm-zoned: ensure only power of 2 zone sizes are
 allowed
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, Johannes.Thumshirn@wdc.com,
        snitzer@kernel.org, axboe@kernel.dk, agk@redhat.com, hch@lst.de
Cc:     dm-devel@redhat.com, matias.bjorling@wdc.com, gost.dev@samsung.com,
        linux-kernel@vger.kernel.org, pankydev8@gmail.com,
        jaegeuk@kernel.org, hare@suse.de, linux-block@vger.kernel.org,
        linux-nvme@lists.infradead.org, bvanassche@acm.org,
        Luis Chamberlain <mcgrof@kernel.org>
References: <20220803094801.177490-1-p.raghav@samsung.com>
 <CGME20220803094811eucas1p17a2ac191899bba7938de6b9e3a55352f@eucas1p1.samsung.com>
 <20220803094801.177490-9-p.raghav@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220803094801.177490-9-p.raghav@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/08/03 2:47, Pankaj Raghav wrote:
> From: Luis Chamberlain <mcgrof@kernel.org>
> 
> dm-zoned relies on the assumption that the zone size is a
> power-of-2(po2) and the zone capacity is same as the zone size.
> 
> Ensure only po2 devices can be used as dm-zoned target until a native
> non po2 support is added.
> 
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/md/dm-zoned-target.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
> index 95b132b52f33..9325bf5dee81 100644
> --- a/drivers/md/dm-zoned-target.c
> +++ b/drivers/md/dm-zoned-target.c
> @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
>  				return -EINVAL;
>  			}
>  			zone_nr_sectors = bdev_zone_sectors(bdev);
> +			if (!is_power_of_2(zone_nr_sectors)) {
> +				ti->error = "Zone size is not a power-of-2 number of sectors";
> +				return -EINVAL;
> +			}
>  			zoned_dev->zone_nr_sectors = zone_nr_sectors;
>  			zoned_dev->nr_zones = bdev_nr_zones(bdev);
>  		}
> @@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
>  			return -EINVAL;
>  		}
>  		zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev);
> +		if (!is_power_of_2(zoned_dev->zone_nr_sectors)) {
> +			ti->error = "Zone size is not a power-of-2 number of sectors";
> +			return -EINVAL;
> +		}
>  		zoned_dev->nr_zones = bdev_nr_zones(bdev);
>  	}
>  


-- 
Damien Le Moal
Western Digital Research