Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220810160209.1630707-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220810160209.1630707-1-Liam.Howlett@oracle.com>
From:   Ondrej Mosnacek <omosnace@redhat.com>
Date:   Wed, 10 Aug 2022 20:14:10 +0200
Message-ID: <CAFqZXNuOvt_p0ZNjh89Vt9sGQ=CE5_GLr+XOT6OkzxcHdEHgKQ@mail.gmail.com>
Subject: Re: [PATCH v2] binder_alloc: Add missing mmap_lock calls when using
 the VMA
To:     Liam Howlett <liam.howlett@oracle.com>
Cc:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        syzbot <syzbot+a7b60a176ec13cafb793@syzkaller.appspotmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>,
        Minchan Kim <minchan@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hridya Valsaraju <hridya@google.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Martijn Coenen <maco@android.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Todd Kjos <tkjos@android.com>,
        Matthew Wilcox <willy@infradead.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Carlos Llamas <cmllamas@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 10, 2022 at 6:02 PM Liam Howlett <liam.howlett@oracle.com> wrote:
> Take the mmap_read_lock() when using the VMA in
> binder_alloc_print_pages() and when checking for a VMA in
> binder_alloc_new_buf_locked().
>
> It is worth noting binder_alloc_new_buf_locked() drops the VMA read lock
> after it verifies a VMA exists, but may be taken again deeper in the
> call stack, if necessary.
>
> Reported-by: Ondrej Mosnacek <omosnace@redhat.com>
> Reported-by: syzbot+a7b60a176ec13cafb793@syzkaller.appspotmail.com
> Fixes: a43cfc87caaf (android: binder: stop saving a pointer to the VMA)
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
>  drivers/android/binder_alloc.c | 31 +++++++++++++++++++++----------
>  1 file changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index f555eebceef6..c5e7c6d3a844 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -395,12 +395,15 @@ static struct binder_buffer *binder_alloc_new_buf_locked(
>         size_t size, data_offsets_size;
>         int ret;
>
> +       mmap_read_lock(alloc->vma_vm_mm);
>         if (!binder_alloc_get_vma(alloc)) {
> +               mmap_read_unlock(alloc->vma_vm_mm);
>                 binder_alloc_debug(BINDER_DEBUG_USER_ERROR,
>                                    "%d: binder_alloc_buf, no vma\n",
>                                    alloc->pid);
>                 return ERR_PTR(-ESRCH);
>         }
> +       mmap_read_unlock(alloc->vma_vm_mm);
>
>         data_offsets_size = ALIGN(data_size, sizeof(void *)) +
>                 ALIGN(offsets_size, sizeof(void *));
> @@ -922,17 +925,25 @@ void binder_alloc_print_pages(struct seq_file *m,
>          * Make sure the binder_alloc is fully initialized, otherwise we might
>          * read inconsistent state.
>          */
> -       if (binder_alloc_get_vma(alloc) != NULL) {
> -               for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) {
> -                       page = &alloc->pages[i];
> -                       if (!page->page_ptr)
> -                               free++;
> -                       else if (list_empty(&page->lru))
> -                               active++;
> -                       else
> -                               lru++;
> -               }
> +
> +       mmap_read_lock(alloc->vma_vm_mm);
> +       if (binder_alloc_get_vma(alloc) == NULL) {
> +               mmap_read_unlock(alloc->vma_vm_mm);
> +               goto uninitialized;
>         }
> +
> +       mmap_read_unlock(alloc->vma_vm_mm);
> +       for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) {
> +               page = &alloc->pages[i];
> +               if (!page->page_ptr)
> +                       free++;
> +               else if (list_empty(&page->lru))
> +                       active++;
> +               else
> +                       lru++;
> +       }
> +
> +uninitialized:
>         mutex_unlock(&alloc->mutex);
>         seq_printf(m, "  pages: %d:%d:%d\n", active, lru, free);
>         seq_printf(m, "  pages high watermark: %zu\n", alloc->pages_high);
> --
> 2.35.1

Can confirm that with this patch the selinux-testsuite's binder test
passes again with no warnings in dmesg.

Tested-by: Ondrej Mosnacek <omosnace@redhat.com>

Thanks!

-- 
Ondrej Mosnacek
Senior Software Engineer, Linux Security - SELinux kernel
Red Hat, Inc.