Received: by 2002:a05:6359:322:b0:b3:69d0:12d8 with SMTP id ef34csp60291rwb; Wed, 10 Aug 2022 14:51:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR6wH/X27wEqlAqGU0mZuejSUVhRbBCve8+yC68+LGsZIOM3aR+WQq2UZxtreMlO6DGtYegr X-Received: by 2002:a17:903:2448:b0:171:4853:e580 with SMTP id l8-20020a170903244800b001714853e580mr223908pls.145.1660168292589; Wed, 10 Aug 2022 14:51:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660168292; cv=none; d=google.com; s=arc-20160816; b=atDiquJaHnfBIr6966/wceOVJvPwbWVxJlUXq8635G+NYq879UHRso6r8bIwbUxw8n wGLxM3IKl2946WmxJXImClKn1eW/J7VOHpsvYin3AokQiaZW6IyGUjQrvrTlf/RZ73+d AOJ0DQT7HxJ71Ek7kuOJWPUZ5xSvtYmOd0Ko9h51zW6xJYX9g2PbntDHEyd5CDXBQUiQ 0IPGeqhdZeITrNrUlWP+2w9VJ/rD/MR5aYNux5EzoVe/lwOZxN5lUtZpW7uBqMmHao7E gWuJ6xJTpEf17vz8C9dwjfA+th+BMp8NFXItqBlBdkztbemjbjYqVOQTnT9h32dxwhaR QrQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YshFOUWfjj6rMzDFqR1WUUSqF3Kl3ebmEh2tAp2rrac=; b=AJjBgT9hbbsH0sIFO03GS4R1LnUoIPrRSc+FlgxolIFgLT3FuVDBkA4iKR3yI0XxQ1 D3v8for3uwYFHKfMmhnVWWWieqI+IQ0IhcsSMCWFIrZq6DGfD11OriAvtQeJz8k1Feyy slm+4knDG0AS2yCdidecnk1WiBBWoJPkgLspvdz26GugyiuLPl0Yd5amWFAtKdeskJy2 gx8zSnypDKU3UcFlZwT7fweHjm+SKwwMgB8OMKlg8dYUXMuszTqThjRd2F15NC1yNq5x WpYRZAO5QBiiVBu4gwqHKmYII/HpC/VZkIBPckqHJRzks/0LvXm74gVyc7NyaoHe8T76 Iifw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=HgvldGL+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a056a00080a00b0052b9043d8fcsi1154242pfk.35.2022.08.10.14.51.19; Wed, 10 Aug 2022 14:51:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=HgvldGL+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbiHJVbK (ORCPT + 99 others); Wed, 10 Aug 2022 17:31:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232878AbiHJVbH (ORCPT ); Wed, 10 Aug 2022 17:31:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92CD533A17 for ; Wed, 10 Aug 2022 14:31:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 53BDFB81EA4 for ; Wed, 10 Aug 2022 21:31:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0D28C433C1; Wed, 10 Aug 2022 21:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660167064; bh=NK5lGETgJ8mV70zk2IetcbwhCrJmhDXBruOENzA6gx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HgvldGL+0W0bZUXB4GMdvA8WAn0MnQAf5RshM9DXqFgYnCo9exBMfdSF5xuPBY0QL BOzOf+35p230OeMwcerWHA4EvX3W682/mJqLmg3qlMdVW2QtQOIm8EXMD1EbWk9dnC A6SbZldUcxeYrFpCp+DVbqLGmNVngiJ3PzXez/8Y= Date: Wed, 10 Aug 2022 14:31:02 -0700 From: Andrew Morton To: Charan Teja Kalla Cc: , , , , , Subject: Re: [PATCH] mm/cma_debug: show complete cma name in debugfs directories Message-Id: <20220810143102.595072879e4bae7f7c46e3e6@linux-foundation.org> In-Reply-To: <1660152485-17684-1-git-send-email-quic_charante@quicinc.com> References: <1660152485-17684-1-git-send-email-quic_charante@quicinc.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Aug 2022 22:58:05 +0530 Charan Teja Kalla wrote: > Currently only 12 characters of the cma name is being used as the debug > directories where as the cma name can be of length CMA_MAX_NAME(=64) > characters. One side problem with this is having 2 cma's with first > common 12 characters would end up in trying to create directories with > same name and fails with -EEXIST thus can limit cma debug functionality. I guess so. There might be back-compatibility issues, but it's debugfs... > Also drop 'cma-' prefix for the cma debug directories as they are > clearly evident that they are for cma debug through creating them in > /sys/kernel/debug/cma/ path. I guess so. But please run `grep -r cma- Documentation'