Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c0e46d84-5015-34b4-a80b-758562118bde@intel.com>
Date:   Wed, 10 Aug 2022 14:57:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] x86/apic: Don't disable x2APIC if locked
Content-Language: en-US
To:     Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "Shutemov, Kirill" <kirill.shutemov@intel.com>
Cc:     "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        "Gomez Iglesias, Antonio" <antonio.gomez.iglesias@intel.com>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
References: <20220809234000.783284-1-daniel.sneddon@linux.intel.com>
 <d6ffb489-7024-ff74-bd2f-d1e06573bb82@intel.com>
 <238ea612-5a25-9323-b31f-0a14493db2f7@linux.intel.com>
 <d4bcb22e-224c-d256-cb93-3ff6ed89a7d0@intel.com>
 <341ea6e9-d8f3-ee7a-6794-67408abbf047@linux.intel.com>
 <d315aac4-8cda-bc2d-d052-09fb0649b1ad@intel.com>
 <2446fb33-9c5c-642a-797e-4e93345adb82@linux.intel.com>
 <ef3055a8-9cfd-cbd1-d76c-a2242836d16d@linux.intel.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <ef3055a8-9cfd-cbd1-d76c-a2242836d16d@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/10/22 13:29, Daniel Sneddon wrote:
> On 8/10/22 13:06, Daniel Sneddon wrote:
>> I could add a blurb to the
>> documentation where nox2apic is defined as a parameter as well.  
> While I'm at it, I'm thinking of adding something where CONFIG_X86_X2APIC is
> defined in kconfig.  I'll put in a blurb about selecting N on SPR systems could
> prevent you from booting due to the lock.

Please don't make it _too_ specific.  This is, after all, new
architecture that is presumably going to be in place long after we all
forget what SPR is.

Good Kconfig text would probably be something along the lines of:

	Some ~2022 and later systems are locked into x2APIC mode and can
	not fall back to the legacy APIC modes.  They will be unable to
	boot without enabling this option.

Would anybody hate if we just removed the CONFIG_X86_X2APIC prompt entirely?