Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 10:29:44 +0800
From:   Zhenyu Wang <zhenyu.z.wang@intel.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     zhi.a.wang@intel.com, intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com,
        joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
        tvrtko.ursulin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i915/gvt: Fix Comet Lake
Message-ID: <20220811022944.GB1089@zhen-hp.sh.intel.com>
Reply-To: Zhenyu Wang <zhenyu.z.wang@intel.com>
References: <166016852965.780835.10366587502693016900.stgit@omen>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="VYvi4N5CyHZx5xNE"
Content-Disposition: inline
In-Reply-To: <166016852965.780835.10366587502693016900.stgit@omen>
Precedence: bulk


--VYvi4N5CyHZx5xNE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2022.08.10 15:55:48 -0600, Alex Williamson wrote:
> Prior to the commit below the GAMT_CHKN_BIT_REG address was setup for
> devices matching (D_KBL | D_CFL), where intel_gvt_get_device_type()
> returns D_CFL for either Coffee Lake or Comet Lake.  Include the missed
> platform.`
>=20
> Link: https://lore.kernel.org/all/20220808142711.02d16782.alex.williamson=
@redhat.com
> Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT=
-g")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>  drivers/gpu/drm/i915/intel_gvt_mmio_table.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c b/drivers/gpu/dr=
m/i915/intel_gvt_mmio_table.c
> index 157e166672d7..5595639d0033 100644
> --- a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> +++ b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> @@ -1076,7 +1076,8 @@ static int iterate_skl_plus_mmio(struct intel_gvt_m=
mio_table_iter *iter)
>  	MMIO_D(GEN8_HDC_CHICKEN1);
>  	MMIO_D(GEN9_WM_CHICKEN3);
> =20
> -	if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))
> +	if (IS_KABYLAKE(dev_priv) ||
> +	    IS_COFFEELAKE(dev_priv) || IS_COMETLAKE(dev_priv))
>  		MMIO_D(GAMT_CHKN_BIT_REG);
>  	if (!IS_BROXTON(dev_priv))
>  		MMIO_D(GEN9_CTX_PREEMPT_REG);
>=20

Thanks for catching this!

Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>


--VYvi4N5CyHZx5xNE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYvRpkwAKCRCxBBozTXgY
J2gcAJ9dPJreOMASPcIJVCkUov/utI/JmQCcCEF2AsdY8g2aRrUk9EbIcdAnagk=
=DhCn
-----END PGP SIGNATURE-----

--VYvi4N5CyHZx5xNE--