Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b816f58a-ce25-c079-c6b3-a3406df246f9@openvz.org>
Date:   Thu, 11 Aug 2022 06:19:12 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 0/3] enable memcg accounting for kernfs objects
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>,
        =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-kernel@vger.kernel.org, kernel@openvz.org,
        Shakeel Butt <shakeelb@google.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Muchun Song <songmuchun@bytedance.com>,
        Michal Hocko <mhocko@suse.com>,
        Johannes Weiner <hannes@cmpxchg.org>
References: <0414cab3-32d6-c60a-d3c8-96fc72064ba0@openvz.org>
 <YvKZ8zYJFhhFvRxO@slm.duckdns.org> <20220809174934.GC10478@blackbody.suse.cz>
 <YvKfxGvg5/J0+QoD@slm.duckdns.org>
From:   Vasily Averin <vvs@openvz.org>
In-Reply-To: <YvKfxGvg5/J0+QoD@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/9/22 20:56, Tejun Heo wrote:
> Hello,
> 
> On Tue, Aug 09, 2022 at 07:49:34PM +0200, Michal Koutný wrote:
>> On Tue, Aug 09, 2022 at 07:31:31AM -1000, Tejun Heo <tj@kernel.org> wrote:
>>> I'm not quite sure whether following the usual "charge it to the allocating
>>> task's cgroup" is the best way to go about it. I wonder whether it'd be
>>> better to attach it to the new cgroup's nearest ancestor with memcg enabled.
>>
>> See also 
>> https://lore.kernel.org/r/YnBLge4ZQNbbxufc@blackbook/
>> and
>> https://lore.kernel.org/r/20220511163439.GD24172@blackbody.suse.cz/
> 
> Ah, thanks. Vasily, can you please include some summary of the discussions
> and the rationales for the path taken in the commit message?

Dear Tejun,
thank you for the feedback, I'll do it in next patch set iteration.

However, I noticed another problem in neighborhood and I planned to
add new patches into current patch set. One of the new patches is quite simple,
however second one is quite complex and requires some discussion.

So I'm still thinking how best to solve these issues.

Thank you,
	Vasily Averin