Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 07:46:35 +0200
Message-ID: <878rnvuybo.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mohan Kumar <mkumard@nvidia.com>
Cc:     <tiwai@suse.com>, <perex@perex.cz>, <cezary.rojewski@intel.com>,
        <treding@nvidia.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: Fix crash due to jack poll in suspend
In-Reply-To: <20220811052704.2944-1-mkumard@nvidia.com>
References: <20220811052704.2944-1-mkumard@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 11 Aug 2022 07:27:04 +0200,
Mohan Kumar wrote:
> 
> With jackpoll_in_suspend flag set, there is a possibility that
> jack poll worker thread will run even after system suspend was
> completed. Any register access after system pm callback flow
> will result in kernel crash as still jack poll worker thread
> tries to access registers.
> 
> To fix the crash issue during system flow, cancel the jack poll
> worker thread during system pm prepare callback and cancel the
> worker thread at start of runtime suspend callback and re-schedule
> at last to avoid any unwarranted access of register by worker thread
> during suspend flow.
> 
> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>

Thanks, applied now with Fixes tag.


Takashi