Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7e36aa4-899e-fb7d-ef2e-cf4e5925fbb1@quicinc.com>
Date:   Thu, 11 Aug 2022 12:13:33 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] mm/cma_debug: show complete cma name in debugfs
 directories
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     <david@redhat.com>, <vbabka@suse.cz>, <quic_pkondeti@quicinc.com>,
        <minchan@kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <1660152485-17684-1-git-send-email-quic_charante@quicinc.com>
 <20220810143102.595072879e4bae7f7c46e3e6@linux-foundation.org>
From:   Charan Teja Kalla <quic_charante@quicinc.com>
In-Reply-To: <20220810143102.595072879e4bae7f7c46e3e6@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks Andrew!!

On 8/11/2022 3:01 AM, Andrew Morton wrote:
> On Wed, 10 Aug 2022 22:58:05 +0530 Charan Teja Kalla <quic_charante@quicinc.com> wrote:
> 
>> Currently only 12 characters of the cma name is being used as the debug
>> directories where as the cma name can be of length CMA_MAX_NAME(=64)
>> characters. One side problem with this is having 2 cma's with first
>> common 12 characters would end up in trying to create directories with
>> same name and fails with -EEXIST thus can limit cma debug functionality.
> 
> I guess so.  There might be back-compatibility issues, but it's
> debugfs...
> 
> 
>> Also drop 'cma-' prefix for the cma debug directories as they are
>> clearly evident that they are for cma debug through creating them in
>> /sys/kernel/debug/cma/ path.
> 
> I guess so.  But please run `grep -r cma- Documentation'

I see the Documentation/admin-guide/mm/cma_debugfs.rst is not upto date.
Commit f318dd083c81 ("cma: Store a name in the cma structure") moved the
cma names from int to strings but no update to this document.

Will fix the Documentation part in V2.

>