Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 10:29:32 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        James Morse <james.morse@arm.com>,
        Robert Richter <rric@kernel.org>,
        Greg Kroah-Hartman <gregkh@suse.de>,
        Doug Thompson <dougthompson@xmission.com>,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] EDAC: Fix some refcount leaks
Message-ID: <YvS97Ixj2cbOBjek@zn.tnic>
References: <20220512075906.21915-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220512075906.21915-1-linmq006@gmail.com>
Precedence: bulk

On Thu, May 12, 2022 at 11:59:06AM +0400, Miaoqian Lin wrote:
> kobject_init_and_add() takes reference even when it fails.
> According to the doc of kobject_init_and_add()
> 
>    If this function returns an error, kobject_put() must be called to
>    properly clean up the memory associated with the object.
> 
> Fix this by calling kobject_put() when kobject_init_and_add() fails.
> 
> Fixes: b2ed215a3338 ("Kobject: change drivers/edac to use kobject_init_and_add")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> Changes on v2:
> - fix wrong label
> v1 link: https://lore.kernel.org/all/20220511081402.19784-1-linmq006@gmail.com/
> ---
>  drivers/edac/edac_device_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c
> index 9a61d92bdf42..a48142a8ea6f 100644
> --- a/drivers/edac/edac_device_sysfs.c
> +++ b/drivers/edac/edac_device_sysfs.c
> @@ -542,7 +542,7 @@ static int edac_device_create_block(struct edac_device_ctl_info *edac_dev,
>  		edac_dbg(1, "Failed to register instance '%s'\n", block->name);
>  		kobject_put(main_kobj);
>  		err = -ENODEV;
> -		goto err_out;
> +		goto err_on_attrib;
>  	}
>  
>  	/* If there are driver level block attributes, then added them

Actually, on a second look, that's not necessary:

                err = edac_device_create_block(edac_dev, instance,
                                                &instance->blocks[i]);
                if (err) {
                        /* If any fail, remove all previous ones */
                        for (j = 0; j < i; j++)
                                edac_device_delete_block(edac_dev,
                                                        &instance->blocks[j]);
				^^^^^^^^^^^^^^

that cleans up the kobjects.

> @@ -640,7 +640,7 @@ static int edac_device_create_instance(struct edac_device_ctl_info *edac_dev,
>  		edac_dbg(2, "Failed to register instance '%s'\n",
>  			 instance->name);
>  		kobject_put(main_kobj);
> -		goto err_out;
> +		goto err_release_instance_kobj;
>  	}
>  
>  	edac_dbg(4, "now register '%d' blocks for instance %d\n",

Ditto.

But keep lookin' :-)

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette