Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 10:51:22 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Zhou jie <zhoujie@nfschina.com>
Cc:     johan@kernel.org, kernel@nfschina.com,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb/serial:Repair function return value
Message-ID: <YvTDCpjrqxxK46Us@kroah.com>
References: <YvS8AK9apa7tnYOz@kroah.com>
 <20220811084237.6651-1-zhoujie@nfschina.com>
 <20220811084237.6651-2-zhoujie@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220811084237.6651-2-zhoujie@nfschina.com>
Precedence: bulk

On Thu, Aug 11, 2022 at 04:42:37PM +0800, Zhou jie wrote:
> Repair function return value,The previous return value did not work.
> 
> v2:
>   Modifying function return value type does not work.

Please put this below the --- line as the documentation asks for.

> 
> Signed-off-by: Zhou jie <zhoujie@nfschina.com>
> ---
>  drivers/usb/serial/mos7720.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 1e12b5f30dcc..215b1c87fa07 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -243,9 +243,8 @@ static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
>  				      enum mos7715_pp_modes mode)
>  {
>  	mos_parport->shadowECR = mode;
> -	write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
> +	return write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
>  		      mos_parport->shadowECR);
> -	return 0;

Are you sure that this change does what you think it does?

Hint, what does write_mos_reg() return if all goes well?

Also the indentation of the second line is now incorrect.

This is going to take more work to get correct, please take your time
and think about it and test your changes before resending.

thanks,

greg k-h