Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dc7a4f78-4244-7425-a1c2-509172ec97de@linaro.org>
Date:   Thu, 11 Aug 2022 11:53:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v3 4/4] clk: mediatek: add driver for MT8365 SoC
Content-Language: en-US
To:     Markus Schneider-Pargmann <msp@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Fabien Parent <parent.f@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Fabien Parent <fparent@baylibre.com>
References: <20220811084433.2598575-1-msp@baylibre.com>
 <20220811084433.2598575-5-msp@baylibre.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220811084433.2598575-5-msp@baylibre.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/08/2022 11:44, Markus Schneider-Pargmann wrote:
> From: Fabien Parent <fparent@baylibre.com>
> 
> Add clock drivers for MT8365 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
> 
> Notes:
>     Changes in v3:
>     - Changed all Kconfig options to be tristate
>     - Do not depend on ARM64
>     - Fix order of frees on probe errors.
>     - Use mtk_clk_register_gates_with_dev
>     - Fixed null clocks
>     - Removed clk26m_ck
>     - Use MUX_GATE_CLR_SET_UPD instead of custom MT8365_MUX_CLR_SET_UPD
>     - Use devm_clk_hw_register_mux for top_misc_muxes
>     - Use devm_clk_hw_register_gate for peri_clks and top_clks
>     - Fix checkpatch warnings
>     - Add missing MODULE_LICENSEs in all files
> 
>  drivers/clk/mediatek/Kconfig                  |   50 +
>  drivers/clk/mediatek/Makefile                 |    7 +
>  drivers/clk/mediatek/clk-mt8365-apu.c         |   55 +
>  drivers/clk/mediatek/clk-mt8365-cam.c         |   57 +
>  drivers/clk/mediatek/clk-mt8365-mfg.c         |   63 +
>  drivers/clk/mediatek/clk-mt8365-mm.c          |  112 ++
>  drivers/clk/mediatek/clk-mt8365-vdec.c        |   63 +
>  drivers/clk/mediatek/clk-mt8365-venc.c        |   52 +
>  drivers/clk/mediatek/clk-mt8365.c             | 1155 +++++++++++++++++
>  .../dt-bindings/clock/mediatek,mt8365-clk.h   |  179 ++-

No, bindings are always separate.


Best regards,
Krzysztof