Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp337326rwb; Thu, 11 Aug 2022 02:22:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR7czRsUs4L/NN9PmflozswmRg1O2plinac2RKFD9/J8c0S1ay6BYTD+5hLq/nbPW5BR0G7P X-Received: by 2002:a17:907:75c1:b0:72f:248d:5259 with SMTP id jl1-20020a17090775c100b0072f248d5259mr23680466ejc.227.1660209765131; Thu, 11 Aug 2022 02:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660209765; cv=none; d=google.com; s=arc-20160816; b=MGU+3XDAe3rrSQFTW6QkT5AA8vIrR0sq8+CJIY8pbyE8vrE8TB0d99aa/A0Ugv2jTI i+rYGlSLT4Nw0mmarrtfxJPZbl79qrr704FBKC5OTqCmgGB3RwOsf+3BlG2oLstcBPCC jqMNp+bwgVfWhUAdpgvN9wLFKGj7ohMSpiis8D8djPz9yOZ74agGTDXFZsYmnsD4R5Xs 4BcE0qEJeiOdYkItvjwvdXUC1V1BoLDxxHExeFIslLQQ9oBxSZdG3Viqqw3BrZrVmguF aaqw2KxRd4yf1BTllB7WVDhFMAlroZeUjWEJlLopIr6bkyMsGBmkjf3bMjSSBP46Qlbr 6fbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bDVr+CdGvYeGHh4rDLzZy3vXpgQfD9Mf1Vd4sMuRulI=; b=RpIrca+kyjZVUJpH8vIdzjAOFRL9JmLd1rtHBRem3qaaRT144JKE2BRdTLPUobsGrs PT1U+1awA1cIQKYywKruSKy6vpGBuM9VXEJAi5as1+ch66IKvMSdZo374tJSe4i0+dKK RoaDVvTBeOFYSR4+SYXXJK95KLZ5Nu9iCj/HppdRGm87tur+0IxmkuMCDkX+aHj9vm2W BM7ewpwY7Jir5CYY7gfc59maOOCAGlFaM0j/cpY434Fn92zx1Vm4av3LlHOqZHGQnXQ3 Td+8ZNkDS25bg8Z9eLZLwHxk3/IPIAUBC2hbW99leFen3pmNo6PM29yBEkc4meEclsKj 7pdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh19-20020a1709076e9300b0072f259df55bsi4282887ejc.189.2022.08.11.02.22.19; Thu, 11 Aug 2022 02:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234950AbiHKJRb (ORCPT + 99 others); Thu, 11 Aug 2022 05:17:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234843AbiHKJR3 (ORCPT ); Thu, 11 Aug 2022 05:17:29 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5E83A3DBCD; Thu, 11 Aug 2022 02:17:27 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7779113E; Thu, 11 Aug 2022 02:17:27 -0700 (PDT) Received: from entos-ampere-02.shanghai.arm.com (unknown [10.169.212.215]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6F3D73F70D; Thu, 11 Aug 2022 02:17:21 -0700 (PDT) From: Jia He To: Ard Biesheuvel , Len Brown , James Morse , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Robert Richter , Robert Moore Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org, "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , linux-efi@vger.kernel.org, nd@arm.com, toshi.kani@hpe.com, Jia He Subject: [PATCH 0/2] Modularize ghes_edac driver Date: Thu, 11 Aug 2022 09:17:11 +0000 Message-Id: <20220811091713.10427-1-justin.he@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in apci_init()") introduced a bug that ghes_edac_register() would be invoked before edac_init(). Because at that time, the bus "edac" hasn't been even registered, this created sysfs /devices/mc0 instead of /sys/devices/system/edac/mc/mc0 on an Ampere eMag server. The solution is modularizing the ghes_edac driver. I tested the cases as follows: 1. build test with ghes_edac built-in and module on Aarch64 2. build test with ghes_edac built-in and module on x86_64 3. boot test with ghes_edac built-in and module on Aarch64 4. modprobe and -r for multiple times on Aarch64. Jia He (2): efi/cper: export several helpers for ghes edac to use EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes drivers/acpi/apei/ghes.c | 49 ++++++++++++++++++++++-- drivers/edac/Kconfig | 4 +- drivers/edac/ghes_edac.c | 74 ++++++++++++++++++++++++++----------- drivers/firmware/efi/cper.c | 3 ++ include/acpi/ghes.h | 33 ++++------------- 5 files changed, 110 insertions(+), 53 deletions(-) -- 2.25.1