Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp356943rwb; Thu, 11 Aug 2022 02:51:43 -0700 (PDT) X-Google-Smtp-Source: AA6agR6014dAa5qhi/uUe2CCjXBzSe6voFbRdygOZTaDFss13r9yd9/xP9oQA5Ma0Kw4lVaj57W8 X-Received: by 2002:a05:6a00:1a49:b0:528:6ea0:14e2 with SMTP id h9-20020a056a001a4900b005286ea014e2mr30427654pfv.22.1660211502933; Thu, 11 Aug 2022 02:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660211502; cv=none; d=google.com; s=arc-20160816; b=BrFSueXchdKN5hnRVH8IN8F95bNm00NWKruisuZ/Dh1ZNVi5AHgq94JlB5NEuXx9jX tLu1EhwAWFxkII8y4x3aqLWgUJRK7Oqax06suOLpR45nV/Ds4XvwJxBT4G/s8vyJfZmB nvFr1NCWoRUKOeSmlygq3SvuKXSGwhuSCR7MKnm4MBd+tBGNlORkHmWRUCm3LmWIpzbf 2FWoZPd0zqEQ2Q4Oc1sUgWOWFQLdzk3jN7tUNrjObFzGjZ4aOl5gAC1ESvT/dn5bbyqy 339OLYzkhsAxCL2+VUOr4pCDUEmuNwJF3VGQ2iWb5EKj3LL0nOV4VjcXleBWFwSkHgpX r0jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DnfnnaO2LHycUQWzmBR5/kycRpXvItXblJN7fTP5HSE=; b=VhPlqL9lRytc2u+HxSFCS3o614ACyfd8rNAwUHXakUKA5LZlE+UedqH7pGgyEcOgAV LQpRmAcFk8GqulPRiK0PH5oxHcK4SJHbQOSxgOuR/ob2dSKJhXs3eyww9m4JfW171EBY vMsg1kqJoH/RpNL4pj92flaCdjy0Q34CUVehoJ1GnuadQvlYvF1nGidcq/FnaA+PlHVy CaTE7nWsXPUk7yaDWmluFq7WFDCmohJVa21FeVk8pjRRE9uA//KVpxsuxIw9VX2IMhtK L1gG3zcUn5FtHsUmXpkgtuqPSYHF9RR88XLfNu5hob1DAWWnvE2fJv800mnHTptwxDqt Uy5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WwrqAwEh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a17090ad31200b001f538744941si4036065pju.34.2022.08.11.02.51.29; Thu, 11 Aug 2022 02:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WwrqAwEh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234864AbiHKJMK (ORCPT + 99 others); Thu, 11 Aug 2022 05:12:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiHKJMJ (ORCPT ); Thu, 11 Aug 2022 05:12:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E20F11C0F; Thu, 11 Aug 2022 02:12:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B1D4615B8; Thu, 11 Aug 2022 09:12:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B494C433D6; Thu, 11 Aug 2022 09:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660209127; bh=TiiyYRlsZds05edxZzrfUjsJ5IkMPA6XiiaHQ0Nzm1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WwrqAwEhiyd031bVDQWmvRR7xqClsVK828Td0UlMcJUj82bsxKTAWjJrRNgo3lvLE y1Wc7i8kWy2GhEbWt2XhHXYZl2i/4wVm3xQIZYcGMBVW3fDNhdKaKMChVQhj5RtFRz cnLBmQsNdqe6i1RsnsSV7WN+E5mHN83BwV0Misa4= Date: Thu, 11 Aug 2022 11:12:04 +0200 From: Greg KH To: Zhou jie Cc: johan@kernel.org, kernel@nfschina.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2] usb/serial:Repair function return value Message-ID: References: <20220811090501.6999-1-zhoujie@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811090501.6999-1-zhoujie@nfschina.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2022 at 05:05:00PM +0800, Zhou jie wrote: > > The return value processing has been done in the write_mos_reg() function, no additional operations are required here, just return the result directly. > Also the indentation of the second line is now incorrect? What's wrong? > I have no context for this email and do not understand it at all, sorry :(