Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp358924rwb; Thu, 11 Aug 2022 02:55:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR59INCV4Ku+pEoDz/jXv31lebGNqJgFkhyL1krAUZJcTGJzO1bios/8YilDfEpMeRyH49CZ X-Received: by 2002:a17:90a:55:b0:1f7:4513:8cac with SMTP id 21-20020a17090a005500b001f745138cacmr7894640pjb.93.1660211705208; Thu, 11 Aug 2022 02:55:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660211705; cv=none; d=google.com; s=arc-20160816; b=nOqBfaWlUl8r4Grd+r6tumssf7J6k8uoX21Rj6DIFDf3BVRsUD3stQ+RGFR93YSHYx NAWsdADEMa6lHwoZwl/BYtvYwApKwEtL1Xwkhlefqv+4T5lhFo38opmyrkbppktNtSVD 0wHR6G5BZ9n49UbQ+Tnn4DC2/ScP+Hz62mD7CcrddBJ8HVU3cZ/UNzwf98RYUmpp+u4E pcbZpzF3srvRKhCNoVczIjps5a6RspgFWPEvRXo0sOPsNAdZTwa+Yw81v+rMqx1gNOHm Z0OReFb2YsctV9KIs7Z/9tXB/+se78h06+FQphw5zEm0Nyi7Xy0h2pNC08WSfZ95kBJM ZGAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=QvU3Ii0mNqZHfLnF6Zfdgva2T6Ppk7BMjH3eteu8YK0=; b=pDgwfK8tstcgNZSjrjlz5TsXBicQ66wYuRaa2ZbHY8FsoESm78iFOV97s71s1aF+gN prFRQFsWn4iAmwXYQ+Y/RAuvQ8qQmK8ErKsOJrUHJ8iBoJ23rHkNBQzrqovZhCkhzqTW N/ZjQ9FoCO43+UvPa6GrHP6Y1fpJE5zFwEQWfvGUEakr2ZjVg6goYXWL43XeieBAu9dd sNZZFtRAbv9s3kFhHHDhYNPuZY22aTdsOTDcrFQ4aADo8d174tneiuXftq4iYt8TaQL3 L6XPJVlJdWITx+wiYj2GsNo/ZvHyDrKL/sByVw0kaO+KHzVh/Yv/jVO1CSfV9IKcNUSz 0Fkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=kEbdDLRB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a170902c94500b0016f975be2f2si16723559pla.545.2022.08.11.02.54.50; Thu, 11 Aug 2022 02:55:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=kEbdDLRB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234908AbiHKJlo (ORCPT + 99 others); Thu, 11 Aug 2022 05:41:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbiHKJlm (ORCPT ); Thu, 11 Aug 2022 05:41:42 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D82A62D1FC for ; Thu, 11 Aug 2022 02:41:40 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4M3MJf6BgNz4x1K; Thu, 11 Aug 2022 19:41:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1660210899; bh=QvU3Ii0mNqZHfLnF6Zfdgva2T6Ppk7BMjH3eteu8YK0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kEbdDLRB31+agt8BJ/TeC6VhWX4NEHL3dNzlAAHEaVglBt/IPlWyXaQbYxPzDNupK VN/OxNUYdRcFRQDTumj6IpYsWApJkiEfNpC+xnmIW800GnzemkKLeC69T1tQDdt8VF N7ZCOmwhsPZ/rEPktpKlVXB8XRLL1+e3e8xvPPtbPYv8B1cuKUJqti67ADjcR04r7/ Y1outOTSoXOrmVjpBPII2/A3K4LG5K8L611udCZY904nczWqIKDMpdnIh2o61ChM2Z faTpKkkrkJqfZLzfaY+uD9NVhnVPIC956S7DAIQ5p6oSzyY80OGjQKaLQxpqU42AnZ LMao+0e4mYQHQ== From: Michael Ellerman To: Anders Roxell , nathan@kernel.org, ndesaulniers@google.com Cc: llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Anders Roxell , Arnd Bergmann , Christophe Leroy Subject: Re: [PATCHv3, resend] powerpc: mm: radix_tlb: rearrange the if-else block In-Reply-To: <20220810114318.3220630-1-anders.roxell@linaro.org> References: <20220810114318.3220630-1-anders.roxell@linaro.org> Date: Thu, 11 Aug 2022 19:41:35 +1000 Message-ID: <87fsi3ce28.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anders Roxell writes: > Clang warns: > > arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is uninitialized when used here [-Werror,-Wuninitialized] > __tlbiel_va_range(hstart, hend, pid, > ^~~~~~ > arch/powerpc/mm/book3s64/radix_tlb.c:1175:23: note: initialize the variable 'hstart' to silence this warning > unsigned long hstart, hend; > ^ > = 0 > arch/powerpc/mm/book3s64/radix_tlb.c:1191:31: error: variable 'hend' is uninitialized when used here [-Werror,-Wuninitialized] > __tlbiel_va_range(hstart, hend, pid, > ^~~~ > arch/powerpc/mm/book3s64/radix_tlb.c:1175:29: note: initialize the variable 'hend' to silence this warning > unsigned long hstart, hend; > ^ > = 0 > 2 errors generated. Which version & config are you building? I don't see this warning in my test builds. cheers