Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 13:15:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Eugenio =?iso-8859-1?Q?P=E9rez?= <eperezma@redhat.com>,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jason Wang <jasowang@redhat.com>,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        dinang@xilinx.com, martinpo@xilinx.com,
        Wu Zongyong <wuzongyong@linux.alibaba.com>,
        Piotr.Uminski@intel.com, gautam.dawar@amd.com,
        ecree.xilinx@gmail.com, martinh@xilinx.com,
        Stefano Garzarella <sgarzare@redhat.com>, pabloc@xilinx.com,
        habetsm.xilinx@gmail.com, lvivier@redhat.com,
        Zhu Lingshan <lingshan.zhu@intel.com>, tanuj.kamde@amd.com,
        Longpeng <longpeng2@huawei.com>, lulu@redhat.com,
        hanand@xilinx.com, Parav Pandit <parav@nvidia.com>,
        Si-Wei Liu <si-wei.liu@oracle.com>,
        Eli Cohen <elic@nvidia.com>,
        Xie Yongji <xieyongji@bytedance.com>,
        Zhang Min <zhang.min9@zte.com.cn>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v7 1/4] vdpa: Add suspend operation
Message-ID: <20220811101507.GU3460@kadam>
References: <20220810171512.2343333-1-eperezma@redhat.com>
 <20220810171512.2343333-2-eperezma@redhat.com>
 <20220811042717-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220811042717-mutt-send-email-mst@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?w0n1aQFcmVIMxyFKvTfCzxIJ31QWmfFKsi+mDFmin2cAq/TlUWAfgL4Zao?=
 =?iso-8859-1?Q?+u5XGlHt1lpzoXEYf9ffh7G+mPZhtvtMBIpJkOpbBhNrxpx10cY9Aoj0C4?=
 =?iso-8859-1?Q?56WUa1RhssSBdhjHSYU9m3IUAEi3GwpyRgAXoCRD4K2W29u+VkH/2idkv1?=
 =?iso-8859-1?Q?ojTlsltMqo5yJYQ7QBTXGRK5IxHoh+VHQQRZrYj6XPg5PJiydQdu7wS2cb?=
 =?iso-8859-1?Q?ZrREi9xZ4Fp0U6ZD347c7oo+WfW35DLXK/UT29FCVLuXsShb7Z0WAvPTSZ?=
 =?iso-8859-1?Q?ra1v8F0N2POa/QHcdf09Xdj97AFq+3DSSUzFbP8OnquqzvJMzAzLDgHMUK?=
 =?iso-8859-1?Q?Km4vPXvTz8PWUY2A1j0co8svpla4BG33/FvE2ik/wiZZctMi/SgZsRI5eW?=
 =?iso-8859-1?Q?US6JZdFxyMzN9N3ESj9xqQU31xlE4ohst6iCdu2x7VEVkS7KNnVoWtGplR?=
 =?iso-8859-1?Q?62zvt608he4nK0jAy+15S56KQqn05QKAipf78IXh33NcgWz6p3SY5n96AW?=
 =?iso-8859-1?Q?w8pZsCA42Mbg3h971YZM+hOPh4YVBz756bCaD575vB0u0PUhhHgfE0M41z?=
 =?iso-8859-1?Q?bkiwcKgUO43xLIEcC61JnslaXQxMOLLkAfRAwFtmSqcoWqlWYAv5fZX1Hw?=
 =?iso-8859-1?Q?/arE8ejW8cR9yS/RDLAYe3ECdG/s9sGsZxYi/+EEk44qWnYyvKZI02BQwM?=
 =?iso-8859-1?Q?3PpXtU1jwcTh/Imkdw4COh/0RusrU4Fy3bSa6VE/zqImnCfWlnv7e61xCf?=
 =?iso-8859-1?Q?WuM/H0AltbPWvjytTwsy0B3+S+VFINLcpSAi98FA1Ht0TN8o3u+9lVrPot?=
 =?iso-8859-1?Q?OvObkrwVuriYWzJSrV8YRUZUg7GXL65YoH7wjFUYnA143N/C9tYD58i37W?=
 =?iso-8859-1?Q?VHo1fZtjFUsr0JeqY/IoPy3k1mN1jtFxtOEi3zhOa6XoRY9a/2EIV1PvCO?=
 =?iso-8859-1?Q?sl0JqOMTpfWorSVpxbIt9EisA1m9VHDiRzITAsQ20O0gRo0iqsJ8VdzfrI?=
 =?iso-8859-1?Q?SnnYnlcjvdewt5rmpijJQamgMsyJEH8TVObxzGUcSbyKGt8ekb4yDpyFcF?=
 =?iso-8859-1?Q?7sHbDsQwMYSc6/Ftx+swHiB8OwnecfbxROfltR/wJFkJd8ylAU4eRq9Rrh?=
 =?iso-8859-1?Q?vX3A9BpyzIsLpLsX8VFSQWNBFREuzpwuCmvmP1E7l0RsJBfi0mbRU856/N?=
 =?iso-8859-1?Q?GufYg1BFxBN0gZcPBdO3Uq0KpZXKyEqFkvi8AKPJuFiIpzy7XeLeTPrL3V?=
 =?iso-8859-1?Q?uYXRIRyC/3aIUQsWrYhq9Q6gdilZOWV94CRULKhL2lLYGwI4YsNbY2jBm8?=
 =?iso-8859-1?Q?cGEUwQo0vWaLvfoVIuWRmJZQUh5PWqeqQSLjDeAjpWd6Xg74ug0dfDTIlL?=
 =?iso-8859-1?Q?9kYNDLL2cqDhxmY28SK4oX7L1rVbnj9XGb1x345vWohcN5986hTqzTxFPt?=
 =?iso-8859-1?Q?nJneKQp7IcP98NGDQfsdmYbS8EdTf3AsYsKekFxD4o1IFXdhCGomP5NccY?=
 =?iso-8859-1?Q?SNHjZaT1BauaROiVc/XglJEWN9kb+X5JQOs0NUb8cV8Cx/6oilAqLgBlRM?=
 =?iso-8859-1?Q?kmRqF5/nXZvNp2J0koFVt6fSiyW1mAdBO6rsILEFDhi8LPC/bdvlsj/UrL?=
 =?iso-8859-1?Q?lhFzhsdvV5d88h2E9WVYP/fIcnCpqRirIa3HSI6HEAl/APDk7AtBY4ag?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1df1db-4d01-4b7d-0a46-08da7b82683f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 10:15:25.7054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: js4AmwZGWcF1dgDJVIrMh2/+LFuijbSwGp3Sb4eueGPd6L7FkhmxIiba0nQP4DOOP671Y+5M74aYed90oLcrw09/TMWch+KXNnwz04jW1TY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5721
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-11_05,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208110029
X-Proofpoint-ORIG-GUID: ke2nGLweUi8c1CK1sobUhNj2eJ-T6F5N
X-Proofpoint-GUID: ke2nGLweUi8c1CK1sobUhNj2eJ-T6F5N
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio P?rez wrote:
> > This operation is optional: It it's not implemented, backend feature bit
> > will not be exposed.
> > 
> > Signed-off-by: Eugenio P?rez <eperezma@redhat.com>
> > Message-Id: <20220623160738.632852-2-eperezma@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> What is this message id doing here?
> 

I like the Message-Id tag.  It means you can `b4 mbox <mesg-id>` and get
the thread.

Linus has complained (rough remembering) that everyone is using the
Link: tag for links to the patch itself.  It's supposed to be for Links
to bugzilla or to the spec or whatever.  Extra information, too much to
put in the commit message.  Now the Link tag is useless because it either
points to the patch or to a bugzilla.  Depend on what you want it to do,
it *always* points to the opposite thing.

But I can't remember what people settled on as the alternative to use
to link to lore...

In theory, we should be able to figure out the link to lore automatically
and there have been a couple projects which tried to do this but they
can't make it work 100%.  Maintainers massage and reformat the patches
too much before applying them.

regards,
dan carpenter