Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 13:33:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org,
        Xianting Tian <xianting.tian@linux.alibaba.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@rivosinc.com>,
        Guo Ren <guoren@kernel.org>
Subject: arch/riscv/kernel/traps.c:48 die() warn: variable dereferenced
 before check 'regs' (see line 46)
Message-ID: <202208110538.uaLOQmBs-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EC54uTtup8OgpfC2Dkf/F6YXldLQWa5AcObAjMhXk2u5jdhQ+szQh5cyyDJV?=
 =?us-ascii?Q?WEImSvDOECSSRPsFr/OhTrL6DQAtFqSwsiNDlfDJ+gS8tq7gy6Gfl/cceepA?=
 =?us-ascii?Q?efYysGTOC2OldOmyyk5aW8KH6QESuPHKPCPqyIEDex+8ZbtPn3QvtP1CIcSu?=
 =?us-ascii?Q?m9OOf6U8k41e7ZFMOBHSoKuORsyaoOPNIV5rKAMfnv7AGfW5DW0npkqwdFdA?=
 =?us-ascii?Q?nsv7P/0wu1QciwiKkzO9Y3uX9DCMBAIpnLK3PLP8QSkrnWe9sgbAZJQwNX+B?=
 =?us-ascii?Q?29W1XaOBi+IGW8mr4OkBWZbiSsjzGqBP+chfcQ571AmVT4v3ydQFfX/5CNmF?=
 =?us-ascii?Q?CXe9l3r3z8ufBbHrrxAdNt6uatuDlK3ChqBAtTnUx16aCnVeIisGHviZLq1i?=
 =?us-ascii?Q?2J+fNt4I9Wx8Y0MT8bvKzQjq+LgQNHDz5eN81UzIosuDOLgMADvo7xymSYvr?=
 =?us-ascii?Q?+t0TVv7V95rFU5j2dVSo7ogvgCfwM/wUVfGlsO9n96mpX5tNpgSAAXu1U+40?=
 =?us-ascii?Q?2v45qsHvRprokEwkNqdLF7VKydfAYh4nDCGBw2EzAtqEBEqrWq20K/s+niYl?=
 =?us-ascii?Q?pr84TITBbYBC/sNzpAcwpvWrvN+dKYVGnI04mtwtO6R5Cn94xox29RKuCmFk?=
 =?us-ascii?Q?onxh6sa8mZVdJXLlvFYA2JvXHRjq8cLTsT/bh7R9ZL/MvUlea8x0HpGv1ybr?=
 =?us-ascii?Q?g8Wo6aVTpT9/y76CGDSmKdhgcDoCsEtxsV9OTbX5QfehWPIuJRpf+loi/EuJ?=
 =?us-ascii?Q?GrPTmeBVz2491HJWa3EgXayX9YrMnfXm0dWbKnwNQa2Mi66Q5jWjMBXN15oW?=
 =?us-ascii?Q?tLofNPpARbJS7foFWLyV4eoOCwLx50l8C1HvP+YjKOZ59DaGjxRhHa9tUv/d?=
 =?us-ascii?Q?zSuXcUargh7fBx1lJ+K6aBiDjzq8Sp/e6+lRjNbNw5iIoNMH3YOBVFeVOeen?=
 =?us-ascii?Q?PHpfXJj5bV2+KxLUI3yvTlc+ZnbVy6OuaXTGv9UuNNUaiE7hteLlGe0++nDW?=
 =?us-ascii?Q?kLilMF0otf6lWI/f4h2GaT+eAogUdNWP3pSVWr4EibfspTKddyDCpaqX1VRU?=
 =?us-ascii?Q?Yg1r6cfDmFhvy/kufmVRexmRqxY7wEjHisLwQvbSV8VT2wRwQtnVUU9PtO3p?=
 =?us-ascii?Q?7yEalJU8dv5aVzBbsb2/71sLnlAKNmkEnMwdC+DZkhf8m4SZO6467mQW/214?=
 =?us-ascii?Q?RazVddBCen18zxeD/gPnHciCmpwADdj2A7u7KINeT5Tygt5BAtUENcFO9D4/?=
 =?us-ascii?Q?hXYiiflLXKxyJy1VdRlpfrxrZn9wXht6mq/VECY2PAEXQBuCicx305hMs8Mh?=
 =?us-ascii?Q?NRxwv1gqqecDLleI7zAzkkIuvrOdZifBhNzYuKCXzfapCZl/ERmHnK1reD78?=
 =?us-ascii?Q?iIorUxL+vOVrJfLGHuUuZh00NKE6wtnaEhM9XJqpDCCw7q/yv9doyzSc112L?=
 =?us-ascii?Q?EZ2b9T3na+1csCF4GeHOyc2FkZP+C4CZhfpRTL9KFi1ifdp5rLyzb8gmV1qK?=
 =?us-ascii?Q?R4uaDwGhwnvI7Sr/QmQrBHFkEjpRD7KrHlwEqUZBxxFFzt6CaoZ5YLKIkAf0?=
 =?us-ascii?Q?ro8b3YcSUS8MN11E3rcLN4v7iGB+ZRstLkf9HAlfMSfWTFA2/uqMmzYB7ky9?=
 =?us-ascii?Q?kw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1839f38-540b-4012-5c7c-08da7b8504e9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 10:34:07.4146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oIfRVF+o576z+EU5Uxpl6WoDPHZQ7I38yiS7taRve+MQDEeMOugFOKE5E6/TM6eUt7vrsFvDF8OTNJo8LCx1AHcYp9xAKGGQzM5lLrHdHFc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2933
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-11_05,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208110030
X-Proofpoint-ORIG-GUID: yq67-M20uUEGArBOiHRvIdn281TNh8FI
X-Proofpoint-GUID: yq67-M20uUEGArBOiHRvIdn281TNh8FI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f41445645ab5d172e6090d00c332c335d8dba337
commit: 3f1901110a89b0e2e13adb2ac8d1a7102879ea98 RISC-V: Add fast call path of crash_kexec()
config: riscv-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220811/202208110538.uaLOQmBs-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/riscv/kernel/traps.c:48 die() warn: variable dereferenced before check 'regs' (see line 46)

vim +/regs +48 arch/riscv/kernel/traps.c

76d2a0493a17d4 Palmer Dabbelt    2017-07-10  31  void die(struct pt_regs *regs, const char *str)
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  32  {
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  33  	static int die_counter;
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  34  	int ret;
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  35  
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  36  	oops_enter();
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  37  
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  38  	spin_lock_irq(&die_lock);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  39  	console_verbose();
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  40  	bust_spinlocks(1);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  41  
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  42  	pr_emerg("%s [#%d]\n", str, ++die_counter);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  43  	print_modules();
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  44  	show_regs(regs);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  45  
a4c3733d32a72f Christoph Hellwig 2019-10-28 @46  	ret = notify_die(DIE_OOPS, str, regs, 0, regs->cause, SIGSEGV);
                                                                                                 ^^^^^^^^^^^
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  47  
3f1901110a89b0 Xianting Tian     2022-06-06 @48  	if (regs && kexec_should_crash(current))
                                                            ^^^^

Delete this NULL check.

3f1901110a89b0 Xianting Tian     2022-06-06  49  		crash_kexec(regs);
3f1901110a89b0 Xianting Tian     2022-06-06  50  
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  51  	bust_spinlocks(0);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  52  	add_taint(TAINT_DIE, LOCKDEP_NOW_UNRELIABLE);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  53  	spin_unlock_irq(&die_lock);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  54  	oops_exit();
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  55  
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  56  	if (in_interrupt())
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  57  		panic("Fatal exception in interrupt");
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  58  	if (panic_on_oops)
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  59  		panic("Fatal exception");
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  60  	if (ret != NOTIFY_STOP)
0e25498f8cd43c Eric W. Biederman 2021-06-28  61  		make_task_dead(SIGSEGV);
76d2a0493a17d4 Palmer Dabbelt    2017-07-10  62  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp