Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa583bc3-bb43-2788-3c83-479859c40b75@collabora.com>
Date:   Thu, 11 Aug 2022 16:21:05 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] iio: light: Add raw attribute
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>, jic23@kernel.org,
        lars@metafoo.de
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        krisman@collabora.com, kernel@collabora.com,
        alvaro.soliverez@collabora.com
References: <20220811101443.499761-1-shreeya.patel@collabora.com>
 <e8b99943-d930-2d92-67ba-62ae17f7cd56@collabora.com>
From:   Shreeya Patel <shreeya.patel@collabora.com>
In-Reply-To: <e8b99943-d930-2d92-67ba-62ae17f7cd56@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/08/22 16:13, Dmitry Osipenko wrote:
> On 8/11/22 13:14, Shreeya Patel wrote:
>> +	case IIO_CHAN_INFO_RAW:
>> +		ret = ltrf216a_set_power_state(data, true);
>> +		if (ret)
>> +			return ret;
>> +		mutex_lock(&data->lock);
>> +		ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
>> +		mutex_unlock(&data->lock);
> ltrf216a_set_power_state(data, false) should be called before return.

ah! yes, missed that. Thanks for pointing out. I'll send a v2.


Thanks,
Shreeya Patel

>> +		if (ret < 0)
>> +			return ret;
>> +		*val = ret;
>> +		ltrf216a_set_power_state(data, false);
>