Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <647583a6-6e1f-b3d9-cc1d-2ca4564cceed@quicinc.com>
Date:   Thu, 11 Aug 2022 16:45:31 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset'
 inteface
Content-Language: en-US
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     freedreno <freedreno@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>,
        Rob Clark <robdclark@gmail.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1659172664-10345-1-git-send-email-quic_akhilpo@quicinc.com>
 <YvLMJ2yQRhBFp2y9@baldur>
From:   Akhil P Oommen <quic_akhilpo@quicinc.com>
In-Reply-To: <YvLMJ2yQRhBFp2y9@baldur>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/10/2022 2:35 AM, Bjorn Andersson wrote:
> On Sat 30 Jul 04:17 CDT 2022, Akhil P Oommen wrote:
>
>> Some clients like adreno gpu driver would like to ensure that its gdsc
>> is collapsed at hardware during a gpu reset sequence. This is because it
>> has a votable gdsc which could be ON due to a vote from another subsystem
>> like tz, hyp etc or due to an internal hardware signal. To allow
>> this, gpucc driver can expose an interface to the client driver using
>> reset framework. Using this the client driver can trigger a polling within
>> the gdsc driver.
>>
>> This series is rebased on top of linus's master branch.
>>
>> Related discussion: https://patchwork.freedesktop.org/patch/493144/
>>
> Forgive me if I'm assuming too much, but isn't this an extension of:
>
> 85a3d920d30a ("clk: qcom: Add a dummy enable function for GX gdsc")
>
> With the additional requirement that disable should really ensure that
> the GDSC is turned off?
Also, gpu driver needs a way to ensure cx gdsc was collapsed at least 
once before it goes ahead with re-init.

Btw, the patch you mentioned is about gx gdsc in gpucc which is supposed 
to be owned by gmu (except when it is in bad shape). But the current 
series is about cx gdsc which is shared with other subsystems/drivers.

-Akhil.
>
> Regards,
> Bjorn
>
>> Akhil P Oommen (5):
>>    dt-bindings: clk: qcom: Support gpu cx gdsc reset
>>    clk: qcom: Allow custom reset ops
>>    clk: qcom: gpucc-sc7280: Add cx collapse reset support
>>    clk: qcom: gdsc: Add a reset op to poll gdsc collapse
>>    arm64: dts: qcom: sc7280: Add Reset support for gpu
>>
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi          |  3 +++
>>   drivers/clk/qcom/gdsc.c                       | 23 +++++++++++++++++++----
>>   drivers/clk/qcom/gdsc.h                       |  7 +++++++
>>   drivers/clk/qcom/gpucc-sc7280.c               |  6 ++++++
>>   drivers/clk/qcom/reset.c                      |  6 ++++++
>>   drivers/clk/qcom/reset.h                      |  2 ++
>>   include/dt-bindings/clock/qcom,gpucc-sc7280.h |  3 +++
>>   7 files changed, 46 insertions(+), 4 deletions(-)
>>
>> -- 
>> 2.7.4
>>