Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 12:42:59 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/shmem: shmem_replace_page() remember NR_SHMEM
Message-ID: <YvTrQ1NRfnOEHGWD@casper.infradead.org>
References: <cec7c09d-5874-e160-ada6-6e10ee48784@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cec7c09d-5874-e160-ada6-6e10ee48784@google.com>
Precedence: bulk

On Wed, Aug 10, 2022 at 10:06:33PM -0700, Hugh Dickins wrote:
> Elsewhere, NR_SHMEM is updated at the same time as shmem NR_FILE_PAGES;
> but shmem_replace_page() was forgetting to do that - so NR_SHMEM stats
> could grow too big or too small, in those unusual cases when it's used.
> 
> Signed-off-by: Hugh Dickins <hughd@google.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

> ---
> This is not terribly important, and will clash with one of Matthew's
> 59 for 5.21; I don't mind if this gets delayed, and we just do it again
> on top of his series later, or he fold the equivalent into his series;
> but thought I'd better send it in as another fix to shmem_replace_page()
> while that function is on our minds.

Let's get this into 6.0 since it's a bugfix, and I'll rebase my patches
for 6.1 on top of it.