Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp548211rwb; Thu, 11 Aug 2022 06:15:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR45aL/rAfyxenr9nE+VuzT3oS4lrMeWhgo2ZPCCuuz2s1Ge+6XAevq4FrtkztEG+D6db9nc X-Received: by 2002:a05:6a00:2392:b0:52e:b4fb:848 with SMTP id f18-20020a056a00239200b0052eb4fb0848mr28897369pfc.8.1660223712563; Thu, 11 Aug 2022 06:15:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660223712; cv=none; d=google.com; s=arc-20160816; b=Q+e6REx5owh9Fqgp7QLUm6w9UVZ9wpK6AeaONV2eisJcd/6dTCZiKnKREgpSKzdHQo C00+iECz7VX5k51x0jCGW1RNCviZCsoKC8b2IEzowGICIG7PuX3KNZj/lU8yfTkCZ0no PjmiX9Yjx12ddQvMyckpGG0qGk/nNTG2JVjxPNVLkDcS58NWNfrqLyYawPxHnEfpjL3I Q7ABB3/rE7pk43RBMspNi0uNZGrg2MDOay5GeeF3iB99uN00C5CxrMYScl1L3GOzd+PB FqEy6hgUl60nCGFj7s7ypZ0QKWowLI9eB3UONM5KY/SS1aUFeP7JxMdIW4BkmiO6dOUa lOHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5w/KsvKeDQNB0nymQYwJO1nJhxYwskiJAdbQrcwrrws=; b=OF5oySafZJFZO/EbLxW3bEcVOgjRJLhGiGzbeaB5hTVC3S82LFxzRlrouTz+ifuCWI Eougjde4eSbcrNtKqnLSSDHf1fQDXDyQwjHc3wJySrQJCaC+FWnujSI3ssQZYBaN/+RG S9/Czy9xoawqPfZnX1za2e26yR5HI6MkKCBYQRjmvfmdHkyScJ9UBlU45hWBuMGhktG+ wqb+p1RTeG12MNe1J4xQ/Z4Od60N7ehWXtTtvj5CTbVeaZGIqHWEiQM3/0vbd+e8nlWQ aX0+bBRWU+ox39I5d2AiloQ+Qv0Qiw/mtk5i7OM0MDM7Y4NJTKRd8lpVZJbX7TNnlwZK MNVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ql5Tzwac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020a170902cf0300b0015ebfbc1a42si2625352plg.533.2022.08.11.06.14.58; Thu, 11 Aug 2022 06:15:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ql5Tzwac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235268AbiHKMf4 (ORCPT + 99 others); Thu, 11 Aug 2022 08:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235270AbiHKMfi (ORCPT ); Thu, 11 Aug 2022 08:35:38 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8659D12D06 for ; Thu, 11 Aug 2022 05:35:19 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id a8so17540658pjg.5 for ; Thu, 11 Aug 2022 05:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=5w/KsvKeDQNB0nymQYwJO1nJhxYwskiJAdbQrcwrrws=; b=Ql5TzwacX39R2Jd3F8nwCUw2umD0dCX30wm+NAMytxnOiFhjI29r2fh4KHIe8FbJA5 sYz4E0PDwIJi2YWeIZGBi2iV+Kzj0DYdKG+N+MawTLJhdefhUsUcV0ClrlBQcf1+CfbC BhOcyvxJBYHt9jAR2olKMbE/rOdvH8kuymWFoAFCIdQ3O3rDei5TMFoybUL9zX6OoiC6 zSf7+O9WlFtOrgZpMoO4efq2+dLIYo4s6604mDZQ2A9zMsGb4t2OqoPcdUh7yyzAL4B5 4m2ConxAm3a5QZ2B5OUxbrnEPhFZedReRM5K3lF3hX3flUt9J1LLpTzaRYKOp4znfWwG qROQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=5w/KsvKeDQNB0nymQYwJO1nJhxYwskiJAdbQrcwrrws=; b=pqEU1eCNdr14/Z0MKBS+KHS/0CmbxOr34xx1IkmduLlGtV89RN1sV6dBfFNQs+/qGY +2gHo+3vQc33pd45gSh5UBPVOU0Gi7X3XOxePIWI6bXoV1uXAxTJ7sW3sfYCzPFqhWIe yIVZCYVbPKyajeq4NYtfFd/+p3xmJmbUtrq/FxgZv9TKs4O9JPXWVaYLTtV5Z+abpibP /DnmI5Nt7+4LEUEqgWPds4YvQg3OAsrVYhpDAhNz4ciGnQsLdDIRYqLNbycraWk+CjEm 4NbY0YwR3N+s0PkNdICg7v685FlE6yopCDPcYvvNhQhEUNGwa05CPLlVtCpC2AM0PJ+A h2SQ== X-Gm-Message-State: ACgBeo16az8CqfpOOFMoQ7DPuSzTiqO3KJKTyg+keqj4xgpUlch3CLt1 fdIIfpKXTjFw0U1H7nyzvRsBZA1SjOfVWNxvJIVOeNb8bO1UaA== X-Received: by 2002:a17:90b:3805:b0:1f4:ebfe:558b with SMTP id mq5-20020a17090b380500b001f4ebfe558bmr8709936pjb.48.1660221318988; Thu, 11 Aug 2022 05:35:18 -0700 (PDT) MIME-Version: 1.0 References: <20220810114318.3220630-1-anders.roxell@linaro.org> <87fsi3ce28.fsf@mpe.ellerman.id.au> In-Reply-To: <87fsi3ce28.fsf@mpe.ellerman.id.au> From: Anders Roxell Date: Thu, 11 Aug 2022 14:35:08 +0200 Message-ID: Subject: Re: [PATCHv3, resend] powerpc: mm: radix_tlb: rearrange the if-else block To: Michael Ellerman Cc: nathan@kernel.org, ndesaulniers@google.com, llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Christophe Leroy Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Aug 2022 at 11:41, Michael Ellerman wrote: > > Anders Roxell writes: > > Clang warns: > > > > arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is uninitialized when used here [-Werror,-Wuninitialized] > > __tlbiel_va_range(hstart, hend, pid, > > ^~~~~~ > > arch/powerpc/mm/book3s64/radix_tlb.c:1175:23: note: initialize the variable 'hstart' to silence this warning > > unsigned long hstart, hend; > > ^ > > = 0 > > arch/powerpc/mm/book3s64/radix_tlb.c:1191:31: error: variable 'hend' is uninitialized when used here [-Werror,-Wuninitialized] > > __tlbiel_va_range(hstart, hend, pid, > > ^~~~ > > arch/powerpc/mm/book3s64/radix_tlb.c:1175:29: note: initialize the variable 'hend' to silence this warning > > unsigned long hstart, hend; > > ^ > > = 0 > > 2 errors generated. > > Which version & config are you building? clang-13, clang-14 and clang-nightly, configs are cell_defconfig and maple_defconfig I'm building with tuxmake [1] like this: $ tuxmake --runtime podman --target-arch powerpc --toolchain clang-14 --kconfig cell_defconfig Cheers, Anders [1] https://tuxmake.org/