Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 15:40:21 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Eugenio =?iso-8859-1?Q?P=E9rez?= <eperezma@redhat.com>,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jason Wang <jasowang@redhat.com>,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        dinang@xilinx.com, martinpo@xilinx.com,
        Wu Zongyong <wuzongyong@linux.alibaba.com>,
        Piotr.Uminski@intel.com, gautam.dawar@amd.com,
        ecree.xilinx@gmail.com, martinh@xilinx.com,
        Stefano Garzarella <sgarzare@redhat.com>, pabloc@xilinx.com,
        habetsm.xilinx@gmail.com, lvivier@redhat.com,
        Zhu Lingshan <lingshan.zhu@intel.com>, tanuj.kamde@amd.com,
        Longpeng <longpeng2@huawei.com>, lulu@redhat.com,
        hanand@xilinx.com, Parav Pandit <parav@nvidia.com>,
        Si-Wei Liu <si-wei.liu@oracle.com>,
        Eli Cohen <elic@nvidia.com>,
        Xie Yongji <xieyongji@bytedance.com>,
        Zhang Min <zhang.min9@zte.com.cn>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v7 1/4] vdpa: Add suspend operation
Message-ID: <20220811124021.GW3460@kadam>
References: <20220810171512.2343333-1-eperezma@redhat.com>
 <20220810171512.2343333-2-eperezma@redhat.com>
 <20220811042717-mutt-send-email-mst@kernel.org>
 <20220811101507.GU3460@kadam>
 <20220811072125-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220811072125-mutt-send-email-mst@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?pyw49/B1gUHwowZNleKxyn67ShCLbCd7MUn3ZNHGU9nErJNEcOLsRXOun0?=
 =?iso-8859-1?Q?JHQrFewZcIz2ZztKO9B2jOmS3ubRMPCOufbT0U2fOPWfn3btEMEa/z2ovc?=
 =?iso-8859-1?Q?kvpOJwpoUNKCGLLPnBJIsmy3mSRhwMPd5nTYIGDLbuMe4lT7C7XhsfetbW?=
 =?iso-8859-1?Q?BY3Nh9ZsUjI44GrfvtjGzGm7+iQIQbpCkPziqcFKQ6Y8NAvYhJcoIdcsCG?=
 =?iso-8859-1?Q?G4czl1dPR2i7nhq7FOr3qwDCTN8bQPwL7vV+YjLhKbyVrdNMPSDGwqihbc?=
 =?iso-8859-1?Q?94jTlExuXxV1JVMIE+xuZwyjZiBPZ5wEKtuHIdeerufkpIqnfrqIPs3peU?=
 =?iso-8859-1?Q?BLXQaxF4JH7WJIEHdd89qs2Lk3/qyxTSsuPQ/j17V/ljLCjwO/H2qAbLiq?=
 =?iso-8859-1?Q?gwdiPCYwRBoGGBcIIapEccvm5wrGef2qifvdnx5vQ3xknK9ia/egxbNa3A?=
 =?iso-8859-1?Q?cYwytKSABpfkULaBLXY22WIwPh41WpQDv//R5+/W9EQ/WjV5m7Lnh7ICgP?=
 =?iso-8859-1?Q?yHKTg0wenlSyI9lwP5iTZoGldxzPMH6wKQSeL12vOVJ8imWuDXadfAj2Ai?=
 =?iso-8859-1?Q?QZ4bfcK4ihWGev01oOnxvJH7dtukJxkR0nKUfpbtjgE1D90YftyRxcc2bQ?=
 =?iso-8859-1?Q?x3FG4Y84GTN1apk/GsKSqXy3cvZq45lCiV60dbFGVzSli0owrwxehU+UQs?=
 =?iso-8859-1?Q?hwbRBzQHhYLD4oW4XJqbE2FJQ85i18DIMFbeQAxvrrTVG2aolmbuBipYIU?=
 =?iso-8859-1?Q?Xh6UwbBnq4coaqh/xT1mVTfqSQ9AB2yo2MIiKiul2vgtS6OsmvFrxGow//?=
 =?iso-8859-1?Q?fgAPjKdyG5veMKEJ56R2NGHKhMGWteYGxz/zJ3mdxSQ+U3QpKNL6wzQ6q/?=
 =?iso-8859-1?Q?MzF7JAj+ypSwogQxlSfParxd8mtNJeQDrC4pvZbl10LeOYZcn+1+ENbTzR?=
 =?iso-8859-1?Q?McAbpetOCSRODdPONBVCeXPdtt+1TZ6GAcPRXpnwRXFT5BU0wtE7+P0iYN?=
 =?iso-8859-1?Q?yiCDJeN+lvsbOlxtWpkyjaxtt/bfJ4Y0e1v9Qp6xOGjfpKVFxxMIvA62IO?=
 =?iso-8859-1?Q?4ehMLr5iztdq3VMuiZKOREkxuKfmfAGaeC4MCsA9omte9HNSlKwC/KEJZv?=
 =?iso-8859-1?Q?W7KcxF6K3oFx5QXr0iaS67r4AF1V5k9t2X5e0K8OTqR6OZBPAGs5Tck9LX?=
 =?iso-8859-1?Q?Se6T59mx7thQ6xfFYbts4o/IndAT5/UL/EfDtcz/LOi6ytHYVdpdoFYUvG?=
 =?iso-8859-1?Q?dl/jcDNopadsLjOXIb5lCTrqimT+zTcgS4k8mlonBwc2M1YfCwRt6pF3/3?=
 =?iso-8859-1?Q?ZjTofbN1WyVT89eoUGLzfDcQTG3VqfZOgcEbqMM+0JAgJD9LHwifVxWZ2z?=
 =?iso-8859-1?Q?1KVeysFmfiyKS9FQBIfsvKk4OfWujj2baUOBZoXsN9hw24iWV/v2UoJCPS?=
 =?iso-8859-1?Q?4lKOPwplwkJsVSyK5rrPB0XAMFLlYkmBZ6Q+ysTaEVKItRoU3PbMcnHVy1?=
 =?iso-8859-1?Q?9/Guu0Zg1A+1W/e2DkhnTofyBqAo8RTAayR1Mr7uw7h1GqUUXSG6DPpVJL?=
 =?iso-8859-1?Q?yAAPlxBdexFR3e77VwDvK6oOO97b6K85IutKJJLB6/1wNepb+WrlU+iixN?=
 =?iso-8859-1?Q?pUEQ+M7xpHzunkHFb0/BDOnIKiSX/7ilmcJaNoE4GJW8dOtTvcvZKnFg?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc6db887-389d-415c-786b-08da7b96b526
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 12:40:44.2417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6pmQ3IhFmFDOsep7YFVEePgWPULDiVmuMJwQ82WPd5Kp9ZoPONoKzr2PN5K732Nn41c85eM3xjVZcWOpGGDlnbB0FvDd0ZalQizDBLbKtRc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3905
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-11_10,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 mlxscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208110040
X-Proofpoint-ORIG-GUID: fKVQw_IMrloLF-YAuJmS15iIF1WEPk0i
X-Proofpoint-GUID: fKVQw_IMrloLF-YAuJmS15iIF1WEPk0i
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 11, 2022 at 07:23:44AM -0400, Michael S. Tsirkin wrote:
> On Thu, Aug 11, 2022 at 01:15:08PM +0300, Dan Carpenter wrote:
> > On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> > > On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio P?rez wrote:
> > > > This operation is optional: It it's not implemented, backend feature bit
> > > > will not be exposed.
> > > > 
> > > > Signed-off-by: Eugenio P?rez <eperezma@redhat.com>
> > > > Message-Id: <20220623160738.632852-2-eperezma@redhat.com>
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > 
> > > What is this message id doing here?
> > > 
> > 
> > I like the Message-Id tag.  It means you can `b4 mbox <mesg-id>` and get
> > the thread.
> 
> Yes it makes sense in git. But I don't see what it does in this patch
> posted to the list.

Ah.  Okay.  I misunderstood.

> It seems to refer to the previous version of the
> patch here. Which is ok I guess but better called out e.g.
> 
> Previous-version: <20220623160738.632852-2-eperezma@redhat.com>
> 

Let's not go over board with storing previous threads.  That seems like
a headache...

regards,
dan carpenter