Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5512a55d-8852-db6d-6a54-9b8bb3cf2e96@samsung.com>
Date:   Thu, 11 Aug 2022 15:13:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
        Thunderbird/91.11.0
Subject: Re: [PATCH v9 03/13] block: allow blk-zoned devices to have
 non-power-of-2 zone size
Content-Language: en-US
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        <Johannes.Thumshirn@wdc.com>, <snitzer@kernel.org>,
        <axboe@kernel.dk>, <agk@redhat.com>, <hch@lst.de>
CC:     <dm-devel@redhat.com>, <matias.bjorling@wdc.com>,
        <gost.dev@samsung.com>, <linux-kernel@vger.kernel.org>,
        <pankydev8@gmail.com>, <jaegeuk@kernel.org>, <hare@suse.de>,
        <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
        <bvanassche@acm.org>, Luis Chamberlain <mcgrof@kernel.org>
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <d7343e70-cbfa-4163-a78e-963fbf3bb38c@opensource.wdc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
CMS-TYPE: 201P
References: <20220803094801.177490-1-p.raghav@samsung.com>
        <CGME20220803094805eucas1p1c68ba40d319331c2c34059f966ba2d83@eucas1p1.samsung.com>
        <20220803094801.177490-4-p.raghav@samsung.com>
        <d7343e70-cbfa-4163-a78e-963fbf3bb38c@opensource.wdc.com>
Precedence: bulk

>>  static inline bool disk_zone_is_seq(struct gendisk *disk, sector_t sector)
>>  {
>>  	if (!blk_queue_is_zoned(disk->queue))
>> @@ -753,6 +777,12 @@ static inline unsigned int disk_zone_no(struct gendisk *disk, sector_t sector)
>>  {
>>  	return 0;
>>  }
>> +
>> +static inline bool bdev_is_zone_start(struct block_device *bdev, sector_t sec)
>> +{
>> +	return false;
>> +}
> 
> Is this one really necessary ? Any caller of this would also depend on
> CONFIG_BLK_DEV_ZONED and not compiled if not enabled. So there should be no
> callers of this for the !CONFIG_BLK_DEV_ZONED case.
> 
We are using it in dm-table.c in device_area_is_invalid() function. So
it can be called without being compiled with CONFIG_BLK_DEV_ZONED like
bdev_is_zoned() in dm-table.c.
>> +
>>  static inline unsigned int bdev_max_open_zones(struct block_device *bdev)
>>  {
>>  	return 0;
> 
>