Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62f4fbc1.170a0220.a7511.8fa9@mx.google.com>
Date:   Thu, 11 Aug 2022 14:53:20 +0200
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: ipq8064: add v2 dtsi variant
References: <20220718161826.4943-1-ansuelsmth@gmail.com>
 <62efbb68.170a0220.88a00.8207@mx.google.com>
 <3515103e-8663-1df9-a184-a383cc0d6aa9@somainline.org>
 <62f158b0.050a0220.9281c.1da3@mx.google.com>
 <736b8e63-3d81-c34d-f693-7dc2120dd885@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <736b8e63-3d81-c34d-f693-7dc2120dd885@somainline.org>
Precedence: bulk

On Thu, Aug 11, 2022 at 02:48:29PM +0200, Konrad Dybcio wrote:
> 
> 
> On 8.08.2022 15:35, Christian Marangi wrote:
> > On Mon, Aug 08, 2022 at 12:55:36PM +0200, Konrad Dybcio wrote:
> >>
> >>
> >> On 7.08.2022 15:00, Christian Marangi wrote:
> >>> On Mon, Jul 18, 2022 at 06:18:24PM +0200, Christian Marangi wrote:
> >>>> Add ipq8064-v2.0 dtsi variant that differ from original ipq8064 SoC for
> >>>> some additional pcie, sata and usb configuration values, additional
> >>>> reserved memory and serial output.
> >>>>
> >>>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> >>>
> >>> Any news for this?Unless Qualcomm naming was different back then, you should simply merge
> >> all of these changes into ipq8064.dtsi, as v1 is often the pre-production,
> >> internal chip revision and only the last one (or the last and second-last)
> >> are shipped in production devices.
> >>
> > 
> > Mhh, this is not the case, there are dev board based on v1 and we also
> > have some device based on v1 (that have some difference for pci and usb)
> > One example is a Netgear r7500 where we have 2 revision one based on
> > ipq8064-v1.0 and one based on ipq8064-v2.0.
> Very interesting.. but if there really are devices shipping with v1, I guess
> it's the correct thing to keep both.
> 
> Konrad

Yep, that is the case. Main concern here is the fact that we have to
have smb208 dtsi variant for each revision and we can't reuse v2 for
ipq8065 and ipq8062 as they have different opp for the CPU core.
(currently not present but they will be added in the future when we will
finally have a correct krait cache devfreq driver)

-- 
	Ansuel