Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp636034rwb; Thu, 11 Aug 2022 07:32:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR7bxWZn2kDy4RiIsw50DoBR9TQPpXl2Mk4Lf2g9FVbH1pmqCay/saAGLHcJLUROIuM9dr6/ X-Received: by 2002:a05:6402:5289:b0:43b:69a9:38c8 with SMTP id en9-20020a056402528900b0043b69a938c8mr31818872edb.263.1660228320792; Thu, 11 Aug 2022 07:32:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660228320; cv=none; d=google.com; s=arc-20160816; b=Y3nZsOutQ5KGNiZtRKGmU4qYUOr+NxofAUfO3jaJmkv8wYxYr7TpzSkadBvu5zzfVb OZ3E0R9obLqrM3cAJBGBOvlkS96xk3HGEEEYAc9eJfA9/JN/fLh3/qy5DsWZ8PiWyqCW dSW652WhBL59SDsuAjU4a0islBuvHD1J5bRRT9bCDBseAdu6xll6I7wxNN+Hj+8WXS2B DfwWnqrwWO8txQhnAiPkZnbxqtOyDBmtTsaTfXo6Hog9Tw8Gzle9gXhqYS2dj3FagOhW cFpgCQAOtgw6FBnrSBWsBcV0Hv4qV6OriGiaG1cCw6l7WJM6imI7/D9acABwulO7OMRW 5FWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xIw5J8JiW9EWdbkmaTRIkgvuE5eWmxbyOxxWHb1qODM=; b=mILYt1SQHH47OdGg/9l4ybQsZtP5G+6ebW9PMBRsx8GX8Ar+LvaXMjd9saHvwcKqRp 1MpQsBWosI1/9RaVFFHpUy6iMZIuT2oBGWxGCSDXdy20mMLoBRRpGVbn+uUIDpXYoXBC XIS0Whw5Yp0CIZnFUUocjVffCyAEf4HFUyvZrlGKg4zYxRMRjuLOoznH/EKBxhhJ+tB7 jB8I5gj8VT03RPSTjeZ7A930VHo7LP1mrXIWV9vkt7onZ/sZCCGL1XQ+rx9+PMQs9zQf efCW5dS6gY8If/YVav0LvPEPYawz/9iA0bxXKWzYsXOLprY1djrvPiGZMiyi7V05bUh/ iCcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="IQQP/nmN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cz20-20020a0564021cb400b0043bc778b19asi1034096edb.166.2022.08.11.07.31.27; Thu, 11 Aug 2022 07:32:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="IQQP/nmN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234955AbiHKOJX (ORCPT + 99 others); Thu, 11 Aug 2022 10:09:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234627AbiHKOJW (ORCPT ); Thu, 11 Aug 2022 10:09:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0B48E0F8; Thu, 11 Aug 2022 07:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xIw5J8JiW9EWdbkmaTRIkgvuE5eWmxbyOxxWHb1qODM=; b=IQQP/nmNwdcKQmc1MyI1YA+Fmj /punLxww0BQwWjRhe01y/fBF+fTCLhxtJRdmeIk6maNBwLtdpRcsLcxrIrTfA3kIpEBjM7JljqC/Z rCLRpkzau8DfX3v25mgaYfTQZx4rnuQ5KTGajocpP4T5YVWtnOu+Bi+ZL7Eo4tKiiva+P2bXSVMqp ZQV7eNdklwO3RWd7XN26k9rCLTzkoRpVqHFA+dded2/hw/RFVp2dw99X/w8auy/N0CitoGM/6tfXa /GfU3VZpCDk6Clrx6x2NjVCfP46TwlkG+0eDGD1b9p1aHzNrSMutppm252V/p5TdWuKkS1l6ltsmp TKXK4MJA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM8sB-00D58V-9T; Thu, 11 Aug 2022 14:09:19 +0000 Date: Thu, 11 Aug 2022 07:09:19 -0700 From: Christoph Hellwig To: Hongchen Zhang Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-wbt: do not throttle swap write on processes other than kswapd Message-ID: References: <1660217545-10697-1-git-send-email-zhanghongchen@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1660217545-10697-1-git-send-email-zhanghongchen@loongson.cn> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2022 at 07:32:25PM +0800, Hongchen Zhang wrote: > + if (current_is_kswapd() || > + (bio->bi_end_io != end_swap_bio_write)) > + flags |= WBT_TRACKED; Why can't this just use REQ_SWAP instead of doing strange poking into deep kernel internals?