Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220811091713.10427-1-justin.he@arm.com> <20220811091713.10427-2-justin.he@arm.com>
In-Reply-To: <20220811091713.10427-2-justin.he@arm.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Thu, 11 Aug 2022 17:07:20 +0200
Message-ID: <CAMj1kXGJ9_B48n-vDJC45m5kEYgVnsG--MDDO_crWTgBKj05rQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use
To:     Jia He <justin.he@arm.com>
Cc:     Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-edac@vger.kernel.org, devel@acpica.org,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>, linux-efi@vger.kernel.org,
        nd@arm.com, toshi.kani@hpe.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 11 Aug 2022 at 11:17, Jia He <justin.he@arm.com> wrote:
>
> Before modularizing the ghes_edac codes, we need to export several efi/cper
> helpers to avoid linking error of ghes_edac.
>
> Signed-off-by: Jia He <justin.he@arm.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  drivers/firmware/efi/cper.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> index e4e5ea7ce910..053eae13f409 100644
> --- a/drivers/firmware/efi/cper.c
> +++ b/drivers/firmware/efi/cper.c
> @@ -290,6 +290,7 @@ int cper_mem_err_location(struct cper_mem_err_compact *mem, char *msg)
>
>         return n;
>  }
> +EXPORT_SYMBOL_GPL(cper_mem_err_location);
>
>  int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg)
>  {
> @@ -310,6 +311,7 @@ int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg)
>
>         return n;
>  }
> +EXPORT_SYMBOL_GPL(cper_dimm_err_location);
>
>  void cper_mem_err_pack(const struct cper_sec_mem_err *mem,
>                        struct cper_mem_err_compact *cmem)
> @@ -331,6 +333,7 @@ void cper_mem_err_pack(const struct cper_sec_mem_err *mem,
>         cmem->mem_array_handle = mem->mem_array_handle;
>         cmem->mem_dev_handle = mem->mem_dev_handle;
>  }
> +EXPORT_SYMBOL_GPL(cper_mem_err_pack);
>
>  const char *cper_mem_err_unpack(struct trace_seq *p,
>                                 struct cper_mem_err_compact *cmem)
> --
> 2.25.1
>