Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp722053rwb; Thu, 11 Aug 2022 08:51:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ASIOdgKXwgitudovou9g984QfOQQGFF5c8Ik9llE/09zm3Pyd8p8nmSvjxt4sIpj6ahU1 X-Received: by 2002:a17:907:7241:b0:734:b282:184b with SMTP id ds1-20020a170907724100b00734b282184bmr2636397ejc.445.1660233096126; Thu, 11 Aug 2022 08:51:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660233096; cv=none; d=google.com; s=arc-20160816; b=ixhkx9VprAaClQGS1Xgn9Y0wlHlGQItkd8UT+ms7No5DCrx7zlDkbkG0NKLFEcJgtl eeW6pBMRopWuEvKICBnWk/5S74THrmr5hbira0SbJTXT7G4T00uzZyV/o7dJl+ucZlUg LGv8FXfdvQCmQkWO7hwGMCQRtSz/wDIBaABnfXyBLtsEx1+dQWJ4obK9Bz76Hqf3qFAP BQocbrwFYROxzZiysRLaKQhv5M9Po+gHriTWJMagBDGXs6AkBTrI562EiLNQc+n3sE7d P8+piqIfw3q6kkVj5Bvf3bmgq9ReQCyyXiYTwRYcfRn1Ur54YEloA0Zk9m3r14ilbMTi H3RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5w4LerBx6pluL5hWSjCUy6U5aknGE0ymDNztcNBibbY=; b=pr+7sE9aYwRscr3JnWD8XCVKtyi2y4eB8ZaKjHV0OX4TxtxTmx26U1oM3Mv0zXEj23 wc8HbRKjP2Zsyjki4PhF/XFZ5L/bs1IZd2ULA/ICLOUoehtm2fVYG84cyD7DFNW1COtY m11BLnoQWJ/xRQUa079zH3GBkoEBgUdP3t+fj8U6gc4pUItbIg1V9AGbsI6n7OWqCy0C Up+to3rinGSkgQsiCj6MnnOGhjUT4d+BNhw81unNDarHSzUjz66UE8V1QEy6itKdetyK icfBQaLkFV9y3rTzPz5ekSgowRjbs3J1rjE7rUTJTMQXsgrG93V2UF+sJQsiDCX7K+vP Qblw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=Tckq2Etg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf1-20020a1709077f0100b00730a3ab65e2si8592610ejc.611.2022.08.11.08.51.10; Thu, 11 Aug 2022 08:51:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=Tckq2Etg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236499AbiHKPn6 (ORCPT + 99 others); Thu, 11 Aug 2022 11:43:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236479AbiHKPnl (ORCPT ); Thu, 11 Aug 2022 11:43:41 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D8A1A50E8 for ; Thu, 11 Aug 2022 08:38:08 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id B797E5FD04; Thu, 11 Aug 2022 18:38:05 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1660232285; bh=5w4LerBx6pluL5hWSjCUy6U5aknGE0ymDNztcNBibbY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Tckq2EtgEiZUvdQAO1p+MllsNXNcoXG7HQ7THmKvR8j80dK3KOQ+fqTct2640cvSc 1ufqAlnlY3OqHDKZVJEjQVLcLuA3A5qnsl7RklR+VXCYgWnQ3nh4p1XqsgYwcoSb+Y MKt/B0cRILv39RTH9wpxae0Ao7FKbIsYnejEcvGA199wEj9m/TjZIjofStB3Rzk1jR bwFbr9rjxv/mp/gDQRd2j+um3vc21AMSWnt2foacexSb9tUspZDlN/LoWbsRr3tgNQ fdQjcAdA4E56wjml1fYDBPBOQNYeUFPgIfy5flVYZEJHTqyj9UpuDyZtPQt+vHIZzd jTACYe0T/BzAQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Thu, 11 Aug 2022 18:38:04 +0300 (MSK) From: Alexey Romanov To: , , , CC: , , , Alexey Romanov Subject: [PATCH v1 0/2] tidy up zsmalloc implementation Date: Thu, 11 Aug 2022 18:37:53 +0300 Message-ID: <20220811153755.16102-1-avromanov@sberdevices.ru> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/08/11 13:20:00 #20096813 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! This patchset remove some unnecessary checks and adds clarifying comment. While analysis zs_object_copy() function code, I spent some time to understand what the call kunmap_atomic(d_addr) is for. It seems that this point is not trivial and it is worth adding a comment. Alexey Romanov (2): zsmalloc: zs_object_copy: add clarifying comment zsmalloc: remove unnecessary size_class NULL check mm/zsmalloc.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) -- 2.30.1