Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e191acd-0b71-784a-2c14-6e78351788cc@intel.com>
Date:   Thu, 11 Aug 2022 23:33:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 03/13] KVM: x86: emulator: introduce
 emulator_recalc_and_set_mode
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Wanpeng Li <wanpengli@tencent.com>,
        Ingo Molnar <mingo@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "x86@kernel.org" <x86@kernel.org>,
        Jim Mattson <jmattson@google.com>,
        Kees Cook <keescook@chromium.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Joerg Roedel <joro@8bytes.org>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20220803155011.43721-1-mlevitsk@redhat.com>
 <20220803155011.43721-4-mlevitsk@redhat.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20220803155011.43721-4-mlevitsk@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHJRUnJmanAwcEkrTDVnT1Y3aG5jeHBwd2V1c3plcmRwM3dXdHIwc1p1cTF6?=
 =?utf-8?B?eDdlQnhUOXQ5VTJLOGtXeUFmQmEyQ2dKSkNKSlEwK2NHZXRDbUI5dGpsWGRs?=
 =?utf-8?B?WkgvaG5KUm9NM25TYVlTNDhlNVloRisyQ0xjYWl6ZDRhUjlCOVg5dFVSSHcx?=
 =?utf-8?B?dlk5WXpjUFA1d2wwN3llZ3hGMzRWdEI4SUM1SzF5MTdPQ3VZaFozZG1OUGRE?=
 =?utf-8?B?OVRMYlM1YlFUeVdwMFJBMG9zWHJZZVZML1I5Z3dpU1BRWVo2aU5mMFRyb3Bm?=
 =?utf-8?B?QThoRVFCajZkcENoaE8ydDJzU1FoWE9ZSTNjdGlKL2VrUXd1UWZBYzdqL0ph?=
 =?utf-8?B?Qm53cmsrZDJMSkF5cXFQOHJPMkQ0UFlGeHVNVFVWUno5cENJSU8vM1Y1TUcr?=
 =?utf-8?B?SUNma01uL1VBbWdtQUlkTGN4MjZvN08yNHhuSE5RVm5VQUNLWWVZTlpnNXhC?=
 =?utf-8?B?cWxERU1GR3AzRS8xQllPL3NPZldTelBQUmRqVU90cXg3QlN3YnJzdHUzWFRH?=
 =?utf-8?B?S05mY3MxWGswUFVhbmxmY1hIT0xDR0t5WnZlRnJ4bGd6dGdUMDBVenpqczdw?=
 =?utf-8?B?dkFialJlQzhkWWYxRlZCckgyVHNXekJ1NGI3TzBqQVBuTE9LQUpEaDUwNEZv?=
 =?utf-8?B?WnRUemlKbFA1cU4xaWYvSHlDQVVoSFdNa25oZGp6S1VTMGVUN0pGaUZRWEpq?=
 =?utf-8?B?REw1WCt2aWR3SldqK3lyVGtNQVN4ZTZ4VkdXbE8vY1UzalNvRVJvUXl4djRM?=
 =?utf-8?B?K09KN01VTm1vV094RjBNNEZzQnZidHVheVRtSFkrbGVRR2Z4V2tXTyswM0RQ?=
 =?utf-8?B?NG1Ud05nU2RaU055R3N6aFBHb2gvcTRQamxTR1d0SDhvcDVsUVNaNlJzQmVz?=
 =?utf-8?B?OEEzYjFkVHJlK1dOVDZwaHZnOWQyVFNSSi9Ka1pJdCtNSGR4RlN0MVZaek1M?=
 =?utf-8?B?MVgzVmlYSVUyQlVRRktuSUpWT29VK3NwcnhLakZkZkQ5OUNkOEMrbmRzU1Vh?=
 =?utf-8?B?cElZd1k0a1ZWZEhxYlcvYm9TMGllMmYyWDlZZWFoMjVKcG8zdDAzYlNDRkFy?=
 =?utf-8?B?U3ljVlcwTWVlUUU3SXNmM2JWcDJVQ3UrOTZ5UkovK25BR0w1Q1RSbkR4d2l5?=
 =?utf-8?B?YVlYU296RUVTRFhra2E3NmhjcCtuUE1lN2VsWXN2SlZmVGw2cDdQUnpyRmJX?=
 =?utf-8?B?SlhGNm11dDFhV1BTMlF2VERyLzBpL0dVTFVUOGd3Ulkzb0U5TFR0b2VOaWJB?=
 =?utf-8?B?eXVycTJBTlFBaHdHenNlUVZjenNXdWhUbVBCSWNIN0FCc0pJbTRMaXYrQlZ0?=
 =?utf-8?B?VjVTTTE5c2gwWGR6bEVkRVl1WVhnMklMRFBxVmd4UWZjQi9DWlNCTEpWb0pC?=
 =?utf-8?B?YmMyS1NSajIwK0Erd25RV0F6UENuUGpDSGt1azdlbFozWU96MStCYjQyaXFs?=
 =?utf-8?B?SFJ5OFdVUXdMUitHdEdGZDhEOVZWd2tieFhLc1lrc1RRR3Bnak1lUmt4Y3Bq?=
 =?utf-8?B?a3cvRTg5dmxJYXVqaWpBOXJxTEdhSUJlRG9oSjZmS2dVVWgycURJT29NU09q?=
 =?utf-8?B?NytJUmdEclMzUi9aVk1aMHNFMU9QNEJtSTJRd2tldmRnamZuaE1yaGFDRHh5?=
 =?utf-8?B?UThzbnlMTmsybC82eGNVdFNWNVgwWG1oTHE3QU90VkMwZXJycnJHK25xak4y?=
 =?utf-8?B?UVdQVHZXYzBwNEwzNUpQT1lDWDFoY2ljNG9Vd0N6ZDA2U3pFT1ZoS0RnM3JQ?=
 =?utf-8?B?M2RMMEhUQnRrUUNqZ0J1M21NVWU2NHB2eE8zckFxRU41Q2dOUXhmckF2Wk1a?=
 =?utf-8?B?WDVzdVpOWUZVanRoZG5NbzNRZHZTeWI1alpWSHEzVFpqbTlWVUJLcVZSNHBu?=
 =?utf-8?B?MDNGK0VtSVhjTHJvdWFTL1dXcE5JU2VVSjlHTWxYTHExM3Rmc0tmMW5hbDUr?=
 =?utf-8?B?dy94cTczN0hqYlBLQVdWTzFZWUNhdW5PUHFXYlk4SmIzdFNWcHNHdWt0VFNi?=
 =?utf-8?B?TGdqQWI0SDk1WWNUa29ZT0w1a2Y1dGwrU1lZZWdSQUhtWjkrc1BLOHdOTFpH?=
 =?utf-8?B?Tkg0YWdwRDk4cGNTakJrMWkxSWpZcDhUdFNQbmVOaVN3c2JuRFBmUHhNcU50?=
 =?utf-8?B?aXZsV09FdSttUkhwRVlKcm9vaWk5OWxOVGMwQzA1b3FSYkdaMkZSTC9FS1V1?=
 =?utf-8?B?b1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85dfdac4-ea9e-42d3-ae59-08da7baeef9b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 15:34:10.2860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TNydtMn2w+909kxD3/A1hNQdE96nyaqMd6vIdx0Sxm9rvqEqmQtnaNigQMDokzQY2U6Dkumeb26ypWx/5wAU9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5918
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/3/2022 11:50 PM, Maxim Levitsky wrote:
> [...]
> +static inline int emulator_recalc_and_set_mode(struct x86_emulate_ctxt *ctxt)
> +{
> +       u64 efer;
> +       struct desc_struct cs;
> +       u16 selector;
> +       u32 base3;
> +
> +       ctxt->ops->get_msr(ctxt, MSR_EFER, &efer);
> +
> +       if (!ctxt->ops->get_cr(ctxt, 0) & X86_CR0_PE) {
Shouldn't this be:  !(ctxt->ops->get_cr(ctxt, 0) & X86_CR0_PE) ?
> +               /* Real mode. cpu must not have long mode active */
> +               if (efer & EFER_LMA)
> +                       return X86EMUL_UNHANDLEABLE;
> +               ctxt->mode = X86EMUL_MODE_REAL;
> +               return X86EMUL_CONTINUE;
> +       }
> +
[...]
> --
> 2.26.3
>