Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968801AbXFHLWz (ORCPT ); Fri, 8 Jun 2007 07:22:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S967847AbXFHLWo (ORCPT ); Fri, 8 Jun 2007 07:22:44 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:58575 "EHLO the-village.bc.nu" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S966065AbXFHLWn (ORCPT ); Fri, 8 Jun 2007 07:22:43 -0400 Date: Fri, 8 Jun 2007 12:27:50 +0100 From: Alan Cox To: Tejun Heo Cc: Jeff Garzik , Linus Torvalds , Gregor Jasny , Linux Kernel Mailing List , linux-ide@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] Re: Linux v2.6.22-rc3 Message-ID: <20070608122750.7f8ae0e0@the-village.bc.nu> In-Reply-To: <46690D10.9040808@gmail.com> References: <9d2cd630705270801m2826be60p3f802c502b26c531@mail.gmail.com> <466196AD.3090502@garzik.org> <9d2cd630706031046n2bd77585o7c0df1c5fea5167f@mail.gmail.com> <46667466.4010500@gmail.com> <9d2cd630706062322v2d73b32dp1da56f97e2069fff@mail.gmail.com> <4667B347.9040900@gmail.com> <20070607224746.GA23290@havoc.gtf.org> <46690D10.9040808@gmail.com> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.8; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 15 > Upto 2.6.21, if the same condition triggers, it delays 30secs and just > continue, so I don't think it was a worthy protection against ghost > devices or TF malfunction. The only protection it offers is preventing > libata from accessing slave's status register too early. SRST sequence > looks like the following. I've seen no bug where it looked like it saved something, and the only ghost device bugs I've seen it failed to detect anyway (hence the PCMCIA drivers own ghost detection logic) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/