Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Jia He <justin.he@arm.com>, Ard Biesheuvel <ardb@kernel.org>,
        Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>
CC:     "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "nd@arm.com" <nd@arm.com>, "stable@kernel.org" <stable@kernel.org>
Subject: RE: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the
 dependency on ghes
Thread-Topic: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the
 dependency on ghes
Thread-Index: AQHYrWP5SAOmNkRRRk2vGxqNR/QEGq2qFH4Q
Date:   Thu, 11 Aug 2022 19:26:06 +0000
Message-ID: <PH7PR84MB183847AA20B2E879E0F2B90D82649@PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220811091713.10427-1-justin.he@arm.com>
 <20220811091713.10427-3-justin.he@arm.com>
In-Reply-To: <20220811091713.10427-3-justin.he@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1vDb68QoyY2CpUXNt/z+eXGwbocnPA6i5iClt3XmJ04N8VT9vbfFiTCpdWsJ?=
 =?us-ascii?Q?F/CpsruP9I7UmuVkpiy9p6n49WcUiH1mj3aWUKmw8zdvMjBW878xd2Nc1fpA?=
 =?us-ascii?Q?3sbIEpUuEgX97GJmU4tGqzmIgUB6sWhvk/0XfRWrW5GjutBAk7vP4SLAN6s8?=
 =?us-ascii?Q?39AVjruJOXHnvj6POE6YpZYqkGOtH39eh0VAQ3fNaaBSS3RWl0FiVC3ql0wB?=
 =?us-ascii?Q?AfPH07Je2FLHx4RxezfWEuFLGOqeFiKjvWZp7zgnkTT/68pE7cC6J70KfP4+?=
 =?us-ascii?Q?dEQUKR1KieLM7s/7wpbolKibYqaGV8w3jWueaS6jHGYlYR9aFD8JvY1/tS78?=
 =?us-ascii?Q?Y7ztE9SbtfuXqBjTdYEsk97kizC/Z7bBULh/jNr0vyq2umm8ARp+t8/AWuwJ?=
 =?us-ascii?Q?t21bpqZGZgg/nbzH6FY6zxIJ3sAtdaFeKPm+iTTHifka+NCXtsvrKObkUtmo?=
 =?us-ascii?Q?F1uwJvFGAU90DaZLZUep/avvSe99f8CPvifrsb/FmbfdNBCxnBLqDC6/u9BZ?=
 =?us-ascii?Q?VX17RrOF7wGttqwwsckerqIf9tHK9Wv3FTuDWCH9BAv0j/s3f4adXv/LwHUL?=
 =?us-ascii?Q?BGZcYC9fWjsJBl/QihKNl6JjNI55cIgyGeKCXIoc4/Vl+XrWHEv+wTETZztv?=
 =?us-ascii?Q?9qrxncv3T6w57/BiLcJtCb/ANJft7RuuhEbtZD/u11hq6C7xWIKP4qWCCrIN?=
 =?us-ascii?Q?26bBBZIaD5yODkldKx7ITWVj90+gf3xgdRbzEs2v6CCJ610311uW5m82MSdt?=
 =?us-ascii?Q?eemv5qGVsRS2vfqK01UFfmXksnn0fAeo1KT/Gi6UrOcGbnCrw/K+VdpKveGf?=
 =?us-ascii?Q?/zSNAqpg3KXNGxGf23oqi1WWPlbYjy64MKvbE6bDgCAhoAv1Qz3npT5KWvf+?=
 =?us-ascii?Q?JYEZgsNWSPEzH4Qf6D02eH1RWUcgOv+8shPD+EWt+ICmcKIhexRsiW2T75mB?=
 =?us-ascii?Q?wfF3PGficBkZtv2GE9XaKDKz2RJ/vpuEGpehT9XvUGcWlZNCNpxBotZRYW+C?=
 =?us-ascii?Q?NEBKmk2cHsn4OigazFJoPrNArLpiaeMZAgLqrGfKY19LMiH8oPOSfLtRmcQs?=
 =?us-ascii?Q?mNXTMl2K8nCZWqqqu8ntKhxonCm8e/PGgBcY2a25iwtNcGVpuzhJ1tddMYiB?=
 =?us-ascii?Q?CNuDTikzrsswuWigncCOP2sXFd5vlC0BwriQe/cYIScYRDDlQElP4bNfwtom?=
 =?us-ascii?Q?fbr6H3l7UMUgsx95W2X1/1XKUt06/LIOSPBVcGIEgGPJhZimlHl7/W/IuB5L?=
 =?us-ascii?Q?idPalcnKu/NUED+NKiwBMi6n9MssysTvqIotw29zfSaU5OcJGAcFHVwVCdrG?=
 =?us-ascii?Q?pNDBRkb1+iHTuJ5ApCzv+4Q248WFzDTCnczQ0Ke8r9dA5PbjhjypkTfVt8K9?=
 =?us-ascii?Q?4p16jWr1beDJilkaXY7Rdjib99W9c+K2qYhayGc6TRJvH6w1bwqCNYp2eoFP?=
 =?us-ascii?Q?UI2Z+lpHZkvjoBg7mSjIuJGV22jVfr6jizJ6y+c8UneCeFuyY5Ia8sT9jlt/?=
 =?us-ascii?Q?lflqUoB/nQg2Owt3zatkEsVvkv/9JG57cWemdkRd1wQmSPeaxmF1C/zTtIil?=
 =?us-ascii?Q?PsR4jt+6JYBxjaIFjp+xHYJLDICUx4GB/GX8V7Fq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 651f70ed-14be-436b-60a0-08da7bcf56b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2022 19:26:06.9404
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NhFCblm81m+KeFtCSx061gm3g2HbpQmtD38NPIki62GuvgblvPLg5imlYrqUz6WbSE9U3m8alqdzrOeD4XRgkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1372
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: m-2kpa90as8IeTnABBy4Rhtmx_XXlp1k
X-Proofpoint-ORIG-GUID: m-2kpa90as8IeTnABBy4Rhtmx_XXlp1k
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-11_13,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 adultscore=0
 clxscore=1011 malwarescore=0 mlxscore=0 spamscore=0 priorityscore=1501
 mlxlogscore=927 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208110060
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, August 11, 2022 3:17 AM, Jia He wrote:
> Commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in
> apci_init()") introduced a bug that ghes_edac_register() would be invoked
> before edac_init(). Because at that time, the bus "edac" hasn't been even
> registered, this created sysfs /devices/mc0 instead of
> /sys/devices/system/edac/mc/mc0 on an Ampere eMag server.
>=20
> The solution is modularizing the ghes_edac driver.
> Use a list to save the probing devices in ghes_probe(), and defer the
> ghes_edac_register() to the new ghes_edac module_init() by iterating over
> the devices list.

Since this approach defers the ghes_edac registration, the series needs
to include a way to prevent chipset-specific edac drivers from registering
before ghes_edac as discussed in the original email thread.

Toshi