Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp973550rwb; Thu, 11 Aug 2022 13:19:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR75aKPXZWsg8tfL5eMe7kKJsHo2sM4tKZtLGQc17RYsiTJpLqozbw3so+Ki/vbcXb3Bg9Rg X-Received: by 2002:a05:6402:28cb:b0:43b:c6d7:ef92 with SMTP id ef11-20020a05640228cb00b0043bc6d7ef92mr699793edb.333.1660249169155; Thu, 11 Aug 2022 13:19:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660249169; cv=none; d=google.com; s=arc-20160816; b=NwjX8FTIJ3PSwe7QcRyX1O8DToNC0QsVJHO4CKC7p3Z9vZOn640uyhcgNp+ZtlVgBD 0zwXhGZFEK3tkBApLQi6onf7THZ5oQb3Hsp+A3VY2iVu35uUb27B/wmi4hcJevua9bV9 66hoak+oAbXMBu2bgohNQToq8sKsL65kU5wbmY2iVccaWRwB/Q9My3srjMy0eSNMADLe geiSlmBbiXEkqh16kOJDu6bZXfCNshq3XEUllYFeAj1hziJEbPZ/46AdrTT/GjbLUlgc B9qi624KCKT4C0MHWjrmr4WcgYYfM58Syeb0I8LXXB1178jdLrNG9p7N8VjaQrZipw8+ Y0yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=zQB4Obdf/ipH+ijxdi6W4PtV/skZKNQuUU98S4y1UyM=; b=UlLnmlaVGQXu3M89Z8/q1UGaMKFNkhHRmLHvLC/ZwsKIFQSkwNv9paBeazQpI2VpvE OdSDRb9JNRZRnb5HP/j/EHp5dwr1xmqu2SoZLI41lR+SD+H0s78qJMgeqv83D4IyqfWn 40jwmpwVyGP27SyHLFHX0oCopoOFzuIevn2q9/NvwqAwZ0imG4+o4FIAarZP6x+d6Ruw 6bT6uLubI0xE+W9ZC2bOnMqkR6u7Svfy3dRUIvS0J8O9UYk6/gHJVeyajQj/v9UGquiZ MTh820FQ61W5z5k9lPZVDrrStiT2e+1asDZ7SLUL4q0J5JTRPx0vHR88K2/h5YGz0aTc ySFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=DVfnJzwP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o16-20020a170906975000b00732989ac0absi155443ejy.42.2022.08.11.13.19.03; Thu, 11 Aug 2022 13:19:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=DVfnJzwP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234335AbiHKUEV (ORCPT + 99 others); Thu, 11 Aug 2022 16:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231352AbiHKUET (ORCPT ); Thu, 11 Aug 2022 16:04:19 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FAB09C209 for ; Thu, 11 Aug 2022 13:04:18 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id z20so22371133edb.9 for ; Thu, 11 Aug 2022 13:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=zQB4Obdf/ipH+ijxdi6W4PtV/skZKNQuUU98S4y1UyM=; b=DVfnJzwPFC5exnMxGhX1SSonGK3v6yFK5cwUkJwWATTOdO2d7HIXjTHHwt7FK0Icgn MSM0ofpCJemi1TDflXFCe7xEbC8iysXVsdR03vgzw/srZPjyS8O/Si7Xj5FtxNCvluaG 3oWJ0O5YjeoGs/uxzAmlfHB+rzqheSHhTA4R0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=zQB4Obdf/ipH+ijxdi6W4PtV/skZKNQuUU98S4y1UyM=; b=2mhlyisixvv1ftG2g49745i2TckO5Du8bdU+YYHh2ytn72VQ7AnDO5hnMXqVgBBOVQ ZwocODragyyldb3JuODWIkyZ5YBNac2p2Bqeb72w584zJFg2ss+dqSbStaohVJnZVGL5 TBOczWft8EwRF3NxzfvuanaLrbtlaG9q3Ta85/mnyw4Ni94AnVaYXx3XHhv8P2FEeT9E AmbcwCaQwZO9B85RAnO7LKr/141/sd7fRbF5b4OTtq/kM1dLbuvuPeH+izx3xBgZbXDI AUF+cXDYAcEPZJWtCJ7UxVM9WVmuGoVjKMSxHT71udDk0ku03huLlIMaPMHVzWG4Hfpm rXNg== X-Gm-Message-State: ACgBeo1fWUDQjakiAuzVU+1gBQKxMThcxVys/JiZ4ABczXsghYNdRyyv Um6KIutuLvrNCM7+MOXn6FO14IYIuDZvA+Dz X-Received: by 2002:aa7:c30c:0:b0:440:a189:541d with SMTP id l12-20020aa7c30c000000b00440a189541dmr691269edq.64.1660248256224; Thu, 11 Aug 2022 13:04:16 -0700 (PDT) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com. [209.85.128.45]) by smtp.gmail.com with ESMTPSA id s23-20020a508d17000000b0043d7923af6esm193483eds.95.2022.08.11.13.04.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Aug 2022 13:04:14 -0700 (PDT) Received: by mail-wm1-f45.google.com with SMTP id b21-20020a05600c4e1500b003a32bc8612fso3162389wmq.3 for ; Thu, 11 Aug 2022 13:04:13 -0700 (PDT) X-Received: by 2002:a05:600c:4ed0:b0:3a3:3ef3:c8d1 with SMTP id g16-20020a05600c4ed000b003a33ef3c8d1mr6705127wmq.154.1660248253437; Thu, 11 Aug 2022 13:04:13 -0700 (PDT) MIME-Version: 1.0 References: <20220811152446.281723-1-idryomov@gmail.com> In-Reply-To: <20220811152446.281723-1-idryomov@gmail.com> From: Linus Torvalds Date: Thu, 11 Aug 2022 13:03:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Ceph updates for 5.20-rc1 To: Ilya Dryomov Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2022 at 8:25 AM Ilya Dryomov wrote: > > [..] Several patches > touch files outside of our normal purview to set the stage for bringing > in Jeff's long awaited ceph+fscrypt series in the near future. All of > them have appropriate acks and sat in linux-next for a while. What? No. I'm looking at the fs/dcache.c change, for example, and don't see the relevant maintainers having acked it at all. The mmdebug.h file similarly seems to not have the actual maintainer acks, and seems just plain stupid (why does it add that new folio warning macro, when the existing folio warning macro VM_WARN_ON_ONCE_FOLIO() is *better*? Those are some very core files, and while the changes seem harmless, they sure don't seem obviously ok. What's the point of warning about bogus folios more than once? That's a debug warning - if it hits even once, that's already "uhhuh, something is bad". Showing the warning more than once is likely just going to cause more problems, not give you more information. And did somebody verify that d_same_name() is still inlined in the place that truly *matters*? Because from my quick test, that patch broke it. Now __d_lookup() does a function call. And I _suspect_ it's all ok, because it turns out that __d_lookup_rcu() is the *really* hot case, and that one has inlined it all manually. But this kind of "we touch some *truly* core functionality, without the acks from the maintainers, and then we *claim* to have relevant acks" is really not even remotely ok. I've pulled this because I suspect that d_same_name() thing is fine, and I think the VM_WARN_ON_FOLIO() addition is completely wrong but not horrendous. But you're on my tentative shit-list just for having claimed to have appropriate acks and having been found wanting. Just for your information: fs/dcache.c is some of the most optimized code in the kernel, and some of the subtlest. That RCU pathname lookup is serious business. You don't make changes to pathname lookup just willy nilly. There's a reason I start looking at individual patches when I see it in the diffstat. And please just get rid of VM_WARN_ON_FOLIO() again, and use the VM_WARN_ON_ONCE_FOLIO() version. Because if you expect to have multiple, then you probably shouldn't have that warning at ALL. Linus