Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 22:22:37 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Ilya Dryomov <idryomov@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [GIT PULL] Ceph updates for 5.20-rc1
Message-ID: <YvVzHQ5DVaPAvw26@ZenIV>
References: <20220811152446.281723-1-idryomov@gmail.com>
 <CAHk-=wifgq59uru6xDB=nY-1p6aQ-1YB8nVhW7T-N2ctK3m1gw@mail.gmail.com>
 <CAOi1vP9BSi-65of-8D0BA1_DC0eVD_TQcWkhrGJwaXw_skhHFQ@mail.gmail.com>
 <5d0b0367a5e28ec5b1f3b995c7792ff9a5cbcbd4.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5d0b0367a5e28ec5b1f3b995c7792ff9a5cbcbd4.camel@kernel.org>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Thu, Aug 11, 2022 at 05:08:11PM -0400, Jeff Layton wrote:

> Actually, I never got a formal ack from Al. I did send it repeatedly,
> but I assume he has been too busy to respond. We've had it sitting in
> linux-next for a couple of months, and he did suggest that approach in
> the first place, but I too would also prefer to see his official ack on
> it.

"Suggested approach" had been about inode_insert5() changes, right?
But that's fs/inode.c side of things...  I have to admit that I'd missed
the unlining d_same_name() - exporting the sucker per se didn't look
insane and I hadn't looked at that in details ;-/

Looking at it now...  might be worth renaming it into __d_same_name(),
leaving it inlined and exporting a wrapper; not sure if the impact on
d_lookup()/__d_lookup()/d_alloc_parallel() is worth worrying about it,
though.

Profiling a case when we have a plenty of files in the same directory
on tmpfs, with something earlier in the pathname to kick out of RCU
mode (e.g. going through /proc/self/cwd) might be interesting...