Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1032273rwb; Thu, 11 Aug 2022 14:34:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR7++TZVw87dSuhqb0VWw3ti6X8jzrzBffmNTJMHCtIpUPwjTXoXkdVh5g3FZnVE9M3Lebd4 X-Received: by 2002:a17:907:7295:b0:731:6a6b:209c with SMTP id dt21-20020a170907729500b007316a6b209cmr690241ejc.320.1660253689204; Thu, 11 Aug 2022 14:34:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660253689; cv=none; d=google.com; s=arc-20160816; b=0hSbtKZuC7ZxsYj/9xqLJMCq9glE+ZhIK/Rcb1wz0v9jvDbjt/Dzp+X8wb9A7j11xO v1azgnaFJLrya82jlJje1fG/j1mnGVT9yXeb+oHedTbo+ak2S6tjf28VPUV6qryoMxC9 2N7zriDJxwaDoHfsBY3W/2C4osERj4DrGMq79uejY2hO0O8l3QJd7kxtI0IrWjkHoH27 MVu0c8yyJ23Fkevp9ncTxkvLcm8aHfvw6SwcaQ6M86VXGSldv46QRWUhLtTDBj+Um6/I Z/tOCwcVp0FwlsHWM/czrGBgUlATCpN0Cp+u1r/8DSHeGlp1zFPmKTjwXCEpukhwXIwy D3Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=Arr1LSX5+h1rmUtX3pK5XV48PybO3lKYSGDYNpjIoR4=; b=xH63UPy9Tzzy4O8BBdAcfkevtAzOwE9RHCBfXO0l2pSGNNAsHzO3CuVWKlxWvIZbkK UZfSH36uYfpCycLk0d19T1mW1T8/+gmIF6NlLzBOc0oQba0OAPoIGIwVjClOMebK7BJ5 /lPDvMGbUqt3pB7rLnyKa7hbpj/6lSNnGOJePtFNIhPtXlmmNnLEtXb4w3sm78POSQ3G 1nVBRA5JlbTLRE22v3W9GfvU4F9DcFe9XpajEoyeq8qmrfCxniAozcJhInbHU2DQ/MxZ zTEMmPuIb0Oi3BQgsUpgNBkB0GTuCg2hvrJxq6+IZHSpSXfHSu6uGoitPcoWVECFplzE tcLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m20-20020a056402511400b0043a7cdf26aasi631268edd.85.2022.08.11.14.34.23; Thu, 11 Aug 2022 14:34:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236090AbiHKU7J (ORCPT + 99 others); Thu, 11 Aug 2022 16:59:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234269AbiHKU7H (ORCPT ); Thu, 11 Aug 2022 16:59:07 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F0E98A78 for ; Thu, 11 Aug 2022 13:59:06 -0700 (PDT) Received: from [192.168.1.206] (unknown [109.252.119.247]) by mail.ispras.ru (Postfix) with ESMTPSA id 1A8BE40D403E; Thu, 11 Aug 2022 20:59:01 +0000 (UTC) Subject: Re: [ldv-project] [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var() To: Geert Uytterhoeven , Andrey Strachuk Cc: ldv-project@linuxtesting.org, Thomas Zimmermann , David Airlie , Helge Deller , Maarten Lankhorst , Linux Kernel Mailing List , Maxime Ripard , DRI Development , Daniel Vetter References: <20220811144850.215377-1-strochuk@ispras.ru> From: Alexey Khoroshilov Autocrypt: addr=khoroshilov@ispras.ru; prefer-encrypt=mutual; keydata= xsFNBFtq9eIBEACxmOIPDht+aZvO9DGi4TwnZ1WTDnyDVz3Nnh0rlQCK8IssaT6wE5a95VWo iwOWalcL9bJMHQvw60JwZKFjt9oH2bov3xzx/JRCISQB4a4U1J/scWvPtabbB3t+VAodF5KZ vZ2gu/Q/Wa5JZ9aBH0IvNpBAAThFg1rBXKh7wNqrhsQlMLg+zTSK6ZctddNl6RyaJvAmbaTS sSeyUKXiabxHn3BR9jclXfmPLfWuayinBvW4J3vS+bOhbLxeu3MO0dUqeX/Nl8EAhvzo0I2d A0vRu/Ze1wU3EQYT6M8z3i1b3pdLjr/i+MI8Rgijs+TFRAhxRw/+0vHGTg6Pn02t0XkycxQR mhH3v0kVTvMyM7YSI7yXvd0QPxb1RX9AGmvbJu7eylzcq9Jla+/T3pOuWsJkbvbvuFKKmmYY WnAOR7vu/VNVfiy4rM0bfO14cIuEG+yvogcPuMmQGYu6ZwS9IdgZIOAkO57M/6wR0jIyfxrG FV3ietPtVcqeDVrcShKyziRLJ+Xcsg9BLdnImAqVQomYr27pyNMRL5ILuT7uOuAQPDKBksK+ l2Fws0d5iUifqnXSPuYxqgS4f8SQLS7ECxvCGVVbkEEng9vkkmyrF6wM86BZ9apPGDFbopiK 7GRxQtSGszVv83abaVb8aDsAudJIp7lLaIuXLZAe1r+ycYpEtQARAQABzSpBbGV4ZXkgS2hv cm9zaGlsb3YgPGtob3Jvc2hpbG92QGlzcHJhcy5ydT7CwX0EEwEIACcFAltq9eICGwMFCRLM AwAFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ2B/JSzCwrEWLaA/+NFZfyhU0vJzFtYsk yaqx8nWZLrAoUK7VcobH0lJH6lfGbarO5JpENaIiTP12YZ4xO+j3GGJtLy2gvnpypGnxmiAl RqPt7WeAIj6oqPrUs2QF7i4SOiPtku/NrysI1zHzlA8yqUduBtam5rdQeLRNCJiEED1fU8sp +DgJBN/OHEDyAag2hu1KFKWuPfQ+QGpXYZb+1NW/hKwvvwCNVyypELAfFnkketFXjIMwHnL8 ZPqJZlkvkpxuRXOaXPL9NFhZnC/WS+NJ81L3pr+w6eo3xTPYZvRW8glvqlEDgHqr3uMGIaes nwfRXLHp+TC1ht6efCXzdPyMZ1E7HXQN9foKisI1V5iQFhN+CT3dbsguQI4e10F5ql0TZUJY SMzvY0eObs6TWRdD/Ha7Y5rLmZ54R9sxumpZNcJzktfgm9f0XfeqVEJUn/40MRDD+l2W12Db Jkko+sbtAEw+f+/j3uz8xOE+Uv4kwFC5a6JKgdX88oigHnpAs3FvffP594Loi3ibFrQUW5wH bXh5Ni+l1GKEQ0PHMk+KQQT9L2r9s7C0Nh8XzwdpOshZWsrNSZqcG+01wrmUhyX2uSaoZ07I /+KZURlMSqI71X6lkMWlB3SyThvYhHgnR0EGGTerwM1MaVjHN+Z6lPmsKNxG8lzCeWeZ6peA c5oUHV4WQ8Ux9BM8saLOwU0EW2r14gEQAMz+5u+X7j1/dT4WLVRQaE1Shnd2dKBn2E7fgo/N 4JIY6wHD/DJoWYQpCJjjvBYSonvQsHicvDW8lPh2EXgZ9Fi8AHKT2mVPitVy+uhfWa/0FtsC e3hPfrjTcN7BUcXlIjmptxIoDbvQrNfIWUGdWiyDj4EDfABW/kagXqaBwF2HdcDaNDGggD1c DglA0APjezIyTGnGMKsi5QSSlOLm8OZEJMj5t+JL6QXrruijNb5Asmz5mpRQrak7DpGOskjK fClm/0oy2zDvWuoXJa+dm3YFr43V+c5EIMA4LpGk63Eg+5NltQ/gj0ycgD5o6reCbjLz4R9D JzBezK/KOQuNG5qKUTMbOHWaApZnZ6BDdOVflkV1V+LMo5GvIzkATNLm/7Jj6DmYmXbKoSAY BKZiJWqzNsL1AJtmJA1y5zbWX/W4CpNs8qYMYG8eTNOqunzopEhX7T0cOswcTGArZYygiwDW BuIS83QRc7udMlQg79qyMA5WqS9g9g/iodlssR9weIVoZSjfjhm5NJ3FmaKnb56h6DSvFgsH xCa4s1DGnZGSAtedj8E3ACOsEfu4J/WqXEmvMYNBdGos2YAc+g0hjuOB10BSD98d38xP1vPc qNrztIF+TODAl1dNwU4rCSdGQymsrMVFuXnHMH4G+dHvMAwWauzDbnILHAGFyJtfxVefABEB AAHCwWUEGAEIAA8FAltq9eICGwwFCRLMAwAACgkQ2B/JSzCwrEU3Rg//eFWHXqTQ5CKw4KrX kTFxdXnYKJ5zZB0EzqU6m/FAV7snmygFLbOXYlcMW2Fh306ivj9NKJrlOaPbUzzyDf8dtDAg nSbH156oNJ9NHkz0mrxFMpJA2E5AUemOFx57PUYt93pR2B7bF2zGua4gMC+vorDQZjX9kvrL Kbenh3boFOe1tUaiRRvEltVFLOg+b+CMkKVbLIQe/HkyKJH5MFiHAF7QxnPHaxyO7QbWaUmF 6BHVujxAGvNgkrYJb6dpiNNZSFNRodaSToU5oM+z1dCrNNtN3u4R7AYr6DDIDxoSzR4k0ZaG uSeqh4xxQCD7vLT3JdZDyhYUJgy9mvSXdkXGdBIhVmeLch2gaWNf5UOutVJwdPbIaUDRjVoV Iw6qjKq+mnK3ttuxW5Aeg9Y1OuKEvCVu+U/iEEJxx1JRmVAYq848YqtVPY9DkZdBT4E9dHqO n8lr+XPVyMN6SBXkaR5tB6zSkSDrIw+9uv1LN7QIri43fLqhM950ltlveROEdLL1bI30lYO5 J07KmxgOjrvY8X9WOC3O0k/nFpBbbsM4zUrmF6F5wIYO99xafQOlfpUnVtbo3GnBR2LIcPYj SyY3dW28JXo2cftxIOr1edJ+fhcRqYRrPzJrQBZcE2GZjRO8tz6IOMAsc+WMtVfj5grgVHCu kK2E04Fb+Zk1eJvHYRc= Message-ID: Date: Thu, 11 Aug 2022 23:59:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For v2 I would suggest to update description to something like this: Make sure that virtual screen size is not less than physical screen one. and comment to: /* make sure that virtual resolution >= physical resolution */ -- Alexey On 11.08.2022 17:54, Geert Uytterhoeven wrote: > Hi Andrey, > > On Thu, Aug 11, 2022 at 4:49 PM Andrey Strachuk wrote: >> Add virtual screen size check to drm_fb_helper_check_var() in >> order to validate userspace input. >> >> Found by Linux Verification Center (linuxtesting.org) with syzkaller. >> >> Signed-off-by: Andrey Strachuk > > Thanks for the update! > >> Fixes: 785b93ef8c30 ("drm/kms: move driver specific fb common code to helper functions (v2)") > > I'd drop the Fixes tag completely, as the bug was present in the > intel and radeon drivers before. But probably it doesn't matter, as no one > is gonna backport this to v2.6.31 and earlier ;-) > > Reviewed-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > > _______________________________________________ > ldv-project mailing list > ldv-project@linuxtesting.org > http://linuxtesting.org/cgi-bin/mailman/listinfo/ldv-project >