Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <ef32187cf1090de6e8cda2bf0218985cd3f4c21e.camel@ljones.dev>
Subject: Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes
From:   Luke Jones <luke@ljones.dev>
To:     Hans de Goede <hdegoede@redhat.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>,
        Pavel Machek <pavel@ucw.cz>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Fri, 12 Aug 2022 10:08:25 +1200
In-Reply-To: <a0688d90-8b20-fc50-56ec-d50a5601f468@redhat.com>
References: <20220809025054.1626339-1-luke@ljones.dev>
         <20220809025054.1626339-5-luke@ljones.dev>
         <CAHp75VeLWGURdL9SK4+fLPRsM_Dc3bNvGSoWXKOWMSz=3CQUQg@mail.gmail.com>
         <a0688d90-8b20-fc50-56ec-d50a5601f468@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

Hi,

On Thu, 2022-08-11 at 17:08 +0200, Hans de Goede wrote:
> Hi,
>=20
> On 8/9/22 11:25, Andy Shevchenko wrote:
> > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev>
> > wrote:
> > >=20
> > > Documents some previously added attributes:
> > > - dgpu_disable
> > > - egpu_enable
> > > - panel_od
> >=20
> > Try to find a commit that introduced thouse and add the respective
> > Fixes tag.
> >=20
> > ...
> >=20
> > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * keyboa=
rd - 0 or 1, unknown what effect
> > > this really has
> > > \ No newline at end of file
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * keyboa=
rd - 0 or 1, unknown what effect
> > > this really has
> >=20
> > Should be part of another patch.
>=20
> Ack to both remarks.
>=20
> Luke please make this patch one of the first patches in your next
> version / patch-series and then add the doucmentation of the new
> kbd RGB backlight attributes in the patches where you are also
> adding those actual attributes.

Yep, done. Everything is looking much cleaner too.