Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220804223504.4739-1-dmitrii.bundin.a@gmail.com> <20220811145828.89b64e663a18fbb8d7fdea06@linux-foundation.org>
In-Reply-To: <20220811145828.89b64e663a18fbb8d7fdea06@linux-foundation.org>
From:   Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Date:   Fri, 12 Aug 2022 03:33:29 +0300
Message-ID: <CANXV_XwZBov-QHxcbFqt9y4dwQyZ_umjzZep=RbZmE8RRz9Bag@mail.gmail.com>
Subject: Re: [PATCH] kbuild: add option to set max level of debug info
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     masahiroy@kernel.org, michal.lkml@markovi.net,
        ndesaulniers@google.com, nathan@kernel.org, peterz@infradead.org,
        keescook@chromium.org, jpoimboe@kernel.org,
        dan.j.williams@intel.com, isabbasso@riseup.net,
        edumazet@google.com, vbabka@suse.cz, linux@rasmusvillemoes.dk,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> In other words, can we make this a Kconfig-selectable level, with the
> default `1'?

Thanks for pointing this out.

Here is a little note from my side. According to the GCC documentation
the default level is 2. So I would propose to set the default Kconfig
option value to 2 as well to not change the build behavior.

Does this sound reasonable?

Regards,
Dmitrii
On Fri, Aug 12, 2022 at 12:58 AM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Fri,  5 Aug 2022 01:35:04 +0300 Dmitrii Bundin <dmitrii.bundin.a@gmail.com> wrote:
>
> > When compiling with -g3 option and debugging with gdb it provides some
> > extra abilities like macro expand, info macro etc... It's sometimes
> > useful to unerstand behavior of complicated macros.
> >
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -304,6 +304,15 @@ config DEBUG_INFO_REDUCED
> >         DEBUG_INFO build and compile times are reduced too.
> >         Only works with newer gcc versions.
> >
> > +config DEBUG_INFO_MAXLEVEL
> > +     bool "Maximum debug information level"
> > +     depends on !DEBUG_INFO_REDUCED
> > +     default n
> > +     help
> > +       Sets the maximum level of debug information compilers may generate
> > +       (-g3). Enabling this option will require significantly more disk space
> > +       and increase built time, but it's useful for debugging purposes.
> > +
> >  config DEBUG_INFO_COMPRESSED
> >       bool "Compressed debugging information"
> >       depends on $(cc-option,-gz=zlib)
> > diff --git a/scripts/Makefile.debug b/scripts/Makefile.debug
> > index 9f39b0130551..7e1d8beecfc4 100644
> > --- a/scripts/Makefile.debug
> > +++ b/scripts/Makefile.debug
> > @@ -2,6 +2,8 @@ DEBUG_CFLAGS  :=
> >
> >  ifdef CONFIG_DEBUG_INFO_SPLIT
> >  DEBUG_CFLAGS += -gsplit-dwarf
> > +else ifdef CONFIG_DEBUG_INFO_MAXLEVEL
> > +DEBUG_CFLAGS += -g3
> >  else
> >  DEBUG_CFLAGS += -g
> >  endif
>
> What happens when the gcc developers add -g4?  Or if a user wants -g2?
>
> In other words, can we make this a Kconfig-selectable level, with the
> default `1'?