Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030692AbXFHOa2 (ORCPT ); Fri, 8 Jun 2007 10:30:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S969163AbXFHOaS (ORCPT ); Fri, 8 Jun 2007 10:30:18 -0400 Received: from ug-out-1314.google.com ([66.249.92.172]:19810 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968873AbXFHOaQ (ORCPT ); Fri, 8 Jun 2007 10:30:16 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=pAGEocK5oKrbiF+iIZilxX1anBG3n8KrPGryLVK+uJAkJR1D0nJs6kn0L6z0Dm91sO8eCoh21b7vQdZAeVQ106gKM/+ZtXreiLIWQ8h/PxG11qelqsz830olCjaxLSCONaKGIFc1iE7SqgtaNw5w1Eo26mou8Xh+A04tslXc/Ww= Subject: Re: Add INPUT support to toshiba_acpi From: Richard Hughes To: Dmitry Torokhov Cc: Matthew Garrett , Bastien Nocera , John Belmonte , linux-kernel , linux-acpi In-Reply-To: References: <1180614979.2693.26.camel@localhost.localdomain> <1180788652.2355.27.camel@localhost.localdomain> <20070602142333.GA3452@srcf.ucam.org> <200706030048.40393.dtor@insightbb.com> <1181235539.2610.72.camel@work> Content-Type: text/plain Date: Fri, 08 Jun 2007 15:30:16 +0100 Message-Id: <1181313016.2499.51.camel@work> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 (2.10.1-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 43 On Fri, 2007-06-08 at 10:23 -0400, Dmitry Torokhov wrote: > On 6/7/07, Richard Hughes wrote: > > On Sun, 2007-06-03 at 00:48 -0400, Dmitry Torokhov wrote: > > > > > > > > > It looks like KEY_COFFE comes from 0x0c/0x19e - AL Terminal > > > Lock/Screensaver > > > so your interpretation is indeed correct. I guess I better add an > > > alias to > > > input.h > > > > What's the status of this patch? Good for merging? > > Not my call - John is the official maintainer of the driver. However > from input layer POV it looks good. Good, thanks. > > Do you want me to > > redo the current patch using input-polldev > > The patch I send to you earlier already does this. I am attaching a > refreshed version that used KEY_COFFEE instead of KEY_BREAK. Brilliant, these look great. > > and the new setkeycode stuff? > > And I have the patch doing this as well (attached). If you could > please give it a try I'd appreciate it. You beat me to it {hastily removes item from TODO...} :-) I'll give it a try as soon as possible, thanks. Richard. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/