Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Saurabh Sengar <ssengar@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, decui@microsoft.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-hyperv@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        ssengar@microsoft.com, mikelley@microsoft.com
Subject: Re: [PATCH v2] scsi: storvsc: Remove WQ_MEM_RECLAIM from
 storvsc_error_wq
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1lerukxjs.fsf@ca-mkp.ca.oracle.com>
References: <1659628534-17539-1-git-send-email-ssengar@linux.microsoft.com>
Date:   Thu, 11 Aug 2022 22:25:52 -0400
In-Reply-To: <1659628534-17539-1-git-send-email-ssengar@linux.microsoft.com>
        (Saurabh Sengar's message of "Thu, 4 Aug 2022 08:55:34 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v0X3HT9ithrdH2rEFPyvUqPw2XvPlEIuVjq3qiA3umO5DcJC3u0/Dqo4bLHC?=
 =?us-ascii?Q?J9eH0U7RD9Ql2iMndbiy62Jg2rveWKf2Bm+gnwMMQ7kdHMTLvJ4QU8uV0FSK?=
 =?us-ascii?Q?AyFQ1DAC5rSPIUOWQd0IJqYHPgTyb2lzbhUoAe0btprsCJjnpoA+9bSNQAyH?=
 =?us-ascii?Q?zzeMAPtDuGqnnEjpI+6xlC8Jgsmzr16rXkFMNBhLqE5zy2ZaxvYtoJLAQqpR?=
 =?us-ascii?Q?DlXGQNS8dIj4bobiIWASqBWEMuZIlmymIHlgDtp64Et1ZD/lI3JW4vOkoHbd?=
 =?us-ascii?Q?R1nJtS0xfNACWfD097WLO81ufHfDNF8O+BysZ5UMnvdIodqrjSab1a7A1Akg?=
 =?us-ascii?Q?ed+wDEQPXYOtOzzBNxOG+NUK5OCUHJA4jNo86+ng8LcdwScm1s1MZucovmkn?=
 =?us-ascii?Q?xL28NrOqQo9oSBhjtCHIY64q/GScI7J3oAqg5Eo41gasQzU0iR7X2He+Ms5Z?=
 =?us-ascii?Q?6yEcuL28Vtl1+zrYCI1GrFaqtcq6obaiXq8hbu6I0onn9sw9iS1n1Q6y2CkI?=
 =?us-ascii?Q?hrxQ8JznI8eT0Nm4wzeNH/to285a1FuD4zz+T3Jr1vaLa85hdvlEr/54Ii3v?=
 =?us-ascii?Q?fSEMXF+3LWzxcZfhP+m9NINaNiO/nO5okRB/VYsFPtLPgPVM+pMoJyhXTBAD?=
 =?us-ascii?Q?b7YEU+F9nFHOYlSu7Z4P5MIioOizIeWTkrWrEpORgnx44JvAZtVh3bNkpaD3?=
 =?us-ascii?Q?dnARCQPQGVuSfjZ9vGFUyvUYEwhpOKZ5YnFFS6yJvYUkyxboYbpHg0+g6XB2?=
 =?us-ascii?Q?5O4wqWRDAQcxOQPq23iny217mESdIbl643DteUSMrzinTcfFTIU8yrtOB9zD?=
 =?us-ascii?Q?Oz+fI8uS/q8zefnbuLSo09jDzOESJdvI7Jx+BEL3a+HgotnBexyZeGQBYX1o?=
 =?us-ascii?Q?Me3zmeS2lVy8nZUz2fYULrwkyMcAx2iBE/xEQuZNmFCpt6b0xo7YR6DiKbiz?=
 =?us-ascii?Q?68hrT/FDJWsJM5b8ZPYdOlTjRbunxD8dMTqnumsjeaHqjhuoUYph6wleffiS?=
 =?us-ascii?Q?tn2Yo4Jjlt/q1wD9eAiTWDpCiZ2SRjcIF1l8ORKnSHTdnpkx5k/vHaKrOaVR?=
 =?us-ascii?Q?TV/LcqvLoX60XMw+iSPhy6RHNDMPXuxV/Cce5S75QzxKrCU0U3xCE5nbQG3r?=
 =?us-ascii?Q?Hi98tWVBii4XdtoxectZmd3nIoKHnh+y9JokDs1G5Ma5puCTfsMw4yVH5drR?=
 =?us-ascii?Q?QdkFxJ93yysTaLJKC1oUmNudEyyjBiOpl0+v6tKyoHRNzMu/060SM3Pwztn8?=
 =?us-ascii?Q?AhJBykRU/43T9wN9kJAH3ORUCdblFFk0+79pI4jWFakiHxluEWBGifnHiPoU?=
 =?us-ascii?Q?ryZZrWexIjOAgIRjcl3/q5fiiV85Cih4eEcQlDRRIYzPBl26jj8nycjUZwX8?=
 =?us-ascii?Q?T2hQwRDMI0Ly+RGOaLEuIXQjSA/v/n1k3V/KbvnYTGn7LDFSYOsPf0Ohqv3F?=
 =?us-ascii?Q?1i6ok5ysZ6QRCUURthHCzgHoBsK0ckEJZIRikvqpB6NEVtfzS9hdnMbq4AJK?=
 =?us-ascii?Q?OwGL8L8cOUTQDQduEXH/ugnC1F7QP//ljim7XeTFX3ntDeKhnB7mSYsJQ/q+?=
 =?us-ascii?Q?CmHC3FKvu3TcLhjGXA/huwfPoToiNEDn1+L8MS4OeNrCZu/xfttRxSTWtkXF?=
 =?us-ascii?Q?RQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?7BWlqQ5J0c3AMWO6eJ201jQffeX8+bfea17RZmbDxV1tS6VyU1ZVKnoQ+Ksa?=
 =?us-ascii?Q?8kpvBjBnu2wTfRtjAy0S2JI7sb5OaCcU2F4LeJpMRlPlsGjC/MZyFysJLTUC?=
 =?us-ascii?Q?nlE9XfYGakDkeybVFLnacRBEWgpazypYbsI6JBnvW8auKfCVNgrglqbqjBoS?=
 =?us-ascii?Q?abFp4DRmu3bf+Qq/kLpc7CQ+iKRU5cfq5y9+GM6NGslu7hX+H1qHoyhNmxJz?=
 =?us-ascii?Q?+j6hqKlo2sSsYp6C218npBMOu5L7Hird52b9FaLVNuvc5C4RnpV/ESuOuCaG?=
 =?us-ascii?Q?PVPBb57ufCTcfPb54PUecXZbn59iE5jKINyUZkr9Qug/d/zijPtPUOuG+zyy?=
 =?us-ascii?Q?hBVRL8d7B7E1JqIzcOPX3VcJ8vNRcb8Cd40plEccmtZaCsNtMHT9k4oFhYR/?=
 =?us-ascii?Q?uOSMyWW7PZK2quqxHbXIJJpQczYyOM4mq8DP3fvde3PD7zPGabV/IYsxXjUv?=
 =?us-ascii?Q?OrWPGfqGtKNhdNr73cRLgIThJ07AaOpakjN2paxgl5l/uu0QrDH77+RtPRIq?=
 =?us-ascii?Q?oDZsxy1KV/mJQ2p4xc/pMLFuNssvHwlxifpe1H380QYDnvhzwQyHHuXAGe+v?=
 =?us-ascii?Q?21eHsETEXcfrYOGcGx+dLuYbCYjEViWOVwrNgpQF1opOMLuZzifMbKblc2g8?=
 =?us-ascii?Q?6mHpYqR5H8MSW6lL1ULiE39ytvZh2djwr2rIom1Y5WDHObQDSxo3ysgYgvs0?=
 =?us-ascii?Q?kWe7hzQNbYfP2kgDxjHaD1csD32atxpkn1QrYf5qRgVeGeqTBRNNUOfKdHcM?=
 =?us-ascii?Q?ocNMYsuUrbdEnkjPRfe1G7MD7F0JRAFNSJzOcqnqgCl8OGuKddmfNGStvRRk?=
 =?us-ascii?Q?GL0Lv+K0jeMSW2qnyQ7uq+pE+V5yJpB/qwR9aIQXnMoAH8id2tk/gZ3KTE9D?=
 =?us-ascii?Q?mSayw0VUPWJ1zHyCucQ57CEugo1m1M7ajN4um65mZFioVhBPwSOzMYR5zwhp?=
 =?us-ascii?Q?rjk4AMFKpGBlKmEmGQOJXIqDhZAG7pSrzhL50FEv+FrN9CbEG2oq90gyKHS4?=
 =?us-ascii?Q?j7uU+ksFwUoEvWefFXmfp1F1JKR44WQ9Usi2huHff1XLa+lgcm9OFmXa9iOV?=
 =?us-ascii?Q?kUho7Rs4hlbiey0AbFaMyn2Nv4ypNBjnva49GcxUXG9ImOTlLPEGSKmA28TP?=
 =?us-ascii?Q?AtkX2UTb9e334bS6TvIc4BtpUKupVjkYVPlCX4V2QkdFv4tZSd3y11doB1Aj?=
 =?us-ascii?Q?I0Xl0v9xq0YT13KbrhArRblCc8KXZV4bUOe6E3WwTSMRHlYPeakyJIslxOqc?=
 =?us-ascii?Q?Ad8WCOm2urE4jo2+ctZjYG4JOVk3AYlxATNGpl7uexcd4E1lv5knjYjRtozx?=
 =?us-ascii?Q?sHobAZvNIGpYhEMqVfDa/Jy0cuaG7bLiYBqrI9/a2AbiYaW76PXbFl7Rm4vw?=
 =?us-ascii?Q?Ze0aGOYOXpMvhei/pykN9i6Ji9rL?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18ff356a-7737-4304-26fa-08da7c09fb6b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 02:25:54.2718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JF5To2rC5pZ1tox/XOMe3/wvsGyoaalHsHdliZpqY09S7SF4MonUBVFbRbo3WqZ2+ZGXM4a4/C9DsT7X6xQjbIxhSEG3/9hKuxktOFbbikU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5331
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-12_02,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0
 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208120006
X-Proofpoint-ORIG-GUID: trOPErb-LagYgEAVjID2YO8Jtwn_OYAy
X-Proofpoint-GUID: trOPErb-LagYgEAVjID2YO8Jtwn_OYAy
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Saurabh,

> storvsc_error_wq workqueue should not be marked as WQ_MEM_RECLAIM
> as it doesn't need to make forward progress under memory pressure.
> Marking this workqueue as WQ_MEM_RECLAIM may cause deadlock while
> flushing a non-WQ_MEM_RECLAIM workqueue.

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering