Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Haiyue" <haiyue.wang@intel.com>
To:     Miaohe Lin <linmiaohe@huawei.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Naoya Horiguchi" <naoya.horiguchi@linux.dev>,
        David Hildenbrand <david@redhat.com>
Subject: RE: Linux 5.19 __NR_move_pages failed for hugepage
Thread-Topic: Linux 5.19 __NR_move_pages failed for hugepage
Thread-Index: AditV6ayifgPLLrQT++lwJgko5ZyagAl3dUAAAFiRDA=
Date:   Fri, 12 Aug 2022 03:04:56 +0000
Message-ID: <BYAPR11MB349577B5D98EF6748CDE8873F7679@BYAPR11MB3495.namprd11.prod.outlook.com>
References: <BYAPR11MB3495837E180867B47E551EFCF7649@BYAPR11MB3495.namprd11.prod.outlook.com>
 <d3966b09-ce41-9e92-e676-262e84b8e2e1@huawei.com>
In-Reply-To: <d3966b09-ce41-9e92-e676-262e84b8e2e1@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+60OD0l4ovOYA7gS77weMSaktUXOG3IB81ugzdDCdXNYCKF+NUC4QP8OHUSk?=
 =?us-ascii?Q?3if9jiuUBiiiZ7jNU5tmY7Frx21zetqxTFPFMDEeepcACSyF3mTQmExMtmiv?=
 =?us-ascii?Q?jo/XBS8jY4XLq5poYd9F78+6sDjKGBsiDEKgLBG6tzhR005U5uAzFNnepcCO?=
 =?us-ascii?Q?XDcuOR+YgMm/La7qQ5YAR6sG2qK53p8/+9tad0cXG+mv7QLNe0GSkcPL0IJJ?=
 =?us-ascii?Q?WAftG1c830i5+d7qC4Op6Nj35V76p6zwkmIhWVRaZgIP3xwpPD0RPc5k+2Qn?=
 =?us-ascii?Q?VAP7wP/VR2wY+v6f7AZ43M6yI+zcQ8/X3uJN/K6WFSl62+zvR39Sz3y5riZL?=
 =?us-ascii?Q?zLgV2yKCWGsMHtn6lgqck5D+XZZfHLcnQFt1s0ZmZsq8WhRjPd3Gqa1CYD9A?=
 =?us-ascii?Q?xY7Vu33OlByBQmO9kmVjWyY9cqZ54LCGkZz1YuK1NlI0hbWCcIFNzA2vtvUd?=
 =?us-ascii?Q?zp4LDLniZndd5rLmY203KZaR/hBPn47rNy5n5f9KFkIffe7F3OJ9Hg1ROk4n?=
 =?us-ascii?Q?B/YNgt2BIGJvpxImqSvFUdhwoaWYPmBX7V4NfhoeEmn4Rqup0xsL5ATcmGph?=
 =?us-ascii?Q?VnB8L17X+pA+YQnZZKFTeY0nK3U5MFyePd1/LCrEDXzNDNh2W6CXD1qYzo/h?=
 =?us-ascii?Q?d4QX5EAOuXF210++R4lqlVo9NVkqiRpZ3aKnYwwdUR6kjrzt/IlB7lhj1c88?=
 =?us-ascii?Q?fZqCHd5svbM1Wr1ijeWCebl3rYPPdLNb5m2UJvkXs+zkCqbrNT/9SGTkGYQN?=
 =?us-ascii?Q?BV72hXgo2jpPlhDXZJJkq4vRWnJ5trOxyvacTSEyhUTqHRpYrE/AtqdeIeLV?=
 =?us-ascii?Q?VofgMP2hVVneMBcz+k8MT5Qoir+P3XBfqpgsq+EMlh+iaRKw+ff2yvHDChDo?=
 =?us-ascii?Q?tQoLUGGoGavpCy8prmIjkGOoHLVtSva3iijoIXP8HNXi6GHQNuGmBvEWfSB1?=
 =?us-ascii?Q?0BVvccBRa8axqvlBhdZknizhe1Kra9zzxAoBTL9fpCGB0qy2Vtl7JxQe/P2r?=
 =?us-ascii?Q?eal7ulmNPv8QA/OAmofvbRd52hV4fs3WcfVitztS/OulHUzoVhbBTFWmZhJx?=
 =?us-ascii?Q?Hf2NQjYq7zkFdpv1nFAqldDGsDc06GvXhv4A/7+aO3onSkaVQM1AEnVtO8Wu?=
 =?us-ascii?Q?2MYKkCEZhnpdeM3dWDbwboqMXn/PNH/BhNE++etIpp4cqcQKfMjAz3WuxEbO?=
 =?us-ascii?Q?gLOIcLmIP4ecSrfwGHQOZDawG7Hfy22iUyyuZgbTSnHWjU0tTIxG+NjcFtfd?=
 =?us-ascii?Q?DywflQV4+OGm2Ai9FFIajhLo6dgwIG2b8/KtSw2PkG4pOAcm0iRNPkpkI2ev?=
 =?us-ascii?Q?ef9UrN2m98fiNzcA2MC9sdKCDzlQTb1mTp8V94mE1exczOiReJPQlK0yOf91?=
 =?us-ascii?Q?ruTgQT70U/bQ8jJnUMcoHEw5m9A4Pe+mad1Po4tXgeVciQZJ2vpX5pDL8xYr?=
 =?us-ascii?Q?HzG0JGZO2/cBmRbqlY8WBefpJGGPQFQYR2VXe+twKnsWLKOaEyaaDVOJ1Fhz?=
 =?us-ascii?Q?XqHFJskjTN6AJ5bsG0qH8D8XdCbPgKOpbxFg1b+Zi5hor5z1wKxI/OWZvH9t?=
 =?us-ascii?Q?TOSgrff9yjSKU7UFVWXd0oXYQlg9WHU/Kb0JjOlt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87d75517-22ae-4dfa-e934-08da7c0f6fd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 03:04:56.8899
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qC1hag6BI87GGZkJKftS1n5vY5vzgT6WR51/l1wxOalQRSiw6uR/4Pgn5cu54tRJeRRrPMWS/bGyVeW+yjpGaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2994
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM,
        HK_RANDOM_FROM,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Miaohe Lin <linmiaohe@huawei.com>
> Sent: Friday, August 12, 2022 09:59
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: akpm@linux-foundation.org; Linux-MM <linux-mm@kvack.org>; linux-kerne=
l <linux-
> kernel@vger.kernel.org>; Naoya Horiguchi <naoya.horiguchi@linux.dev>; Dav=
id Hildenbrand
> <david@redhat.com>
> Subject: Re: Linux 5.19 __NR_move_pages failed for hugepage
>=20
> On 2022/8/11 16:01, Wang, Haiyue wrote:
> > Hi Miaohe,
> >
> >
>=20
> Hi Haiyue,
>=20
> Many thanks for your report and debug.
>=20
> >
> > When I call "*syscall (__NR_move_pages, 0, n_pages, ptr, 0, status, 0)*=
" to get the huge page node
> >
> > information, it is failed with '-2' returned in 'status' array.
> >
> >
> >
> > After some debug, I found that "*follow_huge_pud*" will return NULL if =
'*FOLL_GET*' is set.
> >
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/?id=3De66f17ff71772b209eed39de
> 35aaa99ba819c93d
> <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commi=
t/?id=3De66f17ff71772b209eed39d
> e35aaa99ba819c93d>
> >
> >
> >
> > This will make your patch doesn't work for huge page.
> >
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/?id=3D4cd614841c06338a087769ee
> 3cfa96718784d1f5
> <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commi=
t/?id=3D4cd614841c06338a087769e
> e3cfa96718784d1f5>
> >
>=20
> Supporting of '*FOLL_GET*' in follow_huge_pud is introduced via the below=
 commit:
>=20
> https://lore.kernel.org/all/20220714042420.1847125-9-
> naoya.horiguchi@linux.dev/T/#mb3c83df087fba454b7b4ea32227fb8775ca70081
>=20
> But that's still not perfect yet. For s390 version of follow_huge_pud, FO=
LL_GET is still not supported.
> And pgd level
> hugepage doesn't support FOLL_GET now.
>=20
> >
> >
> > Not sure you know this issue or not, just share my debug information.
>=20
> I'm not sure whether it's better to revert my above "problematic" patch f=
irst then add it back when
> all hugetlb pages support FOLL_GET.
> Or we could just live with it? Any thoughts?
>=20

TBH, the issue is more complicated than I think. :-(

Looks like only '[PATCH v7 5/8] mm, hwpoison: set PG_hwpoison for busy huge=
tlb pages' will be
backported to 5.19 ? Only this patch has "Fixes:" tag. If so, it will break=
 5.19.

I just run VPP 'https://fd.io/' to find the error message about huge page a=
llocation
after I switched from 5.18 to 5.19.

>=20
> Thanks,
> Miaohe Lin
>=20
>=20
> >
> >
> >
> > BR,
> >
> > Haiyue
> >
> >
> >