Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alistair Popple <apopple@nvidia.com>
To:     linux-mm@kvack.org, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, linuxram@us.ibm.com,
        paulus@ozlabs.org, Alistair Popple <apopple@nvidia.com>
Subject: [PATCH 2/2] selftests/hmm-tests: Add test for dirty bits
Date:   Fri, 12 Aug 2022 15:22:31 +1000
Message-Id: <8f19b172d32be2e889b837f88b1ba070bf2c97ee.1660281458.git-series.apopple@nvidia.com>
In-Reply-To: <a9daea363991c023d0364be22a762405b6c6f5c4.1660281458.git-series.apopple@nvidia.com>
References: <a9daea363991c023d0364be22a762405b6c6f5c4.1660281458.git-series.apopple@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ARSHuESIg3SAbtY/c1geWpBtnQqH8AeEUOp/ZLDukOlQ918g0zdsfEZLAtBT?=
 =?us-ascii?Q?GyuBgugUMNyzJTAxlOqnF2JidjRMsP6OWP9lsi3b5ZDx2KYJnn6/Lc9F+EU1?=
 =?us-ascii?Q?FNd/iqI2OGhWAYfBuavv5FSflwWH52V0EFE3fa8Jl8+k3xopR+yWL4BA3PHB?=
 =?us-ascii?Q?avMXaapy7xZNoEbuiLznSasr81q2xlu31PMv1ZO65GzCMWXNQziUvDDUWrfq?=
 =?us-ascii?Q?LUEOoNDvKdlosyVLdufvQCEHsO6E6Tfn6VdHXkM/Y0WeoFVmMG7Ryk7w8PhQ?=
 =?us-ascii?Q?CCuCm3pRmQr3iEwT9g4DVRhNYf7KpR+Q818b1IyWq9jO0w3k67NTtVwMZEFN?=
 =?us-ascii?Q?bVRED/JyjpR5wTIXJCyNkzqIgsu2OtP2tdIWf1YCQVmHAl11USWGuf+VF9vK?=
 =?us-ascii?Q?WBz5CDamFuuAAedFqiau6EAuzB2P6f6eUfkxqtWOP3rlHiGO7Vo+tp49mwBI?=
 =?us-ascii?Q?KDcF8YYRVnbQZIoIUVg5SyhIhIvxLcN06rR+6163+Z14HCEi5EAyN5FwXc28?=
 =?us-ascii?Q?aeQxYQ+GYS9oxSnwM55ou6BDJSOtnh282hMgSp+WpGNsGhu1YV7oLJ9Eh4Km?=
 =?us-ascii?Q?w66qZeaZXnRzVlbsHBAG2GqSAip0H03W6ER28TkvNaSMp3Yhczaa6ALS1Q/w?=
 =?us-ascii?Q?bZFInDZ4/J9yCSTcECZLHGncFaJB5wIDHDdH7dfH2V+HnF1Dt4reiFh/giU/?=
 =?us-ascii?Q?x08E+5SM7TSSEx+ly4PdXo8ZIZDuitMZuf5UPw9R/E6lfJjy2bkWWJFCLBff?=
 =?us-ascii?Q?BQFhhwxebh/3hlgl2J+ml9cPvpdMa9yUvRc3Fo/n7WDyoGTXywlwd5TtfWG7?=
 =?us-ascii?Q?r+z/+TofN+aotLFAH1RY1cavt5vswfoTNsglwPiLer64SRqJ2PNeqp5UDXFX?=
 =?us-ascii?Q?1j3tdSsYHhC7RIgdeRbcOgaUMunwTt/PjBhPsbvbSZudy9FUESzaHrFFxi/d?=
 =?us-ascii?Q?MPV8483+wRP/fRuXauB3nqgNSVrkl4QTwVMw04bBLV980iz4v4JgyRGtlPi4?=
 =?us-ascii?Q?UiFLg4t2hQvJwCU8qVyDLhkQnA3DfgyWD/OM9UKIwq8VyTnVTNv8bsuXBmsB?=
 =?us-ascii?Q?pBPIpBvJVhOFFt/uKjscDFjV3Z/myCvcFl9KC+vK/NL733XUFX3hJKz+G9+N?=
 =?us-ascii?Q?eHwI4z0YesC9IVS7NIRwtMMunUrqKtLG4cEM4uFmBM8QTgRJ0gSVmCUYocMF?=
 =?us-ascii?Q?U6tgJ/N+u+Pkwe3QyLXxCGX+aqh/lgeVI0K454XZAQHmMGgd8XA0+vEKbiMi?=
 =?us-ascii?Q?dPETiqBFBFkk8EaXVG/Uve+88f0g8mwOAdJr0m2mcWXzDyhns92LmcGWvRlM?=
 =?us-ascii?Q?Zs+sqktgzGrGXiQ8gSiSBFTTaEBsmoMbzpzyFpI3J23/u+j+FODFwOcPkioL?=
 =?us-ascii?Q?oEZfjZ4rMcgv2TkD6WaWlSojIxWkE9zNbduHRWnh5OcWMJzdCsoAxaaWnhcI?=
 =?us-ascii?Q?GhY69JWVecPzZdQ8L7pGJN1t0ySzfv6urFuIYonbtWTN3NHSJee3RVbxhXjj?=
 =?us-ascii?Q?iJ8al/bVzjIEJ3bMk116fwJ2H+K7iW0h5sVQ1fz7FoNRAUNNqzPouFVBdKbe?=
 =?us-ascii?Q?3WQrIHclAICoPH2sePTVIk5wmZmwp78frQGqPygd?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e0cf9f9-0ff2-41c8-56e3-08da7c22c810
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 05:23:25.4686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +QM3/thaEV5+TmkPKdEnM0UHNs58xRz8d3bCJdlIsSSyeGBY0yOjk8jNRL3WMtN+TjZ09gvJdmopbuXJcRNrEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3978
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We were not correctly copying PTE dirty bits to pages during
migrate_vma_setup() calls. This could potentially lead to data loss, so
add a test for this.

Signed-off-by: Alistair Popple <apopple@nvidia.com>
---
 tools/testing/selftests/vm/hmm-tests.c | 124 ++++++++++++++++++++++++++-
 1 file changed, 124 insertions(+)

diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c
index 529f53b..70fdb49 100644
--- a/tools/testing/selftests/vm/hmm-tests.c
+++ b/tools/testing/selftests/vm/hmm-tests.c
@@ -1200,6 +1200,130 @@ TEST_F(hmm, migrate_multiple)
 	}
 }
 
+static char cgroup[] = "/sys/fs/cgroup/hmm-test-XXXXXX";
+static int write_cgroup_param(char *cgroup_path, char *param, long value)
+{
+	int ret;
+	FILE *f;
+	char *filename;
+
+	if (asprintf(&filename, "%s/%s", cgroup_path, param) < 0)
+		return -1;
+
+	f = fopen(filename, "w");
+	if (!f) {
+		ret = -1;
+		goto out;
+	}
+
+	ret = fprintf(f, "%ld\n", value);
+	if (ret < 0)
+		goto out1;
+
+	ret = 0;
+
+out1:
+	fclose(f);
+out:
+	free(filename);
+
+	return ret;
+}
+
+static int setup_cgroup(void)
+{
+	pid_t pid = getpid();
+	int ret;
+
+	if (!mkdtemp(cgroup))
+		return -1;
+
+	ret = write_cgroup_param(cgroup, "cgroup.procs", pid);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static int destroy_cgroup(void)
+{
+	pid_t pid = getpid();
+	int ret;
+
+	ret = write_cgroup_param("/sys/fs/cgroup/cgroup.procs",
+				"cgroup.proc", pid);
+	if (ret)
+		return ret;
+
+	if (rmdir(cgroup))
+		return -1;
+
+	return 0;
+}
+
+/*
+ * Try and migrate a dirty page that has previously been swapped to disk. This
+ * checks that we don't loose dirty bits.
+ */
+TEST_F(hmm, migrate_dirty_page)
+{
+	struct hmm_buffer *buffer;
+	unsigned long npages;
+	unsigned long size;
+	unsigned long i;
+	int *ptr;
+	int tmp = 0;
+
+	npages = ALIGN(HMM_BUFFER_SIZE, self->page_size) >> self->page_shift;
+	ASSERT_NE(npages, 0);
+	size = npages << self->page_shift;
+
+	buffer = malloc(sizeof(*buffer));
+	ASSERT_NE(buffer, NULL);
+
+	buffer->fd = -1;
+	buffer->size = size;
+	buffer->mirror = malloc(size);
+	ASSERT_NE(buffer->mirror, NULL);
+
+	ASSERT_EQ(setup_cgroup(), 0);
+
+	buffer->ptr = mmap(NULL, size,
+			   PROT_READ | PROT_WRITE,
+			   MAP_PRIVATE | MAP_ANONYMOUS,
+			   buffer->fd, 0);
+	ASSERT_NE(buffer->ptr, MAP_FAILED);
+
+	/* Initialize buffer in system memory. */
+	for (i = 0, ptr = buffer->ptr; i < size / sizeof(*ptr); ++i)
+		ptr[i] = 0;
+
+	ASSERT_FALSE(write_cgroup_param(cgroup, "memory.reclaim", 1UL<<30));
+
+	/* Fault pages back in from swap as clean pages */
+	for (i = 0, ptr = buffer->ptr; i < size / sizeof(*ptr); ++i)
+		tmp += ptr[i];
+
+	/* Dirty the pte */
+	for (i = 0, ptr = buffer->ptr; i < size / sizeof(*ptr); ++i)
+		ptr[i] = i;
+
+	/*
+	 * Attempt to migrate memory to device, which should fail because
+	 * hopefully some pages are backed by swap storage.
+	 */
+	ASSERT_TRUE(hmm_migrate_sys_to_dev(self->fd, buffer, npages));
+
+	ASSERT_FALSE(write_cgroup_param(cgroup, "memory.reclaim", 1UL<<30));
+
+	/* Check we still see the updated data after restoring from swap. */
+	for (i = 0, ptr = buffer->ptr; i < size / sizeof(*ptr); ++i)
+		ASSERT_EQ(ptr[i], i);
+
+	hmm_buffer_free(buffer);
+	destroy_cgroup();
+}
+
 /*
  * Read anonymous memory multiple times.
  */
-- 
git-series 0.9.1