Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1434676rwb; Fri, 12 Aug 2022 00:22:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR4i0xO+rJNLe2sfzQk46RK9rD7HlRwWik4GFObVx5KTdAMAkQsKSUvw0fVVA45u874sjK43 X-Received: by 2002:a17:906:2bc7:b0:72f:dc70:a3c6 with SMTP id n7-20020a1709062bc700b0072fdc70a3c6mr1832345ejg.645.1660288962427; Fri, 12 Aug 2022 00:22:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660288962; cv=none; d=google.com; s=arc-20160816; b=KEvXOychXcKbBucPvk5lHa9FpzTDFAyS4gcm1emy+K6sNhtOAlDmsgf9V1TIS2X7XB 0va16gRihVdEYBtnqVmWIwfWr8b8OGIKzz4qJpQVuMgpBQ5oh7MBCNYp834U0htgPrR6 vh4tOVL7QU8W3W/EYY7u4tCHzgEyvPc/15dLRgU4NUgSTJVZq83ySUTJWA+Q84Wqn4Z9 7VgdVhFotx1SnOYULKDDnFVgAY34+N0hfXGvh6WYzx0hYNHb4HiKPTh3tk5m0vUcYH2F Cb7vin3lLnrVH0HjH/MBq2438usqsa3oK4/P+I+464/9i7fsjtP6wIvVocuVle80Urbd RdBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=X58woYhmoNM1HQrhJVZVAT6NOOv59QnJ1JBh5o+mV8U=; b=qoIJKL6htvCK0nnX6OBpR8ouMXKXWM9NT1KDnTp6prWJJXZBPVZLgD+XGeFRviW42z tw+t59AMYa8ks2vrkOnmRG528abzoUr/T/nW4hh/Qc9KT3eVefQwQBmtbMgSHdF7Qivu yVX3GTeWkB8LicdJnTTJQD0FehJ6jIxQpY0l6AZWw3UbWkNafuBObOfNxoSwdimsWPib G2lfwAFEpwf1pxHLSDdloB6DM/vdq1ywkiH0OiJ4ikVZmBNBOvdCSMuRriHceLuEYgia QFCzC+YiDqM32jOY5d2sxFPvLSSFBzBowKRZc8hUdQUtXdBJkM3yIsn8S8qoGB0aRY7K ZpXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kf18-20020a17090776d200b0072a87876c99si1279814ejc.495.2022.08.12.00.22.16; Fri, 12 Aug 2022 00:22:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237293AbiHLGkH (ORCPT + 99 others); Fri, 12 Aug 2022 02:40:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbiHLGkE (ORCPT ); Fri, 12 Aug 2022 02:40:04 -0400 Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8859C218; Thu, 11 Aug 2022 23:39:56 -0700 (PDT) X-QQ-mid: bizesmtp84t1660286371t6z6a0wm Received: from localhost.localdomain ( [123.114.60.34]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 12 Aug 2022 14:39:29 +0800 (CST) X-QQ-SSF: 01400000002000D0T000B00A0000000 X-QQ-FEAT: ALw5QuVtm4Wbl5eB3SFm9PpWuGQ3MocdyQreJyY80BQcn6hBdDEsUfKfOwVZb Mx9l/KtOx0t8f5oqJ5uWmmG9QxZzLGutfze3geRuOzpFWt3qjXEvROY0raNPPdQMeOAcY7P pmyKnjV3saGfnXHRaph22MJG145LbWRRmXfQCQIS71iMKR6TtRK/YK7PNBlW1ZG6LLEd6tm W60Ctvngp7W2uxVZ4lDvFfz0/AAa3yUOL2jEQtsXkMznLSwo0RH+RDd9RGrxsSoaI5iQPuX hQFxOfo/ISrjf+pUPM/e9WlcC3MpLHuStjYxjF/maz5JL2CoTdsUeEIEpRo4OpTv55wbzrH 2M9OPkianqZOXdgrOyXje2iwdRMzzLfQgZsh/vCQL+aVF8WlXlxXNOE4dEeI/9yVr23QfHx X-QQ-GoodBg: 2 From: zhaoxiao To: support.opensource@diasemi.com, rafael@kernel.org, daniel.lezcano@linaro.org Cc: amitk@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, zhaoxiao Subject: [PATCH] thermal/drivers/da9062: Remove unnecessary print function dev_err() Date: Fri, 12 Aug 2022 14:39:26 +0800 Message-Id: <20220812063926.12924-1-zhaoxiao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Signed-off-by: zhaoxiao --- drivers/thermal/da9062-thermal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-thermal.c index 180edec34e07..7dcfde7a9f2c 100644 --- a/drivers/thermal/da9062-thermal.c +++ b/drivers/thermal/da9062-thermal.c @@ -248,10 +248,9 @@ static int da9062_thermal_probe(struct platform_device *pdev) jiffies_to_msecs(thermal->zone->passive_delay_jiffies)); ret = platform_get_irq_byname(pdev, "THERMAL"); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to get platform IRQ.\n"); + if (ret < 0) goto err_zone; - } + thermal->irq = ret; ret = request_threaded_irq(thermal->irq, NULL, -- 2.20.1