Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1485963rwb; Fri, 12 Aug 2022 01:30:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Y3I+Nux/e/3k2UWXUx5dWSSdK8KeNbp8xH6mQfzE3XOY0E5Cj8VsykUDIwp0bD7a4N+Xn X-Received: by 2002:a17:907:a428:b0:730:aee3:2da7 with SMTP id sg40-20020a170907a42800b00730aee32da7mr1880315ejc.613.1660293059388; Fri, 12 Aug 2022 01:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660293059; cv=none; d=google.com; s=arc-20160816; b=kO6Nb2DTxWG7XGFqOV710tyFEy1z406x7duC7eaXUgcgcQdM81x9jRar2FFqaOCtVu EF+33uhwBZ8HJYI9xU3ZCosdhvCPtKA7dokOKHguxx2UnVPwCAT9PAqM2+Cm0VN/kGUu O8avzOB+51Fng8Q0vuOf9p+mw9zZ5DSpFJJTOForwifnIVDx28b2zhzCu1w90SR+RLHI sK8GiH7dc/8t9qV1GxoyX7B1vwVJMCcFcDa9UHmYHuyl36Ux6LZG9bhpDlolObhU1+lG vI2T2UorqtxK1sVkTeBmN7r0wdl5fFEzN9YHnnGXgm8SP5IF6DhhhHhX7vzdoMLWekTi 3/Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nmbAxGSz0nfEZBst3j9kqs3YCEVr0RBEuyo9uhx6QzY=; b=L9F/cEQD2McEqdssJaLFpldSX4hsYULz5nE0FlMweHUjqIHA9vtAK0CoD2z0MtR1DX RZ4TENYFv16CUhvJVzZlFNMucFOmMv5Rxi1aAit4/umQCyRmPSxCNC+X7sn/Q/hjh5oz YdLYo9mT0+jxWaUgo6swpdz4Jrqcj2PGeIMfMIgET6Ok/PmH4UWj5H/xuRnsZCVCGzlG KrunNNF99E5cW9UfcZnModOv9A9D+VBu0Z0pl+0qW4xDZt1wdTP/zEaV79eTUoA5jJiN Q81hq4NucGzTZnu++EYULSGjLnA6lPyymgtAWPfhtjPdEQ5OwR0V5+duZ0dE5T76HE8e Twzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IXGP1rYB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hh6-20020a170906a94600b0072b580c899dsi1221089ejb.71.2022.08.12.01.30.31; Fri, 12 Aug 2022 01:30:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IXGP1rYB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237319AbiHLIVI (ORCPT + 99 others); Fri, 12 Aug 2022 04:21:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230033AbiHLIVG (ORCPT ); Fri, 12 Aug 2022 04:21:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F71BE1A; Fri, 12 Aug 2022 01:21:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9CF3BB82251; Fri, 12 Aug 2022 08:21:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E563C433D7; Fri, 12 Aug 2022 08:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660292461; bh=uAdZ2mX9autS/TPR3fwjWPumvc0LXFJUv+fe7PHSj5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IXGP1rYB3XPG3JK+tTB4qp9MTOdoPA+XUGl1ueCLJaBe7UQGhA4fk9gJpsUCOTR90 GXEGs/Pr/rhCcgoW0Fz61plmIqrwiE0dCbtHTOvClIiHWKXYdpukSiVejlbYv+V/nR 5y668gf1B2AiKQqBMgwZXTOmZ/S+CfjOhtbX6CYqZ2pHYSNriai3gmaC99TNTEKWgF SC6Z0TYJOgadBtiLWQS2EE4HHHaj240DZh8TZho9AKlKxoQDgMx5UmFSUJrQFPnTEt tyhYP2gLWArYX8S9nnLzbebo+Y7bgk+rXIAeqvAZWca1VvqKJpdptpv5BxJLDp8sH8 f5a+hZ9T4a80A== Date: Fri, 12 Aug 2022 10:20:56 +0200 From: Christian Brauner To: Hugh Dickins Cc: Andrew Morton , "Darrick J. Wong" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/shmem: tmpfs fallocate use file_modified() Message-ID: <20220812082056.2khjud7dme3yc6nn@wittgenstein> References: <39c5e62-4896-7795-c0a0-f79c50d4909@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <39c5e62-4896-7795-c0a0-f79c50d4909@google.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2022 at 09:55:36PM -0700, Hugh Dickins wrote: > 5.18 fixed the btrfs and ext4 fallocates to use file_modified(), as xfs > was already doing, to drop privileges: and fstests generic/{683,684,688} > expect this. There's no need to argue over keep-size allocation (which > could just update ctime): fix shmem_fallocate() to behave the same way. > > Signed-off-by: Hugh Dickins > --- Looks good to me, Acked-by: Christian Brauner (Microsoft)