Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220726174525.620-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220727153738.GA2696116-robh@kernel.org>
In-Reply-To: <20220727153738.GA2696116-robh@kernel.org>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Fri, 12 Aug 2022 09:47:50 +0100
Message-ID: <CA+V-a8t2LJ1qSsJWK4S-434cLfp0AuqkSKLjk7VgtwrMrNr2SA@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: clock: renesas,rzg2l: Document RZ/Five SoC
To:     Rob Herring <robh@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob,

Thank you for the review.

On Wed, Jul 27, 2022 at 4:37 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Jul 26, 2022 at 06:45:25PM +0100, Lad Prabhakar wrote:
> > The CPG block on the RZ/Five SoC is almost identical to one found on the
> > RZ/G2UL SoC. "renesas,r9a07g043-cpg" compatible string will be used on
> > the RZ/Five SoC so to make this clear, update the comment to include
> > RZ/Five SoC.
>
> It's either the same part or it isn't. 'almost identical' doesn't sound
> like the former. Unless it's the former, it's a nak for me.
>
It's the latter.

> Litering the drivers with #ifdef CONFIG_ARM64/CONFIG_RISCV is not great
> either. That's not great for compile coverage and they have nothing to
> do with the architecture.
>
Geert any thoughts?

Cheers,
Prabhakar

> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > Note the driver changes [0] have been already queued for v5.20.
> >
> > [0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/
> > 20220622181723.13033-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> > ---
> >  Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml
> > index d036675e0779..487f74cdc749 100644
> > --- a/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml
> > @@ -24,7 +24,7 @@ description: |
> >  properties:
> >    compatible:
> >      enum:
> > -      - renesas,r9a07g043-cpg # RZ/G2UL{Type-1,Type-2}
> > +      - renesas,r9a07g043-cpg # RZ/G2UL{Type-1,Type-2} and RZ/Five
> >        - renesas,r9a07g044-cpg # RZ/G2{L,LC}
> >        - renesas,r9a07g054-cpg # RZ/V2L
> >        - renesas,r9a09g011-cpg # RZ/V2M
> > --
> > 2.17.1
> >
> >