Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        Stefan Assmann <sassmann@kpanic.de>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net] iavf: Fix deadlock in
 initialization
Thread-Topic: [Intel-wired-lan] [PATCH net] iavf: Fix deadlock in
 initialization
Thread-Index: AQHYq1CTzhNOgMwenkWTZUFv8x+wia2rDYhQ
Date:   Fri, 12 Aug 2022 09:59:01 +0000
Message-ID: <DM8PR11MB56218E84938884F39FA2BB69AB679@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <20220808175845.484968-1-ivecera@redhat.com>
In-Reply-To: <20220808175845.484968-1-ivecera@redhat.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y3VD3WQNOpAbvJtw8MdbSxcgFGrwF1dqa84NuojLd+Y86nDQ3Kt9sjoJCvhb?=
 =?us-ascii?Q?y9SDQ5FrFTFfAu3qU/12ojZuflntyyJDqGHVSaZzWvuF1SireXYQYndkQUHk?=
 =?us-ascii?Q?coZB1peI0oMJDJV0oxo2an8K6frtn1HVefZDMhAsCyeIgrpWptDw/Dga1CGO?=
 =?us-ascii?Q?jcCTVeMhIWB7VvIpiMdh88lwlBp9c9DKnO8p53Gc+x6k+YQVqsGX+bVLN6HU?=
 =?us-ascii?Q?fBHw7EDMiGRySs3EWXl6c1/ebawPzOfAVcyp18Joci8j0XRQbANemrazbBoD?=
 =?us-ascii?Q?s6Me7kQwOf7j0Jw1OcmOobUZ2g9DRUlJC1YTJ2/RldNmnJ4qAM/VA5yNZHn6?=
 =?us-ascii?Q?dWHuyEa/r34UJI3OD1NFfdFq1V1aYPnldGgissEjDGZpEqHt937mDNRx/1D1?=
 =?us-ascii?Q?5Dr7OEgblF+X4S7RFaWN1+qgIuwPlpdc7KgAFBWpl1ltH8HwLAAxlwZhc1zB?=
 =?us-ascii?Q?Ph9TR0k3nce4HyX9enWHvqT+jZT7UalM43Kvuu4ILqJB8SDYAWjcWomZgLia?=
 =?us-ascii?Q?02c7y9WWo3WTZJEnYx+lypURFnOvdGsk0wRqjRI2ZqkqwbdGai5H+PAehHAr?=
 =?us-ascii?Q?aXf9qxA33b1evKMkwAAjrkR1/Z4pksBeq4aTXEPpj903EvKG6+yxLk+Yp8eD?=
 =?us-ascii?Q?WszRTujn/3dfwuo/3VO2iGLpL/iKa8tcqQb+qSb3WUmJNUQmlXs1uZx90Ipn?=
 =?us-ascii?Q?o0RvEoIU05IkqFH5Wxuf0madh0ZoKkFxDi7ip6FoUc7PcbfovuCKVovU/8i8?=
 =?us-ascii?Q?29ThFm6JaLdKmTN3ti9Y0xRxvjMhpd8JTTMdXYVHI7bxU5m3H912sw0OYG8S?=
 =?us-ascii?Q?yIqouZjBb0gcqWVpSZLGBMrYe6c4vOq3FQ/PDdj2rIEvKv3HfoHRMeJOilF2?=
 =?us-ascii?Q?aPYgKEnN+A8qvy97WJCFgyhqCydOR2eZ4wK6S4h532bCsyQTcioxWcI7gbja?=
 =?us-ascii?Q?AaNBXQl0ZEP4pv5w1qdGo/qUNiAPyU8cPhsk1JwT922cvhBDeq/qHFengrtH?=
 =?us-ascii?Q?6bSXkcKVKzXE4yyAekKaN2ZwSnPCWRrnavJID+HN35Zf8ZaN1RLxbhHNZETQ?=
 =?us-ascii?Q?IN0Wn+Q490PdhasHNK5tTGwz3fJzPey1uxcpVcv++wacIilMp/3sf2nYVe7h?=
 =?us-ascii?Q?wyGxTgAK39gxYFkov40CYlgyN8eoqEwZuWaBdqmGYN9Cl0STj+xBvTIikSHE?=
 =?us-ascii?Q?15wUuClsetQ1bfYBY0qcJcw0HRfPaZTkC9gnuCQjfHiOuemCM2Z9VNyK2QFI?=
 =?us-ascii?Q?EL2UPtXf30rWrQt8I+7edRD+0mYqAt7ZGsllIaK5lNJTHYyYeQCsHiCV7xd+?=
 =?us-ascii?Q?LGSq5pFFK/chp7mBEzGThFEPJd5BHAYYmzr1JNbEimVLeJk2r0kP9QvRUTWw?=
 =?us-ascii?Q?CbjFGcZjKCVsyEPHRhS1+eNYqb9Gz1IKU9ZB6jG53Sssqey06TFtzqaHz/mp?=
 =?us-ascii?Q?HgEs9AWSK4Q1o7LXNO0xuyld15h8OLnSU+MXdXtA1do5l+mRM39Ju2gX9qAq?=
 =?us-ascii?Q?XopfF6+4NJbl9v3WWrdR0SX3sSeDG3fWbM05Qs8fJlS3lili8RnpOPHFdxaY?=
 =?us-ascii?Q?QYD5uHQ2dFlIApfTwjeiBjLoyjpiH6ZmBptzaYto5SnqqZ4XWCHUSdszQPZn?=
 =?us-ascii?Q?LA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65e5679e-9376-4afd-7be5-08da7c4948a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 09:59:01.8877
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /o1XsbbZgPSog9nrwfIRagsO+mtxyN6Sum+jL/GeF0W6Sj/hOIBefZpcjIOtz4Gr8KoflRHqMKfBYN4Wp//wfCO2G3DxoFO9zGjvD64CNDE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5506
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Ivan Vecera
> Sent: Monday, August 8, 2022 7:59 PM
> To: netdev@vger.kernel.org
> Cc: moderated list:INTEL ETHERNET DRIVERS <intel-wired-
> lan@lists.osuosl.org>; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> open list <linux-kernel@vger.kernel.org>; Stefan Assmann
> <sassmann@kpanic.de>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S.
> Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net] iavf: Fix deadlock in initializati=
on
>=20
> Fix deadlock that occurs when iavf interface is a part of failover config=
uration.
>=20
> 1. Mutex crit_lock is taken at the beginning of iavf_watchdog_task() 2.
> Function iavf_init_config_adapter() is called when adapter
>    state is __IAVF_INIT_CONFIG_ADAPTER
> 3. iavf_init_config_adapter() calls register_netdevice() that emits
>    NETDEV_REGISTER event
> 4. Notifier function failover_event() then calls
>    net_failover_slave_register() that calls dev_open() 5. dev_open() call=
s
> iavf_open() that tries to take crit_lock in
>    end-less loop
>=20
> Stack trace:
> ...
> [  790.251876]  usleep_range_state+0x5b/0x80 [  790.252547]
> iavf_open+0x37/0x1d0 [iavf] [  790.253139]  __dev_open+0xcd/0x160 [
> 790.253699]  dev_open+0x47/0x90 [  790.254323]
> net_failover_slave_register+0x122/0x220 [net_failover] [  790.255213]
> failover_slave_register.part.7+0xd2/0x180 [failover] [  790.256050]
> failover_event+0x122/0x1ab [failover] [  790.256821]
> notifier_call_chain+0x47/0x70 [  790.257510]
> register_netdevice+0x20f/0x550 [  790.258263]
> iavf_watchdog_task+0x7c8/0xea0 [iavf] [  790.259009]
> process_one_work+0x1a7/0x360 [  790.259705]  worker_thread+0x30/0x390
>=20
> To fix the situation we should check the current adapter state after firs=
t
> unsuccessful mutex_trylock() and return with -EBUSY if it is
> __IAVF_INIT_CONFIG_ADAPTER.
>=20
> Fixes: 226d528512cf ("iavf: fix locking of critical sections")
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 45d097a164ad..f9dcaadc7ea0 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4085,8 +4085,17 @@ static int iavf_open(struct net_device *netdev)

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>